Store the value of the P2P port used in each TestNode instances
ClosedPublic
Actions

Authored by deadalnix on Jan 1 2019, 16:10.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING6f0329fdf657: Store the value of the P2P port used in each TestNode instances
rABC6f0329fdf657: Store the value of the P2P port used in each TestNode instances

Summary

This ensure that we can get rid recomputing the port number based on state that comes from outside the TestNode instance.

Depends on D2247

Test Plan

./test/functional/test_runner.py --extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

deglobp2p_port

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4396
Build 6857: Bitcoin ABC Buildbot (legacy)
Build 6856: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 1 2019, 16:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 1 2019, 16:10

Herald added a subscriber: schancel. · View Herald Transcript

deadalnix edited the summary of this revision. (Show Details)Jan 1 2019, 16:12

deadalnix added a parent revision: D2247: Store the node name as a local variable rather than recomputing it every time in different places.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4396: Diff 6479.Jan 1 2019, 16:20

Fabien accepted this revision.Jan 2 2019, 14:14

This revision is now accepted and ready to land.Jan 2 2019, 14:14

Closed by commit rABC6f0329fdf657: Store the value of the P2P port used in each TestNode instances (authored by deadalnix). · Explain WhyJan 3 2019, 01:04

This revision was automatically updated to reflect the committed changes.

deadalnix mentioned this in D2159: [Part 1 of 4] [qa] De-globalize port seeding.Jan 3 2019, 21:56

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

test_framework.py

8 lines

test_node.py

3 lines

util.py

2 lines

Diff 6479

View Options

test/functional/test_framework/test_framework.py

View Options

test/functional/test_framework/test_node.py

View Options

test/functional/test_framework/util.py

Store the value of the P2P port used in each TestNode instancesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 6479

test/functional/test_framework/test_framework.py

test/functional/test_framework/test_node.py

test/functional/test_framework/util.py

Store the value of the P2P port used in each TestNode instances
ClosedPublic
Actions

Revision Contents
Changeset List