Page MenuHomePhabricator

Store the node name as a local variable rather than recomputing it every time in different places
ClosedPublic

Authored by deadalnix on Jan 1 2019, 14:58.

Details

Summary

This ensures that we don't need to keep various computation in sync or ensure the data required to do the computation are available.

Test Plan

Change the way the name is computed, in order toensure any test relying on the specific name would fail.

./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Jan 1 2019, 14:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 1 2019, 14:58
Herald added a subscriber: schancel. · View Herald Transcript
Fabien requested changes to this revision.Jan 2 2019, 14:09
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/test_framework/test_node.py
44 ↗(On Diff #6478)

Please use the new format method (the % formatting is expected to get deprecated):
"testnode-{}".format(i)

This revision now requires changes to proceed.Jan 2 2019, 14:09
deadalnix updated this revision to Diff 6483.Jan 2 2019, 17:39

Use format

jasonbcox accepted this revision.Jan 2 2019, 18:39
Fabien accepted this revision.Jan 2 2019, 23:00
This revision is now accepted and ready to land.Jan 2 2019, 23:00
This revision was automatically updated to reflect the committed changes.