Page MenuHomePhabricator

Store the node name as a local variable rather than recomputing it every time in different places
ClosedPublic

Authored by deadalnix on Jan 1 2019, 14:58.

Details

Summary

This ensures that we don't need to keep various computation in sync or ensure the data required to do the computation are available.

Test Plan

Change the way the name is computed, in order toensure any test relying on the specific name would fail.

./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
nodename
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4400
Build 6865: Bitcoin ABC Buildbot (legacy)
Build 6864: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Jan 2 2019, 14:09
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/test_framework/test_node.py
44 ↗(On Diff #6478)

Please use the new format method (the % formatting is expected to get deprecated):
"testnode-{}".format(i)

This revision now requires changes to proceed.Jan 2 2019, 14:09
This revision is now accepted and ready to land.Jan 2 2019, 23:00
This revision was automatically updated to reflect the committed changes.