Page MenuHomePhabricator
Differential D2247

Store the node name as a local variable rather than recomputing it every time in different places
ClosedPublic
Actions

Authored by deadalnix on Jan 1 2019, 14:58.

Details

Reviewers
Fabien
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGcec5bc1110a0: Store the node name as a local variable rather than recomputing it every time…
rABCcec5bc1110a0: Store the node name as a local variable rather than recomputing it every time…
Summary

This ensures that we don't need to keep various computation in sync or ensure the data required to do the computation are available.

Test Plan

Change the way the name is computed, in order toensure any test relying on the specific name would fail.

./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
nodename
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4400
Build 6865: Bitcoin ABC Buildbot (legacy)
Build 6864: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 1 2019, 14:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 1 2019, 14:58
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 1 2019, 15:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 1 2019, 15:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4395: Diff 6478.Jan 1 2019, 15:09
deadalnix added a child revision: D2248: Store the value of the P2P port used in each TestNode instances.Jan 1 2019, 16:12
Fabien requested changes to this revision.Jan 2 2019, 14:09
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/test_framework/test_node.py
44 ↗(On Diff #6478)

Please use the new format method (the % formatting is expected to get deprecated):
"testnode-{}".format(i)

This revision now requires changes to proceed.Jan 2 2019, 14:09
deadalnix updated this revision to Diff 6483.Jan 2 2019, 17:39

Use format

teamcity added a comment.Jan 2 2019, 17:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 2 2019, 17:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4400: Diff 6483.Jan 2 2019, 17:49
jasonbcox accepted this revision.Jan 2 2019, 18:39
Fabien accepted this revision.Jan 2 2019, 23:00
This revision is now accepted and ready to land.Jan 2 2019, 23:00
Closed by commit rABCcec5bc1110a0: Store the node name as a local variable rather than recomputing it every time… (authored by deadalnix). · Explain WhyJan 3 2019, 00:55
This revision was automatically updated to reflect the committed changes.
deadalnix mentioned this in D2159: [Part 1 of 4] [qa] De-globalize port seeding.Jan 3 2019, 21:56

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
3 lines
5 lines

Diff 6483

View Options

test/functional/test_framework/test_node.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...