Page MenuHomePhabricator

Accept unrequested blocks with work equal to our tip
ClosedPublic

Authored by jasonbcox on Jan 5 2019, 02:45.

Details

Summary

This is a simple change that makes our accept requirements the
same as our request requirements, (ever so slightly) further
decoupling our consensus logic from our FindNextBlocksToDownload
logic in net_processing.

Partial backport of Core PR 11531 (932f118)
https://github.com/bitcoin/bitcoin/pull/11531/commits/932f118e6a3779bb3d6c3cc83963cf34ac150e42

This looks safe to me since it does not introduce any DoS vector beyond what currently exists.

Test Plan

test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr11531-3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4415
Build 6895: Bitcoin ABC Buildbot (legacy)
Build 6894: arc lint + arc unit