Add const to methods that don't modify the object for which it is called
ClosedPublic
Actions

Authored by Fabien on Jan 9 2019, 18:14.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING8fd044472b4f: Add const to methods that don't modify the object for which it is called
rABC8fd044472b4f: Add const to methods that don't modify the object for which it is called

Summary

Backport of core PR9964

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR9964

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4455
Build 6974: Bitcoin ABC Buildbot (legacy)
Build 6973: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 9 2019, 18:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 9 2019, 18:15

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox accepted this revision.Jan 9 2019, 18:20

This revision is now accepted and ready to land.Jan 9 2019, 18:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4455: Diff 6569.Jan 9 2019, 18:26

Fabien added a child revision: D2281: Avoid opening copied wallet databases simultaneously.Jan 9 2019, 21:00

Closed by commit rABC8fd044472b4f: Add const to methods that don't modify the object for which it is called (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyJan 10 2019, 20:12

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

2 lines

2 lines

2 lines

2 lines

2 lines

3 lines

qt/

2 lines

2 lines

14 lines

2 lines

2 lines

transactionrecord.cpp

2 lines

transactiontablemodel.h

2 lines

walletmodeltransaction.h

8 lines

walletmodeltransaction.cpp

8 lines

scheduler.h

2 lines

streams.h

4 lines

test/

4 lines

4 lines

2 lines

2 lines

wallet/

db.h

2 lines

Diff 6569

View Options

src/addrdb.h

View Options

src/dbwrapper.h

View Options

src/dbwrapper.cpp

View Options

src/merkleblock.h

View Options

src/miner.h

View Options

src/miner.cpp

View Options

src/qt/bitcoin.cpp

View Options

src/qt/modaloverlay.h

View Options

src/qt/optionsmodel.h

View Options

src/qt/optionsmodel.cpp

View Options

src/qt/transactionrecord.h

View Options

src/qt/transactionrecord.cpp

View Options

src/qt/transactiontablemodel.h

View Options

src/qt/walletmodeltransaction.h

View Options

src/qt/walletmodeltransaction.cpp

View Options

src/scheduler.h

View Options

src/streams.h

View Options

src/test/coins_tests.cpp

View Options

src/test/prevector_tests.cpp

View Options

src/test/script_tests.cpp

View Options

src/txmempool.h

View Options

Add const to methods that don't modify the object for which it is calledClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 6569

src/addrdb.h

src/dbwrapper.h

src/dbwrapper.cpp

src/merkleblock.h

src/miner.h

src/miner.cpp

src/qt/bitcoin.cpp

src/qt/modaloverlay.h

src/qt/optionsmodel.h

src/qt/optionsmodel.cpp

src/qt/transactionrecord.h

src/qt/transactionrecord.cpp

src/qt/transactiontablemodel.h

src/qt/walletmodeltransaction.h

src/qt/walletmodeltransaction.cpp

src/scheduler.h

src/streams.h

src/test/coins_tests.cpp

src/test/prevector_tests.cpp

src/test/script_tests.cpp

src/txmempool.h

src/wallet/db.h

Add const to methods that don't modify the object for which it is called
ClosedPublic
Actions

Revision Contents
Changeset List