Page MenuHomePhabricator

[tests] allow tests to be run with --usecli
ClosedPublic

Authored by Fabien on Jan 23 2019, 17:44.

Details

Summary

test_framework accepts a new --usecli parameter. Running the test with
this parameter will cause all RPCs to be sent through bitcoin-cli rather
than directly over http. By default, individual test cases do not
support --usecli, and self.supports_cli must be set to True in the
set_test_params method.

We can make supports_cli default to True in future once we know which
tests will fail with use_cli.

Partial backport of core PR11970 (commit f6ade9c)

Depends on D2398

Test Plan
./test/functional/test_runner.py interface_bitcoin_cli

./test/functional/test_runner.py --usecli interface_bitcoin_cli

Check it gets skipped

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11970_part4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4683
Build 7429: Bitcoin ABC Buildbot (legacy)
Build 7428: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 24 2019, 14:35
This revision was automatically updated to reflect the committed changes.