Improve shutdown process
ClosedPublic
Actions

Authored by jasonbcox on Feb 13 2019, 19:45.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING355b1f1d5369: Improve shutdown process
rABC355b1f1d5369: Improve shutdown process

Summary

Backport of Core PR11006
https://github.com/bitcoin/bitcoin/pull/11006
Prevents a 2-5 second delay every time a node shuts down.

Test Plan

test_runner.py
Before change:

ALL                                     | ✓ Passed  | 579 s (accumulated)
Runtime: 312 s

After change:

ALL                                     | ✓ Passed  | 325 s (accumulated)
Runtime: 183 s

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Feb 13 2019, 19:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 13 2019, 19:45

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4977: Diff 7326.Feb 13 2019, 19:59

Fabien accepted this revision.Feb 13 2019, 21:21

This revision is now accepted and ready to land.Feb 13 2019, 21:21

@dagurval points out, maybe we want to go straight for https://github.com/bitcoin/bitcoin/pull/14670 ... sounds like this exits uncleanly in some cases?

deadalnix accepted this revision.Feb 13 2019, 22:53

@dagurval points out, maybe we want to go straight for https://github.com/bitcoin/bitcoin/pull/14670 ... sounds like this exits uncleanly in some cases?

Considering this and the importance of the 0.19 release, I'd prefer to get https://reviews.bitcoinabc.org/T537 ready to land shortly after landing this diff.
Although the risk doesn't seem that high, I don't like the idea of increased flakiness impacting our ability to react to fixing issues with the initial May upgrade release.

Closed by commit rABC355b1f1d5369: Improve shutdown process (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by jasonbcox). · Explain WhyFeb 21 2019, 19:54

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGING355b1f1d5369: Improve shutdown process.Sep 18 2019, 22:29

In D2544#59209, @jasonbcox wrote:

@dagurval points out, maybe we want to go straight for https://github.com/bitcoin/bitcoin/pull/14670 ... sounds like this exits uncleanly in some cases?

Considering this and the importance of the 0.19 release, I'd prefer to get https://reviews.bitcoinabc.org/T537 ready to land shortly after landing this diff.
Although the risk doesn't seem that high, I don't like the idea of increased flakiness impacting our ability to react to fixing issues with the initial May upgrade release.

What about for this May release? :-) D5170

Revision Contents
Changeset List

Path

Size

src/

httpserver.cpp

2 lines

Diff 7432

View Options

Improve shutdown processClosedPublicActions