Page MenuHomePhabricator
Differential D2589

Added tests verifying outputs for getblock rpc command
ClosedPublic
Actions

Authored by nakihito on Feb 22 2019, 20:44.

Details

Reviewers
deadalnix
jasonbcox
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING8aa43fbcd510: Added tests verifying outputs for getblock rpc command
rABC8aa43fbcd510: Added tests verifying outputs for getblock rpc command
Summary

Added tests to verify output from the getblock (verbose) rpc command. Follow up to D2499.

Test Plan

test_runner.py rpc_blockchain

Diff Detail

Repository
rABC Bitcoin ABC
Branch
HexTest
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5051
Build 8165: Bitcoin ABC Buildbot (legacy)
Build 8164: arc lint + arc unit

Event Timeline

nakihito created this revision.Feb 22 2019, 20:44
Owners added a reviewer: Restricted Owners Package.Feb 22 2019, 20:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 22 2019, 20:44
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Feb 22 2019, 20:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5049: Diff 7444.Feb 22 2019, 20:57
teamcity added a comment.Feb 22 2019, 20:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

nakihito edited the summary of this revision. (Show Details)Feb 22 2019, 22:18
deadalnix requested changes to this revision.Feb 23 2019, 00:52
deadalnix added inline comments.
test/functional/rpc_blockchain.py
211 ↗(On Diff #7444)

This formatting is really bad. You can do like _test_getblockheader to avoid repeating selfnode[0] all the time.

This revision now requires changes to proceed.Feb 23 2019, 00:53
nakihito updated this revision to Diff 7447.Feb 23 2019, 01:15

Reformatted rpc calls to use a node variable like other tests.

teamcity added a comment.Feb 23 2019, 01:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5051: Diff 7447.Feb 23 2019, 01:28
teamcity added a comment.Feb 23 2019, 01:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien accepted this revision.Feb 23 2019, 17:21
deadalnix accepted this revision.Feb 25 2019, 22:55
This revision is now accepted and ready to land.Feb 25 2019, 22:55
Closed by commit rABC8aa43fbcd510: Added tests verifying outputs for getblock rpc command (authored by nakihito). · Explain WhyFeb 26 2019, 01:11
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGING8aa43fbcd510: Added tests verifying outputs for getblock rpc command.Sep 18 2019, 22:31
Fabien mentioned this in D12427: rpc: calculate fees in getblock using BlockUndo data.Nov 7 2022, 17:20
Fabien mentioned this in rABC5dc7e843eac0: rpc: calculate fees in getblock using BlockUndo data.Nov 7 2022, 20:47

Revision Contents
Changeset List

PathSize
test/
functional/
39 lines

Diff 7447

View Options

test/functional/rpc_blockchain.py

Loading...