Page MenuHomePhabricator
Differential D2700

Remove redundant locks
ClosedPublic
Actions

Authored by nakihito on Mar 18 2019, 20:20.

Details

Reviewers
jasonbcox
deadalnix
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGbf97bcfb8254: Remove redundant locks
rABCbf97bcfb8254: Remove redundant locks
Summary
  • SetAddressBook(...) is locking cs_wallet internally
  • DelAddressBook(...) is locking cs_wallet internally

Completes T557

Backport of PR11733
https://github.com/bitcoin/bitcoin/pull/11733

Test Plan

make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
BackportPR11733
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5234
Build 8531: Bitcoin ABC Buildbot (legacy)
Build 8530: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 18 2019, 20:20
Owners added a reviewer: Restricted Owners Package.Mar 18 2019, 20:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 18 2019, 20:20
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Mar 18 2019, 20:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 18 2019, 20:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5234: Diff 7726.Mar 18 2019, 20:36
jasonbcox accepted this revision.Mar 18 2019, 20:36
This revision is now accepted and ready to land.Mar 18 2019, 20:36
Closed by commit rABCbf97bcfb8254: Remove redundant locks (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by nakihito). · Explain WhyMar 18 2019, 20:37
This revision was automatically updated to reflect the committed changes.
nakihito edited the summary of this revision. (Show Details)Mar 18 2019, 21:43
nakihito edited the summary of this revision. (Show Details)Mar 18 2019, 21:47
Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGbf97bcfb8254: Remove redundant locks.Sep 18 2019, 22:43

Revision Contents
Changeset List

PathSize
src/
qt/
15 lines

Diff 7726

View Options

src/qt/addresstablemodel.cpp

Loading...