Page MenuHomePhabricator

refactor: remove usage of locale dependent std::isspace
ClosedPublic

Authored by Fabien on Mar 19 2019, 13:31.

Details

Summary

Don't rely on locale dependent functions in base_blob<BITS>::SetHex(...)
(uint256), DecodeBase58(...), ParseMoney(...) and ParseHex(...)

Backport of core PR14585

Depends on D2698

Test Plan
./test/lint/lint-locale-dependence.sh

Ensure there is no output

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14585
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5246
Build 8555: Bitcoin ABC Buildbot (legacy)
Build 8554: arc lint + arc unit