Page MenuHomePhabricator
Differential D2702

qa: Improve getchaintxstats functional test
ClosedPublic
Actions

Authored by jasonbcox on Mar 18 2019, 23:57.

Details

Reviewers
Fabien
deadalnix
nakihito
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGc670a0701e3a: qa: Improve getchaintxstats functional test
rABCc670a0701e3a: qa: Improve getchaintxstats functional test
Summary

Completes T561.
Depends on D2711.
Backport of PR12083
https://github.com/bitcoin/bitcoin/pull/12083/files

Test Plan

make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
BackportPR12083
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5252
Build 8567: Bitcoin ABC Buildbot (legacy)
Build 8566: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 18 2019, 23:57
Owners added a reviewer: Restricted Owners Package.Mar 18 2019, 23:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 18 2019, 23:57
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Mar 18 2019, 23:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox requested changes to this revision.Mar 19 2019, 00:02

Missing the refactor in rpc/blockchain.cpp

This revision now requires changes to proceed.Mar 19 2019, 00:02
nakihito updated this revision to Diff 7731.Mar 19 2019, 00:05

Squashed two commits together.

teamcity added a comment.Mar 19 2019, 00:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

nakihito updated this revision to Diff 7732.Mar 19 2019, 00:07

Actually squashed two commits together.

teamcity added a comment.Mar 19 2019, 00:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 19 2019, 00:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5236: Diff 7730.Mar 19 2019, 00:13
teamcity added a comment.Mar 19 2019, 00:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5237: Diff 7731.Mar 19 2019, 00:20
teamcity added a comment.Mar 19 2019, 00:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5238: Diff 7732.Mar 19 2019, 00:22
jasonbcox requested changes to this revision.Mar 19 2019, 00:29
jasonbcox added inline comments.
test/functional/rpc_blockchain.py
79 ↗(On Diff #7732)

This is not part of the original PR. Smells like another dependency that needs backporting first.

This revision now requires changes to proceed.Mar 19 2019, 00:29
nakihito added inline comments.Mar 19 2019, 00:39
test/functional/rpc_blockchain.py
79 ↗(On Diff #7732)

You're right. Found the PR for it: https://github.com/promag/bitcoin/commit/7444149de37a0cce9b28ca92f0af16cac8689873

Will start working on that after I look through it some more to check for other dependencies.

jasonbcox added inline comments.Mar 19 2019, 00:43
test/functional/rpc_blockchain.py
79 ↗(On Diff #7732)

Note that this is just a commit, which may be part of a larger PR.
I recommend looking from the core repo rather than promag's personal repo: https://github.com/bitcoin/bitcoin/commit/7444149de37a0cce9b28ca92f0af16cac8689873
and then the PR should be available as a link master (#12317) : https://github.com/bitcoin/bitcoin/pull/12317

nakihito edited the summary of this revision. (Show Details)Mar 19 2019, 19:03
nakihito added a parent revision: D2711: Document method for reviewers to verify chainTxData.
nakihito updated this revision to Diff 7752.EditedMar 19 2019, 19:04
nakihito edited the summary of this revision. (Show Details)

Rebased off of D2711.

teamcity added a comment.Mar 19 2019, 19:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 19 2019, 19:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5252: Diff 7752.Mar 19 2019, 19:18
nakihito edited the summary of this revision. (Show Details)Mar 19 2019, 19:54
Fabien accepted this revision.Mar 20 2019, 10:20
jasonbcox accepted this revision.Mar 20 2019, 17:00
This revision is now accepted and ready to land.Mar 20 2019, 17:00
jasonbcox commandeered this revision.Apr 4 2019, 19:19
jasonbcox edited reviewers, added: nakihito; removed: jasonbcox.
jasonbcox updated this revision to Diff 7949.Apr 4 2019, 19:19

Rebase

teamcity added a comment.Apr 4 2019, 19:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 4 2019, 19:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5384: Diff 7949.Apr 4 2019, 19:34
Closed by commit rABCc670a0701e3a: qa: Improve getchaintxstats functional test (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by jasonbcox). · Explain WhyApr 4 2019, 19:37
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGINGc670a0701e3a: qa: Improve getchaintxstats functional test.Sep 18 2019, 22:53

Revision Contents
Changeset List

PathSize
src/
rpc/
33 lines
test/
functional/
27 lines

Diff 7752

View Options

src/rpc/blockchain.cpp

Loading...
View Options

test/functional/rpc_blockchain.py

Loading...