Page MenuHomePhabricator

qa: Improve getchaintxstats functional test
ClosedPublic

Authored by jasonbcox on Mar 18 2019, 23:57.

Details

Reviewers
Fabien
deadalnix
nakihito
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGc670a0701e3a: qa: Improve getchaintxstats functional test
rABCc670a0701e3a: qa: Improve getchaintxstats functional test
Summary

Completes T561.
Depends on D2711.
Backport of PR12083
https://github.com/bitcoin/bitcoin/pull/12083/files

Test Plan

make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
BackportPR12083
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5238
Build 8539: Bitcoin ABC Buildbot (legacy)
Build 8538: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Mar 18 2019, 23:57
jasonbcox requested changes to this revision.Mar 19 2019, 00:02

Missing the refactor in rpc/blockchain.cpp

This revision now requires changes to proceed.Mar 19 2019, 00:02

Squashed two commits together.

Actually squashed two commits together.

jasonbcox requested changes to this revision.Mar 19 2019, 00:29
jasonbcox added inline comments.
test/functional/rpc_blockchain.py
79

This is not part of the original PR. Smells like another dependency that needs backporting first.

This revision now requires changes to proceed.Mar 19 2019, 00:29
test/functional/rpc_blockchain.py
79

You're right. Found the PR for it: https://github.com/promag/bitcoin/commit/7444149de37a0cce9b28ca92f0af16cac8689873

Will start working on that after I look through it some more to check for other dependencies.

test/functional/rpc_blockchain.py
79

Note that this is just a commit, which may be part of a larger PR.
I recommend looking from the core repo rather than promag's personal repo: https://github.com/bitcoin/bitcoin/commit/7444149de37a0cce9b28ca92f0af16cac8689873
and then the PR should be available as a link master (#12317) : https://github.com/bitcoin/bitcoin/pull/12317

nakihito edited the summary of this revision. (Show Details)

Rebased off of D2711.

This revision is now accepted and ready to land.Mar 20 2019, 17:00
jasonbcox edited reviewers, added: nakihito; removed: jasonbcox.
This revision was automatically updated to reflect the committed changes.