Details

Reviewers

jasonbcox
deadalnix
Fabien

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

Fix pruneheight help text.
Move fPruneMode block to match output ordering with help text.
Add functional tests for new fields in getblockchaininfo.

Backport of PR11367
https://github.com/bitcoin/bitcoin/pull/11367/

Depends on D2730
Depends on D2778

Completes T462

Test Plan

make check
test_runner.py
bitcoin-cli help getblockchaininfo should have display information about "size_on_disk", "automatic_pruning", and "prune_target_size"
bitcoin-cli getblockchaininfo should display "size_on_disk" and, if the prune option is enabled, "prune_height", "automatic_pruning", and "prune_target_size".

Diff Detail

Repository

rABC Bitcoin ABC

Branch

BackportPR11367

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5344
Build 8750: Bitcoin ABC Buildbot (legacy)
Build 8749: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 23 2019, 02:05

Owners added a reviewer: Restricted Owners Package.Mar 23 2019, 02:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 23 2019, 02:05

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5286: Diff 7807.Mar 23 2019, 02:20

deadalnix requested changes to this revision.Mar 23 2019, 14:44

deadalnix added inline comments.

src/validation.cpp
4070 ↗	(On Diff #7807)	Revert
src/validation.h
426 ↗	(On Diff #7807)	dot at the end of sentence.

This revision now requires changes to proceed.Mar 23 2019, 14:44

jasonbcox requested changes to this revision.Mar 25 2019, 17:29

jasonbcox added inline comments.

src/validation.h
426 ↗	(On Diff #7807)	This line also needs correct comment linting similar to the revert you pointed out.

Fixed comment formatting and punctuation.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5291: Diff 7817.Mar 25 2019, 18:59

jasonbcox accepted this revision.Mar 25 2019, 19:54

Fabien edited the summary of this revision. (Show Details)Mar 26 2019, 10:05

Fabien added a parent revision: D2730: Merge #10858: [RPC] Add "warnings" field to getblockchaininfo and unify "warnings" field in get*info RPCs.

Fabien requested changes to this revision.Mar 26 2019, 10:16

Fabien added inline comments.

src/rpc/blockchain.cpp
1239 ↗	(On Diff #7817)	There is something wrong with this layout. The D2730 version doesn't match the one in this diff, you should check the layout and rebase.
src/validation.cpp
4092 ↗	(On Diff #7817)	Remove

This revision now requires changes to proceed.Mar 26 2019, 10:16

Rebased, fixed indentation, and removed excess new line.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5308: Diff 7838.Mar 26 2019, 21:04

Fabien requested changes to this revision.Mar 28 2019, 08:33

Fabien added inline comments.

src/rpc/blockchain.cpp
1239 ↗	(On Diff #7838)	This is still not the same layout than D2730, on which this diff is based on. You may have missed to squash some commits before rebasing.