Differential D2810

Merge #12630: Provide useful error message if datadir is not writable.
ClosedPublic
Actions

Authored by jasonbcox on Apr 16 2019, 20:47.

Tags

None

Subscribers

None

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING297d67419ba8: Merge #12630: Provide useful error message if datadir is not writable.
rABC297d67419ba8: Merge #12630: Provide useful error message if datadir is not writable.

Summary

8674e74 Provide relevant error message if datadir is not writable. (murrayn)

Pull request description:

If the --datadir exists, but is not writable, the current error message on startup is 'Cannot obtain a lock on data directory foo. Bitcoin Core is probably already running.' This is misleading.

I believe this PR addresses #11668, although the issue is not Windows-specific.

Tree-SHA512: 10cbbaea433072aee4fb3e8938a72073c7a5c841f7a7685c9e12549c322b2925c7d34bac254ac33021b23132bfc352c058712bc9542298cf86f8fd9757f528b2

Backport Core PR 12630
https://github.com/bitcoin/bitcoin/pull/12630/files
Completes T605
Depends on D2809

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr12630

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5473
Build 9008: Bitcoin ABC Buildbot (legacy)
Build 9007: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 16 2019, 20:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 16 2019, 20:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fixed brackets

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5473: Diff 8082.Apr 16 2019, 21:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5474: Diff 8083.Apr 16 2019, 21:02

jasonbcox added a child revision: D2811: Refactor: separate gui from wallet and node.Apr 16 2019, 22:49

Fabien accepted this revision.Apr 17 2019, 09:40

This revision is now accepted and ready to land.Apr 17 2019, 09:40

Closed by commit rABC297d67419ba8: Merge #12630: Provide useful error message if datadir is not writable. (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyApr 17 2019, 15:06

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGING297d67419ba8: Merge #12630: Provide useful error message if datadir is not writable..Sep 18 2019, 22:59

Revision Contents
Changeset List

Path

Size

src/

5 lines

test/

15 lines

1 line

12 lines

Diff 8082

src/init.cpp

Loading...

src/test/util_tests.cpp

Loading...

src/util.h

Loading...

src/util.cpp

Loading...