Page MenuHomePhabricator
Differential D2872

blockfilter: Refactor and add tests for BlockFilter construction
ClosedPublic
Actions

Authored by markblundeberg on Apr 24 2019, 05:18.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Maniphest Tasks
T589: BIP157 & BIP158 backports
Commits
rSTAGING7a78809ec2f9: blockfilter: Refactor and add tests for BlockFilter construction
rABC7a78809ec2f9: blockfilter: Refactor and add tests for BlockFilter construction
Summary

This is a backport of core PR 14172
e4ed8ce2c blockfilter: Remove default clause in switch statement.
c30620983 blockfilter: Additional constructors for BlockFilter.
20b812993 blockfilter: Refactor GCS params into struct.

Depends on D2867

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr14172
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5605
Build 9272: Bitcoin ABC Buildbot (legacy)
Build 9271: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Apr 24 2019, 05:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 24 2019, 05:18
Herald added a reviewer: deadalnix. · View Herald Transcript
markblundeberg added a task: T589: BIP157 & BIP158 backports.Apr 24 2019, 05:19
teamcity added a comment.Apr 24 2019, 05:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5589: Diff 8255.Apr 24 2019, 05:32
teamcity added a comment.Apr 24 2019, 05:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien requested changes to this revision.Apr 25 2019, 09:09
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/blockfilter.cpp
104 ↗(On Diff #8255)

uint8_t

222 ↗(On Diff #8255)

dito

This revision now requires changes to proceed.Apr 25 2019, 09:09
markblundeberg updated this revision to Diff 8279.Apr 26 2019, 05:04
markblundeberg marked 2 inline comments as done.

address Fabien comments

src/blockfilter.cpp
104 ↗(On Diff #8255)

Argh, I don't know how I missed that .. I thought I had caught them all!

teamcity added a comment.Apr 26 2019, 05:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 26 2019, 05:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5605: Diff 8279.Apr 26 2019, 05:20
Fabien accepted this revision.Apr 30 2019, 13:05
This revision is now accepted and ready to land.Apr 30 2019, 13:05
Closed by commit rABC7a78809ec2f9: blockfilter: Refactor and add tests for BlockFilter construction (authored by jimpo, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 4 2019, 17:32
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING7a78809ec2f9: blockfilter: Refactor and add tests for BlockFilter construction.Sep 18 2019, 23:14

Revision Contents
Changeset List

PathSize
src/
bench/
4 lines
58 lines
63 lines
test/
27 lines

Diff 8279

View Options

src/bench/gcs_filter.cpp

Loading...
View Options

src/blockfilter.h

Loading...
View Options

src/blockfilter.cpp

Loading...
View Options

src/test/blockfilter_tests.cpp

Loading...