Page MenuHomePhabricator
Differential D2904

[index] Create new TxIndex class.
ClosedPublic
Actions

Authored by markblundeberg on May 2 2019, 18:02.

Details

Reviewers
deadalnix
jasonbcox
Fabien
Group Reviewers
Restricted Project
Maniphest Tasks
T617: Backport PR 13033 "Build txindex in parallel with validation"
Commits
rSTAGING8679dd55ea56: [index] Create new TxIndex class.
rABC8679dd55ea56: [index] Create new TxIndex class.
Summary

backports four commits from core PR13033:
f90c3a62f [index] TxIndex method to wait until caught up.
70d510d93 [index] Allow TxIndex sync thread to be interrupted.
94b4f8bbb [index] TxIndex initial sync thread.
34d68bf3a [index] Create new TxIndex class.

Depends D2901

Test Plan

build (tests are available in a later commit but not compatible
with current FindTx definition)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
idxpar3-old
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/index/txindex.cpp:S&RXLint
Unit
No Test Coverage
Build Status
Buildable 5646
Build 9354: Bitcoin ABC Buildbot (legacy)
Build 9353: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 2 2019, 18:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 2 2019, 18:02
Herald added a reviewer: deadalnix. · View Herald Transcript
markblundeberg added a task: T617: Backport PR 13033 "Build txindex in parallel with validation".May 2 2019, 18:03
teamcity added a comment.May 2 2019, 18:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg edited the summary of this revision. (Show Details)May 2 2019, 18:12
markblundeberg added a parent revision: D2901: [db] Create separate database for txindex..
teamcity added a comment.May 2 2019, 18:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5646: Diff 8339.May 2 2019, 18:18
markblundeberg updated this revision to Diff 8342.May 2 2019, 18:24

fix linting (had an exception imported from the future)

teamcity added a comment.May 2 2019, 18:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5649: Diff 8342.May 2 2019, 18:38
teamcity added a comment.May 2 2019, 18:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

markblundeberg added a child revision: D2924: [txindex] Activate new transaction index code that runs in background.May 5 2019, 01:22
markblundeberg added a child revision: D2927: scripted-diff: Rename SetBestChain callback ChainStateFlushed.May 5 2019, 04:10
deadalnix requested changes to this revision.May 5 2019, 16:49

No space in PR12345. please fix description.

This revision now requires changes to proceed.May 5 2019, 16:49
markblundeberg requested review of this revision.May 5 2019, 16:57
markblundeberg edited the summary of this revision. (Show Details)
In D2904#69247, @deadalnix wrote:

No space in PR12345. please fix description.

OK, will fix other diffs likewise.

deadalnix added a comment.May 5 2019, 17:04

You also need to bring test/txindex_tests.cpp with it.

markblundeberg added a comment.May 5 2019, 17:10
In D2904#69264, @deadalnix wrote:

You also need to bring test/txindex_tests.cpp with it.

Unfortunately the tests don't work here because FindTx gets redefined in a later commit (that only occurs after the 'activation' code)

markblundeberg added a comment.May 9 2019, 01:35

To make it easy to compare: https://github.com/bitcoin/bitcoin/compare/34d68bf3a~1..f90c3a62f

markblundeberg added reviewers: jasonbcox, Fabien.May 9 2019, 01:35
deadalnix accepted this revision.May 16 2019, 17:02
This revision is now accepted and ready to land.May 16 2019, 17:02
Closed by commit rABC8679dd55ea56: [index] Create new TxIndex class. (authored by jimpo, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 20 2019, 23:10
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING8679dd55ea56: [index] Create new TxIndex class..Sep 18 2019, 23:38

Revision Contents
Changeset List

PathSize
src/
1 line
2 lines
index/
87 lines
281 lines
1 line
2 lines

Diff 8339

View Options

src/CMakeLists.txt

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/index/txindex.h

Loading...
View Options

src/index/txindex.cpp

Loading...
View Options

src/threadinterrupt.h

Loading...
View Options

src/threadinterrupt.cpp

Loading...