Page MenuHomePhabricator
Differential D3032

[CMAKE] Fix bitcoind cross build for OSX
ClosedPublic
Actions

Authored by Fabien on May 13 2019, 10:15.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGc31534bf8d30: [CMAKE] Fix bitcoind cross build for OSX
rABCc31534bf8d30: [CMAKE] Fix bitcoind cross build for OSX
Summary

Use CMAKE_<LANG>_FLAGS_INIT (note the _INIT) variables to set the
target. This variable will set the corresponding CMAKE_<LANG>_FLAGS
variable, but is also used to initalize the CMAKE_REQUIRED_FLAGS for
various check_xxx functions such as check_include_file() or
check_symbol_exist(). This fixes the architecture mismatch issue.

Depends on D3031.

Test Plan
mkdir buildcmake && cd buildcmake
cmake -GNinja -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/OSX.cmake \
-DBUILD_BITCOIN_QT=OFF ..
ninja

The build should succeed.
Check the generated src/bitcoind runs on OSX >= 10.8 (tested on OSX
Sierra 10.12.6).

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_osx_fix_bitcoind
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5828
Build 9718: Bitcoin ABC Buildbot (legacy)
Build 9717: arc lint + arc unit

Event Timeline

Fabien created this revision.May 13 2019, 10:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 13 2019, 10:16
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 13 2019, 10:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D3033: [CMAKE] Add missing files to build bitcoin-qt on OSX.May 13 2019, 10:20
Harbormaster completed remote builds in B5828: Diff 8628.May 13 2019, 10:30
teamcity added a comment.May 13 2019, 10:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.May 16 2019, 16:58

I'm pretty sure the dependency graph for this is completely wrong.

This revision is now accepted and ready to land.May 16 2019, 16:58
Closed by commit rABCc31534bf8d30: [CMAKE] Fix bitcoind cross build for OSX (authored by Fabien). · Explain WhyMay 17 2019, 19:57
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in D3018: [CMAKE] Fix CMake cross build for OSX.May 25 2019, 07:15
Fabien added a commit: rSTAGINGc31534bf8d30: [CMAKE] Fix bitcoind cross build for OSX.Sep 18 2019, 23:36

Revision Contents
Changeset List

PathSize
cmake/
platforms/
4 lines

Diff 8628

View Options

cmake/platforms/OSX.cmake

Loading...