Page MenuHomePhabricator
Differential D3091

[CMAKE] Move-only: refactor qt/CMakeLists.txt
ClosedPublic
Actions

Authored by Fabien on May 22 2019, 13:29.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING38f2e197dc3c: [CMAKE] Move-only: refactor qt/CMakeLists.txt
rABC38f2e197dc3c: [CMAKE] Move-only: refactor qt/CMakeLists.txt
Summary

This is a move only diff that puts related things together.
It tries to avoid duplicating the tests in the file, and moves the
static build section after the bitcoin-qt-base target is defined
(prepare for adding the platform plugins to the target).

Test Plan
mkdir buildcmake && cd buildcmake
cmake -GNinja ..
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_refactor_qt_static
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5936
Build 9932: Bitcoin ABC Buildbot (legacy)
Build 9931: arc lint + arc unit

Event Timeline

Fabien created this revision.May 22 2019, 13:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 22 2019, 13:29
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 22 2019, 13:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien mentioned this in D3017: [CMAKE] Add QT plugins according to the target platform.May 22 2019, 13:32
Fabien added a child revision: D3017: [CMAKE] Add QT plugins according to the target platform.May 22 2019, 13:32
teamcity added a comment.May 22 2019, 13:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5936: Diff 8800.May 22 2019, 13:45
deadalnix accepted this revision.May 23 2019, 12:01
This revision is now accepted and ready to land.May 23 2019, 12:01
Closed by commit rABC38f2e197dc3c: [CMAKE] Move-only: refactor qt/CMakeLists.txt (authored by Fabien). · Explain WhyMay 23 2019, 15:44
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC38f2e197dc3c: [CMAKE] Move-only: refactor qt/CMakeLists.txt.
Fabien added a commit: rSTAGING38f2e197dc3c: [CMAKE] Move-only: refactor qt/CMakeLists.txt.Sep 18 2019, 23:41

Revision Contents
Changeset List

PathSize
src/
qt/
103 lines

Diff 8800

View Options

src/qt/CMakeLists.txt

Loading...