Page MenuHomePhabricator
Differential D3329

[txindex] transaction Hash -> TxId
ClosedPublic
Actions

Authored by markblundeberg on Jun 13 2019, 23:34.

Details

Reviewers
jasonbcox
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGb343df905518: [txindex] transaction Hash -> TxId
rABCb343df905518: [txindex] transaction Hash -> TxId
Summary

this updates for current ABC convention, using GetId() instead of
GetHash(), and using the TxId type.

Migration-related types have been left as uint256 since that was how the old
txindex code worked.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
txindex_txid
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6349
Build 10745: Bitcoin ABC Buildbot (legacy)
Build 10744: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jun 13 2019, 23:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 13 2019, 23:34
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jun 13 2019, 23:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg mentioned this in D3310: Merge #14085: index: Fix for indexers skipping genesis block..Jun 13 2019, 23:40
Harbormaster completed remote builds in B6326: Diff 9417.Jun 13 2019, 23:40
teamcity added a comment.Jun 13 2019, 23:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox requested changes to this revision.Jun 14 2019, 00:24
jasonbcox added inline comments.
src/index/txindex.cpp
58 ↗(On Diff #9417)

hash -> tx ID

src/index/txindex.h
44 ↗(On Diff #9417)

Don't let this fall out of date.

This revision now requires changes to proceed.Jun 14 2019, 00:24
markblundeberg marked 2 inline comments as done.Jun 14 2019, 01:56
markblundeberg updated this revision to Diff 9423.Jun 14 2019, 01:57

missed a few spots!

teamcity added a comment.Jun 14 2019, 01:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 14 2019, 02:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6331: Diff 9423.Jun 14 2019, 02:03
Fabien accepted this revision.Jun 14 2019, 06:22
deadalnix accepted this revision.Jun 14 2019, 13:15
jasonbcox accepted this revision.Jun 14 2019, 16:18
This revision is now accepted and ready to land.Jun 14 2019, 16:18
markblundeberg updated this revision to Diff 9451.EditedJun 14 2019, 17:41

rebase for conflict (txindex_tests' GetHash -> GetId changes were done in D3315 too)

teamcity added a comment.Jun 14 2019, 17:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 14 2019, 17:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6349: Diff 9451.Jun 14 2019, 17:48
Closed by commit rABCb343df905518: [txindex] transaction Hash -> TxId (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJun 14 2019, 18:21
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABCb343df905518: [txindex] transaction Hash -> TxId.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGb343df905518: [txindex] transaction Hash -> TxId.Sep 19 2019, 00:19

Revision Contents
Changeset List

PathSize
src/
index/
10 lines
24 lines

Diff 9451

View Options

src/index/txindex.h

Loading...
View Options

src/index/txindex.cpp

Loading...