Page MenuHomePhabricator
Differential D3374

Merge #12392: Fix ignoring tx data requests when fPauseSend is set on a peer
ClosedPublic
Actions

Authored by markblundeberg on Jun 20 2019, 20:06.

Details

Reviewers
deadalnix
jasonbcox
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING1234e9d1cab7: Merge #12392: Fix ignoring tx data requests when fPauseSend is set on a peer
rABC1234e9d1cab7: Merge #12392: Fix ignoring tx data requests when fPauseSend is set on a peer
Summary

PR12392 backport https://github.com/bitcoin/bitcoin/pull/12392/files
c4af738 Fix ignoring tx data requests when fPauseSend is set on a peer (Matt Corallo)

Pull request description:

This resolves a bug introduced in
66aa1d58a158991a8014a91335b5bc9c00062f56 where, if when responding
to a series of transaction requests in a getdata we hit the send
buffer limit and set fPauseSend, we will skip one transaction per
call to ProcessGetData.

Bug found by Cory Fields (@theuni).

Probably worth slipping into 0.16 :/.

(cf D2606 - the corresponding diff of ours)

Test Plan

make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
patch123
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6415
Build 10877: Bitcoin ABC Buildbot (legacy)
Build 10876: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jun 20 2019, 20:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 20 2019, 20:06
teamcity added a comment.Jun 20 2019, 20:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg edited the summary of this revision. (Show Details)Jun 20 2019, 20:11
markblundeberg edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B6415: Diff 9552.Jun 20 2019, 20:12
teamcity added a comment.Jun 20 2019, 20:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.Jun 20 2019, 20:15
This revision is now accepted and ready to land.Jun 20 2019, 20:15
Closed by commit rABC1234e9d1cab7: Merge #12392: Fix ignoring tx data requests when fPauseSend is set on a peer (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJun 20 2019, 20:23
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC1234e9d1cab7: Merge #12392: Fix ignoring tx data requests when fPauseSend is set on a peer.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING1234e9d1cab7: Merge #12392: Fix ignoring tx data requests when fPauseSend is set on a peer.Sep 19 2019, 00:24

Revision Contents
Changeset List

PathSize
src/
4 lines

Diff 9552

View Options

src/net_processing.cpp

Loading...