Merge #13163: Make it clear which functions that are intended to be translation unit local (validation.cpp)
ClosedPublic
Actions

Authored by nakihito on Jul 2 2019, 01:24.

Details

Reviewers

jasonbcox
deadalnix
Fabien

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGd5a3ed098b32: Merge #13163: Make it clear which functions that are intended to be translation…
rABCd5a3ed098b32: Merge #13163: Make it clear which functions that are intended to be translation…

Summary

c3f34d06be Make it clear which functions that are intended to be translation unit local (practicalswift)

Pull request description:

Make it clear which functions that are intended to be translation unit local.

Do not share functions that are meant to be translation unit local with other translation units. Use internal linkage for those consistently.

Tree-SHA512: 05eebd233d5cfbf6116724eec3a99b465bf534ca220f2b6f5e56341a7da41387454d3cb6ceadd8ab6714a5df94069e4ad0dcab8801ccc7e8949be7199a19fb53

Partial Backport of Core PR13163 (validation.cpp)
https://github.com/bitcoin/bitcoin/pull/13163/

Part of breaking up D3293.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR13163-validation

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6613
Build 11273: Bitcoin ABC Buildbot (legacy)
Build 11272: arc lint + arc unit

Event Timeline

nakihito planned changes to this revision.Jul 2 2019, 01:24

nakihito created this revision.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6613: Diff 9897.Jul 2 2019, 01:31

nakihito requested review of this revision.Jul 2 2019, 01:31

nakihito retitled this revision from Merge #13163: Make it clear which functions that are intended to be translation unit local (validation) to Merge #13163: Make it clear which functions that are intended to be translation unit local (validation.cpp).

nakihito edited the summary of this revision. (Show Details)

Fabien accepted this revision.Jul 2 2019, 06:16

This revision is now accepted and ready to land.Jul 2 2019, 06:16

Closed by commit rABCd5a3ed098b32: Merge #13163: Make it clear which functions that are intended to be translation… (authored by nakihito). · Explain WhyJul 2 2019, 17:25

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABCd5a3ed098b32: Merge #13163: Make it clear which functions that are intended to be translation….

nakihito mentioned this in D3293: Merge #13163: Make it clear which functions that are intended to be translation unit local.Jul 2 2019, 23:49

Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGd5a3ed098b32: Merge #13163: Make it clear which functions that are intended to be translation….Sep 19 2019, 00:51