Page MenuHomePhabricator
Differential D3537

Revert "Workaround to Travis-CI Wine/Mingw build hanging occasionally"
ClosedPublic
Actions

Authored by markblundeberg on Jul 3 2019, 05:16.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGfc347d780f96: Revert "Workaround to Travis-CI Wine/Mingw build hanging occasionally"
rABCfc347d780f96: Revert "Workaround to Travis-CI Wine/Mingw build hanging occasionally"
Summary

This reverts D497. It doesn't provide any value since we don't do Travis
anymore, and the Makefile.test.include changes may provide some nuisances
down the road.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markblundeberg created this revision.Jul 3 2019, 05:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 3 2019, 05:16
teamcity added a comment.Jul 3 2019, 05:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 3 2019, 05:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6649: Diff 9950.Jul 3 2019, 05:25
CCulianu added a subscriber: CCulianu.Jul 3 2019, 09:26

My beautiful code is gone! :'(

Jk.. good riddance to Travis. :)

deadalnix accepted this revision.Jul 3 2019, 13:09

Please remove travis altogether if you are going that road.

This revision is now accepted and ready to land.Jul 3 2019, 13:09
markblundeberg added a comment.Jul 3 2019, 13:21
In D3537#83384, @deadalnix wrote:

Please remove travis altogether if you are going that road.

travis.yml is gone already... not sure what else there is?

Closed by commit rABCfc347d780f96: Revert "Workaround to Travis-CI Wine/Mingw build hanging occasionally" (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJul 3 2019, 14:46
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABCfc347d780f96: Revert "Workaround to Travis-CI Wine/Mingw build hanging occasionally".
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGfc347d780f96: Revert "Workaround to Travis-CI Wine/Mingw build hanging occasionally".Sep 19 2019, 00:53

Revision Contents
Changeset List

Diff 9954

View Options

src/Makefile.test.include

Loading...
View Options

src/test/test-bitcoin-driver

Loading...
View Options

src/test/test_bitcoin.cpp

Loading...