Page MenuHomePhabricator
Feed Advanced Search

Jun 13 2017

Herald added 1 blocking reviewer(s) for D195: Format guiutil.h and guiutil.cpp: Restricted Project.
Jun 13 2017, 21:42
freetrader updated the diff for D193: Format chainparamsbase.{h,cpp}.

Do some manual adjustment to a suboptimal comment reformat

Jun 13 2017, 21:21
Herald added 1 blocking reviewer(s) for D193: Format chainparamsbase.{h,cpp}: Restricted Project.
Jun 13 2017, 21:19
Herald added 1 blocking reviewer(s) for D191: Add no-limits testnet (NOL) support to Bitcoin-ABC: Restricted Project.
Jun 13 2017, 19:54
freetrader added inline comments to D184: Fix abc-cmdline, part 1 (enable out-of-tree running).
Jun 13 2017, 17:43
freetrader accepted D183: Implement sigops checks in abc-p2p-fullblocktest.py.
Jun 13 2017, 12:07
freetrader accepted D182: Allow for messages to be up to 32MB.

I opened T33 for the 17MB issue I found while pushing above what this test does.

Jun 13 2017, 10:44
freetrader added inline comments to D182: Allow for messages to be up to 32MB.
Jun 13 2017, 10:23
freetrader added a comment to D182: Allow for messages to be up to 32MB.

It worked for me up to 16MB but not 17.

Jun 13 2017, 10:21
freetrader added inline comments to D183: Implement sigops checks in abc-p2p-fullblocktest.py.
Jun 13 2017, 01:31
freetrader added inline comments to D182: Allow for messages to be up to 32MB.
Jun 13 2017, 01:18
freetrader added a comment to D182: Allow for messages to be up to 32MB.

I would be hesitant to set the message limit to 32 MB if we are only testing up to 16MB block size. If we were able to successfully test up to 32M blocks I would be fine with setting the MAX_PROTOCOL_MESSAGE_LENGTH to 32MB. My view is we should increase it as we eliminate the obstacles and test it successfully at higher sizes.

Jun 13 2017, 01:10
freetrader requested changes to D183: Implement sigops checks in abc-p2p-fullblocktest.py.
Jun 13 2017, 01:07
freetrader added a comment to D183: Implement sigops checks in abc-p2p-fullblocktest.py.

I have tested this and it passed as it stands.
Refer my comments in D182 regarding the block size limit testing.

Jun 13 2017, 01:06
freetrader accepted D181: Various formating nits in net.cpp.
Jun 13 2017, 00:35
freetrader added a comment to D184: Fix abc-cmdline, part 1 (enable out-of-tree running).
NOTE: it is not an oversight that this diff does not re-enable abc-cmdline.py in the rpc-tests.py wrapper. This must wait until part 2 of this series has been implemented.
Jun 13 2017, 00:11
Herald added 1 blocking reviewer(s) for D184: Fix abc-cmdline, part 1 (enable out-of-tree running): Restricted Project.
Jun 13 2017, 00:00

Jun 12 2017

freetrader committed rABC0fa077894d2b: Resolve merge conflict introduced while trying to land D173 (authored by freetrader).
Resolve merge conflict introduced while trying to land D173
Jun 12 2017, 18:56
freetrader closed D180: Resolve merge conflict introduced while trying to land D173 by committing rABC0fa077894d2b: Resolve merge conflict introduced while trying to land D173.
Jun 12 2017, 18:56
Herald added 1 blocking reviewer(s) for D180: Resolve merge conflict introduced while trying to land D173: Restricted Project.
Jun 12 2017, 18:53
freetrader committed rABC434fe9f46253: Add simple big block test (authored by freetrader).
Add simple big block test
Jun 12 2017, 18:29
freetrader closed D173: Add simple big block test by committing rABC434fe9f46253: Add simple big block test.
Jun 12 2017, 18:29
freetrader added inline comments to D173: Add simple big block test.
Jun 12 2017, 17:55
freetrader added a comment to D173: Add simple big block test.

If you run this test with --nocleanup , it will leave behind a /tmp/test* folder (telling you the name).

Jun 12 2017, 13:49
freetrader committed rABC9b94bca3fac8: Rename to '-excessiveblocksize' in abc-cmdline test (authored by freetrader).
Rename to '-excessiveblocksize' in abc-cmdline test
Jun 12 2017, 10:35
freetrader committed rABC03e37ba9a5ba: Separate the test plan from the requirements specification (authored by freetrader).
Separate the test plan from the requirements specification
Jun 12 2017, 08:58
freetrader committed rABC6d951075193a: Temporarily disable abc-cmdline.py test (authored by freetrader).
Temporarily disable abc-cmdline.py test
Jun 12 2017, 08:53

Jun 11 2017

freetrader added inline comments to D173: Add simple big block test.
Jun 11 2017, 22:53
freetrader committed rABCd5f1b85c7f9a: Add command line option -excessiveblocksize (authored by freetrader).
Add command line option -excessiveblocksize
Jun 11 2017, 22:46
freetrader updated the diff for D173: Add simple big block test.

Rename blocksizeacceptlimit option to excessiveblocksize

Jun 11 2017, 22:22
freetrader planned changes to D173: Add simple big block test.

Planning to change the command line option name to 'excessiveblocksize' as per D171 review comments.

Jun 11 2017, 22:15
Herald added 1 blocking reviewer(s) for D173: Add simple big block test: Restricted Project.
Jun 11 2017, 21:46
freetrader committed rABCb316465a295c: Temporarily disable reading of consensus.h from Python test framework (authored by freetrader).
Temporarily disable reading of consensus.h from Python test framework
Jun 11 2017, 16:31
freetrader committed rABCa35dab5c38d9: Fix syntax error in test-framework/cdefs.py (authored by freetrader).
Fix syntax error in test-framework/cdefs.py
Jun 11 2017, 16:05
freetrader committed rABCa03e03b043eb: Rename to LEGACY_MAX_BLOCK_SIZE, use cdefs (authored by freetrader).
Rename to LEGACY_MAX_BLOCK_SIZE, use cdefs
Jun 11 2017, 15:49
freetrader committed rABC6acae68de288: Extract important parameters from sources outside the test framework (authored by freetrader).
Extract important parameters from sources outside the test framework
Jun 11 2017, 15:44

Jun 10 2017

freetrader committed rABC12e9808d75c4: Rename and move test framework constant to MAX_BLOCK_SIGOPS_PER_MB (authored by freetrader).
Rename and move test framework constant to MAX_BLOCK_SIGOPS_PER_MB
Jun 10 2017, 23:15
freetrader committed rABCa46f1959bd99: Rename all 1MB limits in qa tests to LEGACY_MAX_BLOCK_BASE_SIZE (authored by freetrader).
Rename all 1MB limits in qa tests to LEGACY_MAX_BLOCK_BASE_SIZE
Jun 10 2017, 23:14
freetrader committed rABCda9b8a587b7d: Fix blockcheck_tests initial conditions (set max block size to default) (authored by freetrader).
Fix blockcheck_tests initial conditions (set max block size to default)
Jun 10 2017, 10:38

Jun 9 2017

freetrader committed rABC70ae490d89bc: Use ONE_MEGABYTE where historic limit is needed, extend some tests (authored by freetrader).
Use ONE_MEGABYTE where historic limit is needed, extend some tests
Jun 9 2017, 16:37
freetrader committed rABC5ebe12993612: Import draft BUIP-HF spec and replay-protected-sighash spec (authored by freetrader).
Import draft BUIP-HF spec and replay-protected-sighash spec
Jun 9 2017, 10:21
freetrader committed rABCa6d1158f453f: Change useragent to 'Bitcoin ABC' (authored by freetrader).
Change useragent to 'Bitcoin ABC'
Jun 9 2017, 10:20
freetrader committed rABC08a05b05d43d: Format clientversion.h and clientversion.cpp (authored by freetrader).
Format clientversion.h and clientversion.cpp
Jun 9 2017, 10:17

Jun 5 2017

freetrader committed rABCb60f16622717: Disable check-doc.py test in Travis (authored by freetrader).
Disable check-doc.py test in Travis
Jun 5 2017, 19:10

May 30 2017

freetrader committed rABC80024ed75c1b: Introduce ABC RPC functionality (authored by deadalnix).
Introduce ABC RPC functionality
May 30 2017, 10:25