rebase

declare MAX_COINBASE_SCRIPTSIG_SIZE static

mv MAX_COINBASE_SCRIPTSIG_SIZE to miner.cpp
remove decaration of getExcessiveBlockSizeSig from miner.h
make getExcessiveBlockSizeSig static
Expand the coinbase message test

change return type of getExcessiveBlockSizeSig
check for coinbase message only agter IncrementExtraNonce has been called

Don't overwrite COINBASE_FLAG
avoid to introduce a new global state, read EB every time we need it
remove a left over from validation.cpp

Need to polish some left over and address @deadalnix feedback

Add a test for EB = 0 to test/net_tests.cpp

getSubVersionEB works with EB<1MB
getSubVersionEB will rounded down EB in MB keeping a precision of one decimal digit
Document that getSubVersionEB behavior for EB < 1MB is still not standardized
Add tests for EB < 1MB to test/net_tests.cpp
Add tests for EB >> 1MB to test/net_tests.cpp
Adapt test/net_tests.cpp to the new semantic (second item of this list)

Add const Config &config to PushNodeVersion
Use GetConfig() in InitializeNode and pass it down from there.
Did not add to .0 to integer defined EB to keep compatibility with BU and Classic

Remove float arithmetic from getSubVersionEB()
Remove clientversion.h from rpc/abc.c

remove net.h from rpc/abc.cpp
remove the float hack to get the the EB value in MB, in the process remove also the inclusion of cfenv
getSubVersionEB still public because we are going to use it also for the coinbase txn and because dunno how to declare as private a function that does not belong to a class

Pass config to userAgent()
Remove useless header inclusion from ab.cpp and util.h
TODO: find a better place for userAgent() (?), fix getSubVerEB() arithmetic properly

Fix a trailing comment

Formatting of src/test/net_tests.cpp and src/qt/clientmodel.cpp

Fix comment in functional tests
Remove global var strSubVersion, use userAgent() instead to get an up-to-date user agent string
Add unit test for getSubVersionEB

In D222#3447, @freetrader wrote:

Could you please add a unit test for getSubVersionEB() .

In D222#3449, @deadalnix wrote:

Not sure why you are using parentheses when other clients are using `/` ?