Don't use pair
Feed Advanced Search
Jan 15 2018
Jan 15 2018
Jan 7 2018
Jan 7 2018
Dec 19 2017
Dec 19 2017
Dec 15 2017
Dec 15 2017
Introduce bitcoinUriScheme
dagurval updated the diff for D583: Support parsing cashaddr from command line.
Added a warning if two (or more) addresses from incompatible networks are parsed.
dagurval updated the diff for D583: Support parsing cashaddr from command line.
Moved network selection to bitcoin.cpp
dagurval requested review of D801: Use user configured encoding in receive request.
dagurval updated the diff for D797: Introduce bitcoinUriScheme.
removed dummy object, cfg -> config
Dec 14 2017
Dec 14 2017
dagurval added inline comments to D797: Introduce bitcoinUriScheme.
Dec 13 2017
Dec 13 2017
dagurval committed rABCe52fa6d72dd2: Add missing include in receiverequestdialog (authored by dagurval).
Add missing include in receiverequestdialog
dagurval closed T130: Revision D802 broke builds as Resolved by committing rABCe52fa6d72dd2: Add missing include in receiverequestdialog.
dagurval added a revision to T130: Revision D802 broke builds: D806: Add missing include in receiverequestdialog.
Modify QR code to fit cashaddr
dagurval added inline comments to D797: Introduce bitcoinUriScheme.
dagurval requested review of D797: Introduce bitcoinUriScheme.
dagurval added a reviewer for D801: Use user configured encoding in receive request: Restricted Project.
dagurval added inline comments to D797: Introduce bitcoinUriScheme.
Dec 12 2017
Dec 12 2017
dagurval updated the test plan for D583: Support parsing cashaddr from command line.
dagurval updated the diff for D583: Support parsing cashaddr from command line.
Dec 8 2017
Dec 8 2017
dagurval committed rABCa492b58df9f5: Accept multiple schemes in parseBitcoinURI (authored by dagurval).
Accept multiple schemes in parseBitcoinURI
dagurval added a comment to D761: Encode cashaddr size properly in version bit..
Looks good. You need a test to ensure PackCashAddrContent throws when it should.
dagurval committed rABC68daecd4edba: Encode destination using Base58 in WalletDB (authored by dagurval).
Encode destination using Base58 in WalletDB
Dec 7 2017
Dec 7 2017
dagurval updated the diff for D745: Encode destination using Base58 in WalletDB.
back to first proposal, with some nits
dagurval updated the diff for D745: Encode destination using Base58 in WalletDB.
No code repitition
dagurval added inline comments to D745: Encode destination using Base58 in WalletDB.
Dec 6 2017
Dec 6 2017
Support cashaddr in parse/format URI
Make Config more available in Qt
dagurval added a comment to D745: Encode destination using Base58 in WalletDB.
I introduced WriteDstPair and EraseDstPair to avoid code repetition between WritePurpose and WriteName. Unfortunately WriteDestData creates its key in different way and cannot be generalized the same way.
dagurval updated the diff for D745: Encode destination using Base58 in WalletDB.
remove unrelated change
dagurval updated the diff for D745: Encode destination using Base58 in WalletDB.
Add Write/EraseDstPair
Dec 5 2017
Dec 5 2017
dagurval added a comment to D583: Support parsing cashaddr from command line.
Test plan is not adequate. Manual is not something I can reproduce if I wanted/needed to.
Dec 3 2017
Dec 3 2017
dagurval added inline comments to D745: Encode destination using Base58 in WalletDB.
Dec 2 2017
Dec 2 2017
Dec 1 2017
Dec 1 2017
dagurval committed rABC11a84a2d0ece: Support cashaddr in Qt input validation (authored by dagurval).
Support cashaddr in Qt input validation
Nov 27 2017
Nov 27 2017
dagurval updated the diff for D583: Support parsing cashaddr from command line.
fix rebase issue in tests
dagurval updated the test plan for D583: Support parsing cashaddr from command line.
dagurval updated the diff for D583: Support parsing cashaddr from command line.
Rebased on top of D709
dagurval added a comment to D709: Support cashaddr in parse/format URI.
This should be able to detect which kind of addresses we are looking at rather than blindly trusting the config.
dagurval updated the diff for D709: Support cashaddr in parse/format URI.
Check if URI is cashaddr encoded instead of relying on user config
dagurval requested review of D708: Make Config more available in Qt.
dagurval updated the diff for D552: Support cashaddr in Qt input validation.
GetConfig()
Nov 26 2017
Nov 26 2017
dagurval added a comment to D712: Move mapBlockIndex to chain.h.
Did you forget to move the definition of mapBlockIndex from validation.cpp, or is this on purpose? You only moved the declaration in the header file. May also want to add a comment about it being protected by cs_main
Nov 23 2017
Nov 23 2017
Use bch prefix in cashaddr
dagurval added inline comments to D708: Make Config more available in Qt.
dagurval updated the summary of D709: Support cashaddr in parse/format URI.
Nov 16 2017
Nov 16 2017
dagurval added a comment to D706: Use GetConfig instead of GlobalConfig.
You want me to un-land the bogus patch and fix it?
dagurval added a comment to D552: Support cashaddr in Qt input validation.
Currently requires full address, including prefix.
dagurval updated the summary of D552: Support cashaddr in Qt input validation.
dagurval updated the diff for D552: Support cashaddr in Qt input validation.
rebased
Make DummyAddress support cashaddr
dagurval committed rABC4a8255d86124: Add flag to enable dst encoding using cashaddr (authored by dagurval).
Add flag to enable dst encoding using cashaddr
Nov 15 2017
Nov 15 2017
after rebase, arcanist made a new diff instead of updating this one D695
Herald added a reviewer for D695: Add flag to enable dst encoding using cashaddr: Restricted Project.
Added DummyConfig
dagurval updated the test plan for D553: Make DummyAddress support cashaddr.
dagurval updated the diff for D553: Make DummyAddress support cashaddr.
Type of address generated depends on config now. Added test.
Nov 14 2017
Nov 14 2017
dagurval updated the diff for D683: Add flag to enable dst encoding using cashaddr.
Move -usecashaddr outside of any group.
Added a comment.
Moved help string.
dagurval added inline comments to D683: Add flag to enable dst encoding using cashaddr.
Herald added a reviewer for D683: Add flag to enable dst encoding using cashaddr: Restricted Project.
dagurval committed rABC1a3a9d7cbe9e: Enable decoding and optional encoding of cashaddr (authored by dagurval).
Enable decoding and optional encoding of cashaddr
dagurval updated the summary of D660: Enable decoding and optional encoding of cashaddr.
dagurval updated the diff for D660: Enable decoding and optional encoding of cashaddr.
remove -use-cashaddr flag
dagurval committed rABCeb096c1f0a11: Implement {Encode,Decode}Destination without CBitcoinAddress (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Implement {Encode,Decode}Destination without CBitcoinAddress