remove faq data
Feed Advanced Search
Jun 19 2023
Jun 19 2023
johnkuney updated the diff for D14084: [e.cash] Add wallets page.
add wallets to nav
johnkuney requested review of D14084: [e.cash] Add wallets page.
johnkuney committed rABC7c9f38a1689c: [e.cash] Add tile section to homepage (authored by johnkuney).
[e.cash] Add tile section to homepage
teamcity awarded D14035: [e.cash] Add tile section to homepage a Love token.
johnkuney added a comment to D14035: [e.cash] Add tile section to homepage.
@bot preview-e.cash
teamcity awarded D14035: [e.cash] Add tile section to homepage a Like token.
johnkuney updated the diff for D14035: [e.cash] Add tile section to homepage.
improve hover background, add comments for core tech blocks
teamcity awarded D14035: [e.cash] Add tile section to homepage a Mountain of Wealth token.
johnkuney updated the diff for D14035: [e.cash] Add tile section to homepage.
add headers
johnkuney updated the diff for D14035: [e.cash] Add tile section to homepage.
add styled component
Jun 17 2023
Jun 17 2023
johnkuney committed rABC78853044d9dd: [e.cash] Fetch exchanges and services and render on get ecash page (authored by johnkuney).
[e.cash] Fetch exchanges and services and render on get ecash page
Jun 16 2023
Jun 16 2023
johnkuney added inline comments to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
[e.cash] Center H2 image
Jun 15 2023
Jun 15 2023
teamcity awarded D14070: [e.cash] Center H2 image a Haypence token.
johnkuney planned changes to D14035: [e.cash] Add tile section to homepage.
johnkuney updated the diff for D14035: [e.cash] Add tile section to homepage.
rebase master
johnkuney updated the diff for D14035: [e.cash] Add tile section to homepage.
remove h3 change
johnkuney updated the diff for D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
remove line break
johnkuney requested review of D14070: [e.cash] Center H2 image.
teamcity awarded D14025: [e.cash] Fetch exchanges and services and render on get ecash page a Mountain of Wealth token.
johnkuney added inline comments to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
johnkuney updated the summary of D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
johnkuney updated the diff for D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
remove var, style tweak
johnkuney planned changes to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
johnkuney updated the diff for D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
rebase
johnkuney updated the diff for D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
remove unrelated changes
johnkuney committed rABC4f973e6a97c2: [e.cash] Add functions to fetch exchanges and score and sort them (authored by johnkuney).
[e.cash] Add functions to fetch exchanges and score and sort them
johnkuney committed rABC673fe77da251: [e.cash] Fix subpage hero display issue (authored by johnkuney).
[e.cash] Fix subpage hero display issue
johnkuney updated the diff for D14056: [e.cash] Add functions to fetch exchanges and score and sort them.
add another test to makedivisiblebythree to check > 3
teamcity awarded D14061: [e.cash] Fix subpage hero display issue a Haypence token.
johnkuney added a comment to D14061: [e.cash] Fix subpage hero display issue.
okay clarified
johnkuney updated the summary of D14061: [e.cash] Fix subpage hero display issue.
Jun 14 2023
Jun 14 2023
johnkuney requested review of D14061: [e.cash] Fix subpage hero display issue.
johnkuney committed rABC8ae52ab7e0a2: [e.cash] Add id param and better comments to H3 component (authored by johnkuney).
[e.cash] Add id param and better comments to H3 component
johnkuney updated the diff for D14059: [e.cash] Add id param and better comments to H3 component.
remove check
johnkuney updated the summary of D14059: [e.cash] Add id param and better comments to H3 component.
johnkuney updated the diff for D14059: [e.cash] Add id param and better comments to H3 component.
add id check and test
johnkuney added a comment to D14059: [e.cash] Add id param and better comments to H3 component.
Nothing actually if its undefined, but it will put a blank id if an empty string gets passed which is invalid, so adding back in that check
johnkuney updated the diff for D14059: [e.cash] Add id param and better comments to H3 component.
add check for id
johnkuney updated the diff for D14056: [e.cash] Add functions to fetch exchanges and score and sort them.
add comment space
johnkuney updated the test plan for D14059: [e.cash] Add id param and better comments to H3 component.
johnkuney requested review of D14059: [e.cash] Add id param and better comments to H3 component.
johnkuney updated the diff for D14056: [e.cash] Add functions to fetch exchanges and score and sort them.
add more test
johnkuney updated the diff for D14056: [e.cash] Add functions to fetch exchanges and score and sort them.
break out the sort function from the score function
johnkuney updated the diff for D14056: [e.cash] Add functions to fetch exchanges and score and sort them.
format comment lengths
johnkuney requested review of D14056: [e.cash] Add functions to fetch exchanges and score and sort them.
johnkuney planned changes to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
johnkuney updated the diff for D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
format comments
teamcity awarded D14035: [e.cash] Add tile section to homepage a Doubloon token.
Jun 13 2023
Jun 13 2023
johnkuney updated the diff for D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
add comment and consolidate scoring test
teamcity awarded D14025: [e.cash] Fetch exchanges and services and render on get ecash page a Doubloon token.
johnkuney updated the diff for D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
improve error handling
johnkuney planned changes to D14035: [e.cash] Add tile section to homepage.
johnkuney updated the diff for D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
add test for empty array or object response
johnkuney updated the diff for D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
move the scorecard api call outside of getstatic props and make a test for it
johnkuney updated the diff for D14035: [e.cash] Add tile section to homepage.
remove captializations from html and add css rule
johnkuney updated the diff for D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
improve notes, still need to write test for getstaticprops
Jun 12 2023
Jun 12 2023
johnkuney added inline comments to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
johnkuney updated the diff for D14035: [e.cash] Add tile section to homepage.
remove image imports, css uppercase
johnkuney added a comment to D14035: [e.cash] Add tile section to homepage.
links load with title under nav bar, would be nice if they loaded with the title just below nav bar. Maybe further down or something like "centered in screen" , so that the animation is not cut off
what we have now:
would be nice:
johnkuney added a comment to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
Good suggestions in general, added.
johnkuney updated the diff for D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
improve testing and comments, rename and move utils function
teamcity awarded D14035: [e.cash] Add tile section to homepage a Piece of Eight token.
Jun 9 2023
Jun 9 2023
johnkuney updated the diff for D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
add untracked files
johnkuney updated the diff for D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
add some test and put scripts in same file
johnkuney updated the diff for D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
add scoring notes, handle no id passed to h3
johnkuney added a comment to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
Okay. So, something like
utils/pageUtils.js , with both functions in it
utils/__tests__/pageUtils.test.js, with unit tests
johnkuney added inline comments to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
teamcity awarded D14035: [e.cash] Add tile section to homepage a Haypence token.
johnkuney requested review of D14035: [e.cash] Add tile section to homepage.
johnkuney added a comment to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
weird that getScores and makeDivisibleByThree have their own files? Match the pattern from your earlier diff.
- Put component-specific methods into a single file in the folder for that component
- Add unit tests for these functions
teamcity awarded D14025: [e.cash] Fetch exchanges and services and render on get ecash page a Piece of Eight token.
johnkuney added a comment to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
The links don't jump to the title of the section but to the table on my browser. It looks like the anchor is misplaced
johnkuney updated the diff for D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
change api var name, fix anchor links, homogenize functoin syntax
johnkuney added inline comments to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
teamcity awarded D14025: [e.cash] Fetch exchanges and services and render on get ecash page a Haypence token.
johnkuney requested review of D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
Jun 7 2023
Jun 7 2023
[e.cash] Add get ecash page
teamcity awarded D14004: [e.cash] Add get ecash page a Haypence token.
johnkuney requested review of D14004: [e.cash] Add get ecash page.
May 25 2023
May 25 2023
[e.cash] Add faq page
teamcity awarded D13938: [e.cash] Add faq page a Piece of Eight token.
[e.cash] H2 style tweak