Page MenuHomePhabricator
Feed Advanced Search

Feb 21 2024

Fabien accepted D15503: guix: switch from guix environment to guix shell.
Feb 21 2024, 16:41
Fabien closed D15502: [ci] Also remove .walletlock files from the artifacts.
Feb 21 2024, 16:40
Fabien committed rABC4265aa3438bf: [ci] Also remove .walletlock files from the artifacts (authored by Fabien).
[ci] Also remove .walletlock files from the artifacts
Feb 21 2024, 16:40
Fabien requested review of D15507: [cmake] Fetch Corrosion.
Feb 21 2024, 16:40
Fabien requested review of D15506: [chronik] Bump corrosion to latest version.
Feb 21 2024, 16:36
Fabien accepted D15500: [chronik-client] Add support for getting tx history and utxos by address.
Feb 21 2024, 08:37
Fabien requested review of D15502: [ci] Also remove .walletlock files from the artifacts.
Feb 21 2024, 08:35

Feb 20 2024

Fabien closed D15496: [packaging] Enforce python >= 3.9 for the debian/ubuntu packages.
Feb 20 2024, 16:27
Fabien committed rABC931e7acbe615: [packaging] Enforce python >= 3.9 for the debian/ubuntu packages (authored by Fabien).
[packaging] Enforce python >= 3.9 for the debian/ubuntu packages
Feb 20 2024, 16:27
Fabien accepted D15412: [chronik-client] Support websockets in ChronikClientNode.
Feb 20 2024, 14:11
Fabien requested review of D15496: [packaging] Enforce python >= 3.9 for the debian/ubuntu packages.
Feb 20 2024, 14:07
Fabien closed D15495: Bump version to 0.28.10.
Feb 20 2024, 08:30
Fabien committed rABC5a8f6281177f: Bump version to 0.28.10 (authored by Fabien).
Bump version to 0.28.10
Feb 20 2024, 08:30
Fabien requested review of D15495: Bump version to 0.28.10.
Feb 20 2024, 08:19
Fabien accepted D15490: guix: update time-machine.
Feb 20 2024, 08:14
Fabien requested changes to D15412: [chronik-client] Support websockets in ChronikClientNode.

one last thing, otherwise lgtm

Feb 20 2024, 08:11
Fabien closed D15489: [CI] Remove .lock files if some are persistent after the build..
Feb 20 2024, 07:18
Fabien committed rABC8e8c0d34e944: [CI] Remove .lock files if some are persistent after the build. (authored by Fabien).
[CI] Remove .lock files if some are persistent after the build.
Feb 20 2024, 07:18

Feb 19 2024

Fabien requested review of D15489: [CI] Remove .lock files if some are persistent after the build..
Feb 19 2024, 13:40
Fabien accepted D15488: guix: consolidate glibc & gcc packages.
Feb 19 2024, 12:57
Fabien accepted D15486: [Chronik] Upgrade to axum 0.7.
Feb 19 2024, 12:20
Fabien accepted D15485: guix: pre time-machine bump changes (Windows).
Feb 19 2024, 12:01
Fabien requested changes to D15486: [Chronik] Upgrade to axum 0.7.

this impacts some tests

Feb 19 2024, 11:53
Fabien added inline comments to D15412: [chronik-client] Support websockets in ChronikClientNode.
Feb 19 2024, 09:54
Fabien accepted D15481: [chronik-client] Enforce header with eslint plugin.
Feb 19 2024, 09:11
Fabien requested changes to D15412: [chronik-client] Support websockets in ChronikClientNode.
Feb 19 2024, 09:06

Feb 18 2024

Fabien requested changes to D15477: [lint] fix a typehint to keep supporting python 3.8 for linters.

devs will not be able to build anyway as the build system requires 3.9

Feb 18 2024, 11:05

Feb 17 2024

Fabien accepted D15457: [guix] Build for arm-linux-gnueabihf and aarch64-linux-gnu.
Feb 17 2024, 20:40
Fabien accepted D15472: [Chronik] Fix WebSocket emitting Error messages.
Feb 17 2024, 16:48

Feb 16 2024

Fabien closed D15470: [guix] Don't look for dependencies when building the source package.
Feb 16 2024, 19:14
Fabien committed rABC25f848247359: [guix] Don't look for dependencies when building the source package (authored by Fabien).
[guix] Don't look for dependencies when building the source package
Feb 16 2024, 19:14
Fabien closed D15469: [depends] Properly remove the native protobuf libraries.
Feb 16 2024, 19:13
Fabien committed rABCcc614b17951b: [depends] Properly remove the native protobuf libraries (authored by Fabien).
[depends] Properly remove the native protobuf libraries
Feb 16 2024, 19:13
Fabien closed D15471: [cmake] Enable noexecstack if hardening is set.
Feb 16 2024, 19:13
Fabien committed rABC61bc19750fa5: [cmake] Enable noexecstack if hardening is set (authored by Fabien).
[cmake] Enable noexecstack if hardening is set
Feb 16 2024, 19:13
Fabien requested review of D15471: [cmake] Enable noexecstack if hardening is set.
Feb 16 2024, 17:17
Fabien accepted D15458: lint: add new python script to check file names and permissions.
Feb 16 2024, 16:33
Fabien requested review of D15470: [guix] Don't look for dependencies when building the source package.
Feb 16 2024, 15:26
Fabien retitled D15469: [depends] Properly remove the native protobuf libraries from [depends] Properly remove the native libraries to [depends] Properly remove the native protobuf libraries.
Feb 16 2024, 15:20
Fabien closed D15459: [guix] Build for windows.
Feb 16 2024, 15:17
Fabien committed rABC6649b0d3da90: [guix] Build for windows (authored by Fabien).
[guix] Build for windows
Feb 16 2024, 15:17
Fabien requested review of D15469: [depends] Properly remove the native protobuf libraries.
Feb 16 2024, 15:14
Fabien updated the diff for D15459: [guix] Build for windows.

Don't use undefined variables

Feb 16 2024, 10:48
Fabien closed D15461: [chronik] Fix websocket subscription in tests.
Feb 16 2024, 10:27
Fabien committed rABC019650ee386a: [chronik] Fix websocket subscription in tests (authored by Fabien).
[chronik] Fix websocket subscription in tests
Feb 16 2024, 10:27
Fabien requested changes to D15458: lint: add new python script to check file names and permissions.

electrum/contrib/build-linux/appimage/scripts/common.sh is certainly not expected to be run directly and can remain non executable

Feb 16 2024, 10:19
Fabien updated the diff for D15461: [chronik] Fix websocket subscription in tests.

Feedback

Feb 16 2024, 10:06
Fabien updated the diff for D15461: [chronik] Fix websocket subscription in tests.

Rebase, fix for new linter, update token id print format after D15463.

Feb 16 2024, 09:48
Fabien accepted D15463: [Chronik] Improve logs in ws.rs.
Feb 16 2024, 09:26
Fabien accepted D15462: [Chronik] Add `Display` impl for `ScriptVariant`.
Feb 16 2024, 09:15

Feb 15 2024

teamcity awarded D15461: [chronik] Fix websocket subscription in tests a Piece of Eight token.
Feb 15 2024, 21:53
Fabien added a comment to D15461: [chronik] Fix websocket subscription in tests.

@bot build-linux-arm build-linux-aarch64

Feb 15 2024, 21:53
Fabien updated the diff for D15461: [chronik] Fix websocket subscription in tests.

Don't break encapsulation

Feb 15 2024, 21:53
teamcity awarded D15461: [chronik] Fix websocket subscription in tests a Haypence token.
Feb 15 2024, 21:07
Fabien added a comment to D15461: [chronik] Fix websocket subscription in tests.

@bot build-linux-arm build-linux-aarch64

Feb 15 2024, 21:07
Fabien requested review of D15461: [chronik] Fix websocket subscription in tests.
Feb 15 2024, 21:06
Fabien requested review of D15459: [guix] Build for windows.
Feb 15 2024, 18:53
Fabien accepted D15448: [lint] remove executable flag and shebang on non-script python files.

linter looks OK, I trust the remaining files are correct

Feb 15 2024, 13:49
Fabien closed D15454: [chronik] Bump timeout for chronik_ws_ordering.
Feb 15 2024, 13:14
Fabien committed rABC7dfd28115c37: [chronik] Bump timeout for chronik_ws_ordering (authored by Fabien).
[chronik] Bump timeout for chronik_ws_ordering
Feb 15 2024, 13:14
Fabien closed D15455: [CI] Build the chronik plugins for the automated timing update.
Feb 15 2024, 13:14
Fabien committed rABC5f2f3e41491e: [CI] Build the chronik plugins for the automated timing update (authored by Fabien).
[CI] Build the chronik plugins for the automated timing update
Feb 15 2024, 13:14
Fabien closed D15453: [chronik] Build the experimental release for all Linux platforms.
Feb 15 2024, 13:12
Fabien committed rABC23460f3eafb1: [chronik] Build the experimental release for all Linux platforms (authored by Fabien).
[chronik] Build the experimental release for all Linux platforms
Feb 15 2024, 13:12
Fabien requested review of D15455: [CI] Build the chronik plugins for the automated timing update.
Feb 15 2024, 11:07
Fabien requested review of D15454: [chronik] Bump timeout for chronik_ws_ordering.
Feb 15 2024, 11:03
teamcity awarded D15453: [chronik] Build the experimental release for all Linux platforms a Haypence token.
Feb 15 2024, 10:42
Fabien added a comment to D15453: [chronik] Build the experimental release for all Linux platforms.

@bot gitian-linux

Feb 15 2024, 10:42
Fabien updated the diff for D15453: [chronik] Build the experimental release for all Linux platforms.

Remove extra dependency

Feb 15 2024, 10:42
Fabien planned changes to D15453: [chronik] Build the experimental release for all Linux platforms.
Feb 15 2024, 10:36
Fabien requested review of D15453: [chronik] Build the experimental release for all Linux platforms.
Feb 15 2024, 10:36
Fabien accepted D15452: [Chronik] Emit WS messages in a more deterministic order.
Feb 15 2024, 07:17
Fabien accepted D15444: [chronik-client] Support for broadcast-tx and broadcast-txs endpoints.
Feb 15 2024, 07:04

Feb 14 2024

Fabien accepted D15435: [Cashtab] Improve AppIntegrations unit tests.
Feb 14 2024, 17:03
Fabien requested changes to D15444: [chronik-client] Support for broadcast-tx and broadcast-txs endpoints.
Feb 14 2024, 15:03
Fabien accepted D15446: [lint] relax the PythonShebangLinter and apply it on electrum.
Feb 14 2024, 15:01
Fabien requested changes to D15446: [lint] relax the PythonShebangLinter and apply it on electrum.
Feb 14 2024, 13:34
Fabien accepted D15449: [electrum] make the python interpreter explicit when running setup.py.
Feb 14 2024, 13:23
Fabien closed D15445: Revert "[guix] disable BIP70 for the guix build".
Feb 14 2024, 13:22
Fabien committed rABC061165d856b3: Revert "[guix] disable BIP70 for the guix build" (authored by Fabien).
Revert "[guix] disable BIP70 for the guix build"
Feb 14 2024, 13:22
Fabien added a reverting change for rABCa07b9766215b: [guix] disable BIP70 for the guix build: rABC061165d856b3: Revert "[guix] disable BIP70 for the guix build".
Feb 14 2024, 13:22
Fabien added a reverting change for D14855: [guix] disable BIP70 for the guix build: rABC061165d856b3: Revert "[guix] disable BIP70 for the guix build".
Feb 14 2024, 13:22
Fabien requested review of D15445: Revert "[guix] disable BIP70 for the guix build".
Feb 14 2024, 09:13
Fabien added a reverting change for rABCa07b9766215b: [guix] disable BIP70 for the guix build: D15445: Revert "[guix] disable BIP70 for the guix build".
Feb 14 2024, 09:13
Fabien added a reverting change for D14855: [guix] disable BIP70 for the guix build: D15445: Revert "[guix] disable BIP70 for the guix build".
Feb 14 2024, 09:13
Fabien requested changes to D15444: [chronik-client] Support for broadcast-tx and broadcast-txs endpoints.
Feb 14 2024, 08:46
Fabien requested changes to D15412: [chronik-client] Support websockets in ChronikClientNode.
Feb 14 2024, 08:27
Fabien accepted D15434: [ci deps] Bump node to 20.
Feb 14 2024, 08:25
Fabien closed D15440: [depends] Don't remove the include directory for native_protobuf.
Feb 14 2024, 08:23
Fabien committed rABC1fcd3b34f0c4: [depends] Don't remove the include directory for native_protobuf (authored by Fabien).
[depends] Don't remove the include directory for native_protobuf
Feb 14 2024, 08:23
Fabien closed D15441: [guix] Properly set the toolchain environment based on the CROSS_* environment variables.
Feb 14 2024, 08:23
Fabien committed rABCe069a58e5a6a: [guix] Properly set the toolchain environment based on the CROSS_* environment… (authored by Fabien).
[guix] Properly set the toolchain environment based on the CROSS_* environment…
Feb 14 2024, 08:23

Feb 13 2024

Fabien requested review of D15441: [guix] Properly set the toolchain environment based on the CROSS_* environment variables.
Feb 13 2024, 21:12
Fabien updated the test plan for D15440: [depends] Don't remove the include directory for native_protobuf.
Feb 13 2024, 20:22
Fabien requested review of D15440: [depends] Don't remove the include directory for native_protobuf.
Feb 13 2024, 20:21
Fabien added a reverting change for D14855: [guix] disable BIP70 for the guix build: D15440: [depends] Don't remove the include directory for native_protobuf.
Feb 13 2024, 20:21
Fabien accepted D15428: remove unneeded includes when building without BIP70.
Feb 13 2024, 20:10
Fabien accepted D15424: depends: Add file-based logging for individual packages.
Feb 13 2024, 20:08
Fabien requested changes to D15434: [ci deps] Bump node to 20.
Feb 13 2024, 20:01
Fabien accepted D15438: [Chronik] Add `-chroniktokenindex=0` to disable the token index.

The failure is unrelated, but I still need to figure out why the .lock file is not removed when a test fails while chronik is in use

Feb 13 2024, 16:35