Page MenuHomePhabricator
Feed Advanced Search

Aug 7 2024

Fabien requested review of D16598: Strip the windows installer files.
Aug 7 2024, 13:10

Aug 6 2024

Fabien closed D16594: Let UpdateTime take the adjusted time instead of getting it locally.
Aug 6 2024, 18:38
Fabien committed rABC7739a49171f6: Let UpdateTime take the adjusted time instead of getting it locally (authored by Fabien).
Let UpdateTime take the adjusted time instead of getting it locally
Aug 6 2024, 18:38
Fabien closed D16593: [avalanche] Add a method to return if the node has a finalized tip.
Aug 6 2024, 18:37
Fabien committed rABC6b08e3914095: [avalanche] Add a method to return if the node has a finalized tip (authored by Fabien).
[avalanche] Add a method to return if the node has a finalized tip
Aug 6 2024, 18:37
Fabien accepted D16595: Re-label link to mining page.
Aug 6 2024, 17:06
Fabien accepted D16560: [Chronik] Relax plugin height checks at startup.
Aug 6 2024, 14:40
Fabien requested review of D16594: Let UpdateTime take the adjusted time instead of getting it locally.
Aug 6 2024, 09:25
Fabien requested review of D16593: [avalanche] Add a method to return if the node has a finalized tip.
Aug 6 2024, 08:28
Fabien requested changes to D16588: [explorer and ecash-herald] Parse new miner anon minimalist.
Aug 6 2024, 06:44
Fabien accepted D16586: [explorer and ecash-herald] Parse new miner nodeStratum.
Aug 6 2024, 06:40
Fabien accepted D16585: [cashtab + ecash-herald + explorer] revert to previous chronik instance ordering.

Open review question -- mb we should have some apps default to 2, others to 1

With the failover proxy this should not make any difference, I'd rather improve this feature

Aug 6 2024, 06:39
Fabien accepted D16584: [chronik-client] Switch to next server if we cannot decode a chronik server error per chronik server error proto.
Aug 6 2024, 06:34

Aug 5 2024

Fabien accepted D16583: [herald] swap chronik server during reindex.
Aug 5 2024, 15:23
Fabien accepted D16582: [explorer] Temp switch to chronik2.
Aug 5 2024, 15:18
Fabien accepted D16581: [Cashtab] Temp switch chronik server order.
Aug 5 2024, 15:06
Fabien closed D16580: Add release notes for v0.29.10.
Aug 5 2024, 12:29
Fabien committed rABC038cfc307f9b: Add release notes for v0.29.10 (authored by Fabien).
Add release notes for v0.29.10
Aug 5 2024, 12:29
Fabien requested review of D16580: Add release notes for v0.29.10.
Aug 5 2024, 07:50
Fabien accepted D16579: [e.cash] Add MineMine to mining page.
Aug 5 2024, 07:36

Aug 4 2024

Fabien requested changes to D16560: [Chronik] Relax plugin height checks at startup.
Aug 4 2024, 08:19
Fabien closed D16575: Add a facility to create arith_uint256 from their double representation.
Aug 4 2024, 07:58
Fabien committed rABC45aa0fcc97f2: Add a facility to create arith_uint256 from their double representation (authored by Fabien).
Add a facility to create arith_uint256 from their double representation
Aug 4 2024, 07:58
Fabien accepted D16578: [token-server] Update chronik servers.
Aug 4 2024, 05:05

Aug 2 2024

Fabien updated the diff for D16575: Add a facility to create arith_uint256 from their double representation.

Add some constants in test

Aug 2 2024, 19:37
Fabien closed D16576: rpc, docs: Add note for commands that supports only legacy wallets.
Aug 2 2024, 18:49
Fabien committed rABC4433eca8dfa3: rpc, docs: Add note for commands that supports only legacy wallets (authored by Yusuf Sahin HAMZA <yusufsahinhamza@gmail.com>).
rpc, docs: Add note for commands that supports only legacy wallets
Aug 2 2024, 18:49
Fabien requested review of D16576: rpc, docs: Add note for commands that supports only legacy wallets.
Aug 2 2024, 16:19
Fabien requested review of D16575: Add a facility to create arith_uint256 from their double representation.
Aug 2 2024, 13:29
Fabien closed D16574: Factor bits to target conversion.
Aug 2 2024, 12:22
Fabien committed rABCfffc92300883: Factor bits to target conversion (authored by Fabien).
Factor bits to target conversion
Aug 2 2024, 12:22
Fabien added inline comments to D16571: [chronik] Add a struct to compute a block merkle tree.
Aug 2 2024, 12:13
Fabien created Image Macro "zero_day_since_new_dependency".
Aug 2 2024, 12:12
Fabien closed D16573: Rename TX_RECONSIDERABLE to TX_PACKAGE_RECONSIDERABLE.
Aug 2 2024, 09:23
Fabien committed rABC065b32f46618: Rename TX_RECONSIDERABLE to TX_PACKAGE_RECONSIDERABLE (authored by Fabien).
Rename TX_RECONSIDERABLE to TX_PACKAGE_RECONSIDERABLE
Aug 2 2024, 09:23
Fabien requested review of D16574: Factor bits to target conversion.
Aug 2 2024, 08:54
Fabien updated the diff for D16573: Rename TX_RECONSIDERABLE to TX_PACKAGE_RECONSIDERABLE.

Fix the table

Aug 2 2024, 07:19

Aug 1 2024

Fabien closed D16572: [chronik] Remove the legacy NNG tests.
Aug 1 2024, 19:32
Fabien committed rABC919430aa3058: [chronik] Remove the legacy NNG tests (authored by Fabien).
[chronik] Remove the legacy NNG tests
Aug 1 2024, 19:32
Fabien added inline comments to D16572: [chronik] Remove the legacy NNG tests.
Aug 1 2024, 19:29
Fabien requested review of D16573: Rename TX_RECONSIDERABLE to TX_PACKAGE_RECONSIDERABLE.
Aug 1 2024, 19:23
Fabien requested review of D16572: [chronik] Remove the legacy NNG tests.
Aug 1 2024, 19:01
Fabien closed D16570: [chronik-client] Fix flaky websocket integration test.
Aug 1 2024, 14:36
Fabien committed rABCc291418925bd: [chronik-client] Fix flaky websocket integration test (authored by Fabien).
[chronik-client] Fix flaky websocket integration test
Aug 1 2024, 14:36
Fabien requested review of D16570: [chronik-client] Fix flaky websocket integration test.
Aug 1 2024, 11:54
Fabien accepted D16557: [Chronik] Add `/plugin/:plugin_name/groups` HTTP endpoint.
Aug 1 2024, 11:15
Fabien closed D16565: depends: build miniupnpc with CMake.
Aug 1 2024, 11:12
Fabien committed rABCfb11627736ad: depends: build miniupnpc with CMake (authored by fanquake <fanquake@gmail.com>).
depends: build miniupnpc with CMake
Aug 1 2024, 11:12
Fabien closed D16567: depends: set two CMake options globally.
Aug 1 2024, 11:12
Fabien committed rABC2b387df82b00: depends: set two CMake options globally (authored by fanquake <fanquake@gmail.com>).
depends: set two CMake options globally
Aug 1 2024, 11:12
Fabien accepted D16568: [Chronik] Fix reading coinbase txs when plugins are loaded.
Aug 1 2024, 11:09
Fabien requested changes to D16557: [Chronik] Add `/plugin/:plugin_name/groups` HTTP endpoint.

only nits, generally lgtm

Aug 1 2024, 10:30
Fabien requested changes to D16560: [Chronik] Relax plugin height checks at startup.
Aug 1 2024, 09:45
Fabien added a comment to D16560: [Chronik] Relax plugin height checks at startup.

Also fix a small bug where can't get the tx details for coinbase txs if the plugin index is enabled.

Aug 1 2024, 09:45
Fabien accepted D16512: [Cashtab] Update TxHistory to recognize article post and article reply txs from eCashChat.
Aug 1 2024, 09:42
teamcity awarded D16565: depends: build miniupnpc with CMake a Mountain of Wealth token.
Aug 1 2024, 09:10
Fabien added a comment to D16565: depends: build miniupnpc with CMake.

@bot guix-linux guix-osx guix-win

Aug 1 2024, 09:10
Fabien updated the diff for D16565: depends: build miniupnpc with CMake.

Rebase

Aug 1 2024, 09:10
teamcity awarded D16567: depends: set two CMake options globally a Piece of Eight token.
Aug 1 2024, 09:09
Fabien added a comment to D16567: depends: set two CMake options globally.

@bot guix-linux guix-osx guix-win

Aug 1 2024, 09:09
Fabien updated the diff for D16567: depends: set two CMake options globally.

Restore the ninja generator and remove libmultiprocess

Aug 1 2024, 09:08
Fabien added a comment to D16567: depends: set two CMake options globally.
In D16567#375134, @PiRK wrote:

We are not using libmultiprocess

Aug 1 2024, 09:04
Fabien closed D16566: depends: always configure with --with-pic.
Aug 1 2024, 09:03
Fabien committed rABC6ff61af2cdb4: depends: always configure with --with-pic (authored by Fabien).
depends: always configure with --with-pic
Aug 1 2024, 09:03
Fabien planned changes to D16567: depends: set two CMake options globally.
Aug 1 2024, 09:02
Fabien planned changes to D16565: depends: build miniupnpc with CMake.
Aug 1 2024, 09:01
teamcity awarded D16566: depends: always configure with --with-pic a Haypence token.
Aug 1 2024, 07:51
Fabien added a comment to D16566: depends: always configure with --with-pic.

@bot guix-linux guix-osx guix-win

Aug 1 2024, 07:51
teamcity awarded D16567: depends: set two CMake options globally a Haypence token.
Aug 1 2024, 07:51
Fabien added a comment to D16567: depends: set two CMake options globally.

@bot guix-linux guix-osx guix-win

Aug 1 2024, 07:50
Fabien updated the summary of D16567: depends: set two CMake options globally.
Aug 1 2024, 07:50
teamcity awarded D16565: depends: build miniupnpc with CMake a Doubloon token.
Aug 1 2024, 07:50
Fabien added a comment to D16565: depends: build miniupnpc with CMake.

@bot guix-linux guix-osx guix-win

Aug 1 2024, 07:50
Fabien updated the summary of D16565: depends: build miniupnpc with CMake.
Aug 1 2024, 07:50
Fabien updated the diff for D16565: depends: build miniupnpc with CMake.

Rebase on D16567 to fix the lib

Aug 1 2024, 07:49
Fabien requested review of D16567: depends: set two CMake options globally.
Aug 1 2024, 07:48
Fabien requested review of D16566: depends: always configure with --with-pic.
Aug 1 2024, 07:47
Fabien added a comment to D16565: depends: build miniupnpc with CMake.
In D16565#375083, @PiRK wrote:

Symbol check is now failing. Not sure why it previously didn't pick up libminiupnpc, but now it does.

  FAILED: src/qt/CMakeFiles/symbol-check-bitcoin-qt /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/qt/CMakeFiles/symbol-check-bitcoin-qt
21:14:08   cd /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/qt && /home/bitcoinabc/.guix-profile/bin/python3.10 /bitcoin/contrib/devtools/symbol-check.py /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/qt/bitcoin-qt
21:14:08   /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/qt/bitcoin-qt: libminiupnpc.so.17 is not in ALLOWED_LIBRARIES!
21:14:08   /bitcoin/distsrc-87b0a4640229-x86_64-linux-gnu/src/qt/bitcoin-qt: failed LIBRARY_DEPENDENCIES
Aug 1 2024, 07:21
Fabien planned changes to D16565: depends: build miniupnpc with CMake.
Aug 1 2024, 07:19

Jul 31 2024

teamcity awarded D16565: depends: build miniupnpc with CMake a Piece of Eight token.
Jul 31 2024, 20:08
Fabien added a comment to D16565: depends: build miniupnpc with CMake.

@bot guix-linux guix-osx guix-win

Jul 31 2024, 20:08
Fabien updated the diff for D16565: depends: build miniupnpc with CMake.

Our cmake call sets the generator to ninja, so don't build with make

Jul 31 2024, 20:08
Fabien closed D16564: depends: patch libool out of libnatpmp/miniupnpc.
Jul 31 2024, 19:59
Fabien closed D16563: build: fix mingw miniupnpc cflags.
Jul 31 2024, 19:59
Fabien committed rABCcd7a9ae313ee: depends: patch libool out of libnatpmp/miniupnpc (authored by Cory Fields <cory-nospam-@coryfields.com>).
depends: patch libool out of libnatpmp/miniupnpc
Jul 31 2024, 19:59
Fabien committed rABC62af58c8a4a6: build: fix mingw miniupnpc cflags (authored by fanquake <fanquake@gmail.com>).
build: fix mingw miniupnpc cflags
Jul 31 2024, 19:59
Fabien closed D16562: build: miniupnpc 2.2.2.
Jul 31 2024, 19:59
Fabien committed rABC12144825fb38: build: miniupnpc 2.2.2 (authored by fanquake <fanquake@gmail.com>).
build: miniupnpc 2.2.2
Jul 31 2024, 19:59
Fabien planned changes to D16565: depends: build miniupnpc with CMake.
Jul 31 2024, 19:57
Fabien closed D16561: Extract tx pool outside of txorphanage.
Jul 31 2024, 19:40
Fabien committed rABCf1d9aa1f13d1: Extract tx pool outside of txorphanage (authored by Fabien).
Extract tx pool outside of txorphanage
Jul 31 2024, 19:40
teamcity awarded D16565: depends: build miniupnpc with CMake a Haypence token.
Jul 31 2024, 19:30
Fabien added a comment to D16565: depends: build miniupnpc with CMake.

@bot guix-linux guix-osx guix-win

Jul 31 2024, 19:30
Fabien updated the diff for D16565: depends: build miniupnpc with CMake.

Fix merge issue in dependencies.md

Jul 31 2024, 19:29
Fabien requested review of D16565: depends: build miniupnpc with CMake.
Jul 31 2024, 19:27
teamcity awarded D16564: depends: patch libool out of libnatpmp/miniupnpc a Haypence token.
Jul 31 2024, 19:17
Fabien added a comment to D16564: depends: patch libool out of libnatpmp/miniupnpc.

@bot guix-linux guix-osx guix-win

Jul 31 2024, 19:17
Fabien requested review of D16564: depends: patch libool out of libnatpmp/miniupnpc.
Jul 31 2024, 19:17
teamcity awarded D16563: build: fix mingw miniupnpc cflags a Haypence token.
Jul 31 2024, 18:57
Fabien added a comment to D16563: build: fix mingw miniupnpc cflags.

@bot guix-linux guix-osx guix-win

Jul 31 2024, 18:57