Updating comment (linter plz dont kill me )
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Feb 24 2025
Feb 24 2025
hazzarust updated the diff for D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.
hazzarust updated the diff for D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.
Updated !unreachable() comment and removed assert comments
roqqit committed rABC103c143b2bea: [avalanche] Fix missing wait_until in contender test (authored by roqqit).
[avalanche] Fix missing wait_until in contender test
teamcity triaged T3758: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Unbreak Now! priority.
hazzarust retitled D17687: [Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite-chronik-client from [Chronik] Add block_and_blocks integration test into bitcoinsuite-chronik-client to [Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite-chronik-client.
hazzarust updated the diff for D17687: [Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite-chronik-client.
Merged imports
teamcity triaged T3757: Build Bitcoin-ABC / CashTab / CashTab Unit Tests is broken. as Unbreak Now! priority.
hazzarust updated the test plan for D17687: [Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite-chronik-client.
hazzarust updated the diff for D17687: [Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite-chronik-client.
Updated the assert!() so that it will now anticipate 404 errors, renamed function names to be explicit
PiRK committed rABC33c0dc6359a1: test: remove unnecessary block rehashing prior to solving (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
test: remove unnecessary block rehashing prior to solving
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.
don't shadow j either
hazzarust updated the diff for D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.
Rename blockchain_info_ipc
Fabien added a comment to D17687: [Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite-chronik-client.
To ensure no breaking changes from the updated IPC file, run ./contrib/teamcity/build-configurations.py chronik-client-integration-tests from bitcoin-abc to run typescript tests.
Fabien added a comment to D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.
Maybe we could actually print to stdout what step is running and what it does instead of the comment, since stdout is captured by default and not shown upon success. But we can do that later if it feels necessary.
I can see a reason to enforce the char limit. When dealing with UI representation of the donation address, you can be certain that it will fit in your UI field that way.
Another reason is that an abc server might be rejected for invalid content by clients checking the limit if such a thing exists.
Feb 23 2025
Feb 23 2025
[Automated] Update chainparams
[Automated] Update seeds
[Automated] Update timing.json
PiRK planned changes to D17689: wallet: Ignore chainStateFlushed notifications while attaching chain.
CI failure most likely unrelated, but will have to investigate anyway (tomorrow)
teamcity added a comment to D17689: wallet: Ignore chainStateFlushed notifications while attaching chain.
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.
teamcity updated the summary of D17689: wallet: Ignore chainStateFlushed notifications while attaching chain.
PiRK requested review of D17689: wallet: Ignore chainStateFlushed notifications while attaching chain.
Feb 22 2025
Feb 22 2025
Unknown Object (User) added a comment to D15623: [token-server] Remove legacy use strict.
Unknown Object (User) added a comment to D15628: [chronik-client] Patch comment.
Backported as a dependency of https://github.com/bitcoin/bitcoin/pull/27596/commits/f073917a9e7ba423643dcae0339776470b628f65
hazzarust updated the diff for D17687: [Chronik] Add integration test for block_and_blocks endpoint into bitcoinsuite-chronik-client.
lint
hazzarust updated the diff for D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.
lint
fix comment layout
Feb 21 2025
Feb 21 2025
[avalanche] Poll for stake contenders
Fabien requested changes to D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.
Please make the linter happy
back to your queue
Build Bitcoin ABC Diffs / Diff Testing (build-chronik-plugins) failed.
Build Bitcoin ABC Diffs / Diff Testing (build-chronik) failed.
[chronik] Fix the chronik_plugins test
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
remove debug log
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
rebase
PiRK accepted D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Still lgtm
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Build Bitcoin ABC Diffs / Diff Testing (build-chronik-plugins) failed.
hazzarust updated the diff for D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.
Added unreachable panic, renamed test_blockchain_info to blockchain_info and added comments
Fabien committed rABC2f1230a53610: Fix nullptr clientModel access during shutdown (authored by furszy <matiasfurszyfer@protonmail.com>).
Fix nullptr clientModel access during shutdown
Fabien committed rABC4261e4fe94d7: [chronik] Fix handling of -chronikelectrummaxhistory (authored by Fabien).
[chronik] Fix handling of -chronikelectrummaxhistory
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
more finds
Build Bitcoin ABC Diffs / Diff Testing (build-chronik-plugins) failed.
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Build Bitcoin ABC Diffs / Diff Testing (build-chronik-plugins) failed.
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Build Bitcoin ABC Diffs / Diff Testing (build-chronik) failed.
works on my machine
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
more atoms_vec finds
bytesofman added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
apologies for the phab noise here ... not sure how to find all these locally. ninja check-functional is passing
teamcity triaged T3756: Build Bitcoin-ABC / Nightly Builds / GUIX Builds / GUIX MacOS is broken. as Unbreak Now! priority.
PiRK committed rABCb760220009df: [chronik] make the maximum history length for electrum RPCs an init param (authored by PiRK).
[chronik] make the maximum history length for electrum RPCs an init param
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Build Bitcoin ABC Diffs / Diff Testing (build-chronik-plugins) failed.
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Build Bitcoin ABC Diffs / Diff Testing (build-chronik) failed.
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
more atoms_vec
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Build Bitcoin ABC Diffs / Diff Testing (build-chronik-plugins) failed.