Page MenuHomePhabricator
Feed Advanced Search

Jun 3 2022

kieran709 updated the summary of D11565: [Cashtab] Automatically update jest snapshots.
Jun 3 2022, 17:06
kieran709 planned changes to D11565: [Cashtab] Automatically update jest snapshots.
Jun 3 2022, 16:56
kieran709 requested review of D11565: [Cashtab] Automatically update jest snapshots.
Jun 3 2022, 16:55
kieran709 updated the diff for D11523: [Cashtab] Route to onboarding if not wallet present.

updated snapshots

Jun 3 2022, 13:20

Jun 2 2022

kieran709 abandoned D11440: [Cashtab] Hide messages from unknown senders behind button.
Jun 2 2022, 20:14
kieran709 updated the diff for D11559: [Cashtab] Copy own address from Sign Message collapse in Send.js.

Responding to review feedback.

Jun 2 2022, 20:11
kieran709 closed D11558: [Cashtab] Add a copy address feature to contact list.
Jun 2 2022, 19:24
kieran709 committed rABCef75c7319123: [Cashtab] Add a copy address feature to contact list (authored by kieran709).
[Cashtab] Add a copy address feature to contact list
Jun 2 2022, 19:24
kieran709 requested review of D11559: [Cashtab] Copy own address from Sign Message collapse in Send.js.
Jun 2 2022, 15:36
kieran709 updated the summary of D11558: [Cashtab] Add a copy address feature to contact list.
Jun 2 2022, 15:19
kieran709 requested review of D11558: [Cashtab] Add a copy address feature to contact list.
Jun 2 2022, 15:19
kieran709 updated the diff for D11523: [Cashtab] Route to onboarding if not wallet present.

updated snapshots

Jun 2 2022, 13:36
kieran709 updated the diff for D11523: [Cashtab] Route to onboarding if not wallet present.

Responding to review feedback.

Jun 2 2022, 13:32

Jun 1 2022

kieran709 planned changes to D11523: [Cashtab] Route to onboarding if not wallet present.
Jun 1 2022, 19:14
kieran709 updated the diff for D11523: [Cashtab] Route to onboarding if not wallet present.

Responding to review feedback

Jun 1 2022, 19:13
kieran709 planned changes to D11523: [Cashtab] Route to onboarding if not wallet present.
Jun 1 2022, 19:13

May 31 2022

kieran709 closed D11528: [Cashtab] Button labeling & positioning in Contact List patch.
May 31 2022, 22:54
kieran709 committed rABC57dbf02e5987: [Cashtab] Button labeling & positioning in Contact List patch (authored by kieran709).
[Cashtab] Button labeling & positioning in Contact List patch
May 31 2022, 22:54
kieran709 updated the diff for D11528: [Cashtab] Button labeling & positioning in Contact List patch.

Applied device width rule directly to styled span instead of through the button component, changed Button to Btn for consistency.

May 31 2022, 20:08
kieran709 planned changes to D11528: [Cashtab] Button labeling & positioning in Contact List patch.
May 31 2022, 20:02
kieran709 updated the diff for D11528: [Cashtab] Button labeling & positioning in Contact List patch.

Responded to review feedback + updated snapshots

May 31 2022, 20:01
kieran709 updated the diff for D11523: [Cashtab] Route to onboarding if not wallet present.

Responded to review feedback + updated snapshots

May 31 2022, 19:44
kieran709 closed D11526: [Casthab] Remove classNames from Tx.js.
May 31 2022, 18:00
kieran709 committed rABCa27c3bf49dc1: [Casthab] Remove classNames from Tx.js (authored by kieran709).
[Casthab] Remove classNames from Tx.js
May 31 2022, 18:00
kieran709 updated the diff for D11526: [Casthab] Remove classNames from Tx.js.

Re-added className to AntdContextCollapseWrapper

May 31 2022, 16:51
kieran709 closed D11525: [Cashtab] Hide Add To Contacts option if sender is a contact.
May 31 2022, 15:49
kieran709 committed rABCb9a58952f19f: [Cashtab] Hide Add To Contacts option if sender is a contact (authored by kieran709).
[Cashtab] Hide Add To Contacts option if sender is a contact
May 31 2022, 15:49
kieran709 updated the diff for D11528: [Cashtab] Button labeling & positioning in Contact List patch.

Trying out hiding the word "add" and "download" to avoid stacking/wrapping.

May 31 2022, 14:39
kieran709 updated the summary of D11529: [Cashtab] Fix typo in TxHistory.
May 31 2022, 12:23
kieran709 closed D11529: [Cashtab] Fix typo in TxHistory.
May 31 2022, 10:55
kieran709 committed rABC2b7ec722b9ee: [Cashtab] Fix typo in TxHistory (authored by kieran709).
[Cashtab] Fix typo in TxHistory
May 31 2022, 10:55

May 27 2022

kieran709 requested review of D11529: [Cashtab] Fix typo in TxHistory.
May 27 2022, 18:36
kieran709 requested review of D11523: [Cashtab] Route to onboarding if not wallet present.
May 27 2022, 18:28
kieran709 updated the summary of D11523: [Cashtab] Route to onboarding if not wallet present.
May 27 2022, 18:27
kieran709 updated the diff for D11528: [Cashtab] Button labeling & positioning in Contact List patch.

Responding to review feedback

May 27 2022, 18:23
kieran709 abandoned D11521: [Cashtab] Remove classNames from Tx.js.
May 27 2022, 18:01
kieran709 requested review of D11528: [Cashtab] Button labeling & positioning in Contact List patch.
May 27 2022, 18:01
kieran709 requested review of D11526: [Casthab] Remove classNames from Tx.js.
May 27 2022, 17:02
kieran709 requested review of D11525: [Cashtab] Hide Add To Contacts option if sender is a contact.
May 27 2022, 16:51

May 26 2022

kieran709 closed D11455: [Cashtab] Tx receipt icon added to Tx dropdown menu.
May 26 2022, 23:25
kieran709 committed rABC22bfe0f92d9c: [Cashtab] Tx receipt icon added to Tx dropdown menu (authored by kieran709).
[Cashtab] Tx receipt icon added to Tx dropdown menu
May 26 2022, 23:25
kieran709 planned changes to D11523: [Cashtab] Route to onboarding if not wallet present.
May 26 2022, 23:22
kieran709 requested review of D11523: [Cashtab] Route to onboarding if not wallet present.
May 26 2022, 23:22
kieran709 updated the diff for D11518: [Cashtab] Added received from address to txHistory display.

Passed contactList as a prop through TxHistory, removed unnecessary code from Tx.js related to retrieving the contactList.

May 26 2022, 17:23
kieran709 added a comment to D11518: [Cashtab] Added received from address to txHistory display.

I am thinking I will pass down the contactList, but leave the flattened array as it is easier to check the addressesInContactList array than to iterate through each contact object to access the addresses for some of the conditional formatting. Let me know what you think of this approach, if that isn't a good solution I can try out some other options.

May 26 2022, 17:21
kieran709 updated the diff for D11455: [Cashtab] Tx receipt icon added to Tx dropdown menu.

Changed key for receipt's TxLink per review feedback.

May 26 2022, 14:54
kieran709 updated the diff for D11521: [Cashtab] Remove classNames from Tx.js.

Rebased to master

May 26 2022, 14:46

May 25 2022

kieran709 added inline comments to D11521: [Cashtab] Remove classNames from Tx.js.
May 25 2022, 19:57
kieran709 updated the summary of D11521: [Cashtab] Remove classNames from Tx.js.
May 25 2022, 17:55
kieran709 requested review of D11521: [Cashtab] Remove classNames from Tx.js.
May 25 2022, 17:55

May 24 2022

kieran709 requested review of D11518: [Cashtab] Added received from address to txHistory display.
May 24 2022, 19:24

May 23 2022

kieran709 updated the diff for D11455: [Cashtab] Tx receipt icon added to Tx dropdown menu.

Removed tooltips, reverted to original font-size and spacing, and altered written copy to match request. With these changes, the content was still being cut off when the screen was mobile sized, so flex-wrap was added to make the content wrap when the screen-width is less than 500px.

May 23 2022, 15:12
kieran709 updated the diff for D11440: [Cashtab] Hide messages from unknown senders behind button.

Default behaviour is changed, setting is now 'Hide messages from unkown senders', and its default state is off. The Reply to Message button is not shown if the message is hidden. Clicking 'show message' includes an transition effect on max-height. Updated snapshots and rebased to master.

May 23 2022, 14:51

May 18 2022

kieran709 updated the diff for D11455: [Cashtab] Tx receipt icon added to Tx dropdown menu.

rebased + updated snapshots

May 18 2022, 17:19
kieran709 updated the diff for D11455: [Cashtab] Tx receipt icon added to Tx dropdown menu.

updated snapshots

May 18 2022, 15:57
kieran709 updated the diff for D11455: [Cashtab] Tx receipt icon added to Tx dropdown menu.

Removed unnecessary gap reference

May 18 2022, 15:56
kieran709 updated the diff for D11455: [Cashtab] Tx receipt icon added to Tx dropdown menu.

Made font size smaller by one size, removed gap between Text Layer and icons, aligned text layer and icons to center, TextLayer is hidden when screen width is <500, added tooltip with TextLayer content that is visible if the text layer is hidden.

May 18 2022, 15:55

May 16 2022

kieran709 closed D11447: [Cashtab] Address content jumping for Send button.
May 16 2022, 21:20
kieran709 committed rABCdf5ae27a4a19: [Cashtab] Address content jumping for Send button (authored by kieran709).
[Cashtab] Address content jumping for Send button
May 16 2022, 21:20
kieran709 closed D11428: [Cashtab] Remove separate block explorers for token txs.
May 16 2022, 16:38
kieran709 committed rABC58b8a049ddc7: [Cashtab] Remove separate block explorers for token txs (authored by kieran709).
[Cashtab] Remove separate block explorers for token txs
May 16 2022, 16:38

May 12 2022

kieran709 requested review of D11455: [Cashtab] Tx receipt icon added to Tx dropdown menu.
May 12 2022, 16:17

May 11 2022

kieran709 abandoned D11297: [Cashtab] Remove white border from inputs in Airdrop.js.
May 11 2022, 17:33
kieran709 requested review of D11447: [Cashtab] Address content jumping for Send button.
May 11 2022, 15:32

May 10 2022

kieran709 updated the summary of D11440: [Cashtab] Hide messages from unknown senders behind button.
May 10 2022, 22:12
kieran709 updated the diff for D11428: [Cashtab] Remove separate block explorers for token txs.

Responding to review feedback, test plan changed to include grep -r 'tokenExplorerUrl' src/

May 10 2022, 20:51
kieran709 updated the diff for D11440: [Cashtab] Hide messages from unknown senders behind button.

Fixed isValidCashtabSetting in validation.test.js

May 10 2022, 20:17
kieran709 planned changes to D11440: [Cashtab] Hide messages from unknown senders behind button.
May 10 2022, 18:34
kieran709 updated the diff for D11440: [Cashtab] Hide messages from unknown senders behind button.

fixed spelling mistake

May 10 2022, 18:34
kieran709 planned changes to D11440: [Cashtab] Hide messages from unknown senders behind button.
May 10 2022, 18:32
kieran709 requested review of D11440: [Cashtab] Hide messages from unknown senders behind button.
May 10 2022, 18:32

May 6 2022

kieran709 updated the test plan for D11428: [Cashtab] Remove separate block explorers for token txs.
May 6 2022, 06:01
kieran709 updated the diff for D11428: [Cashtab] Remove separate block explorers for token txs.

Responding to review feedback

May 6 2022, 06:00

May 5 2022

kieran709 closed D11409: [Cashtab] Signature Copied text color patch.
May 5 2022, 18:51
kieran709 committed rABC7d6f9672f27a: [Cashtab] Signature Copied text color patch (authored by kieran709).
[Cashtab] Signature Copied text color patch
May 5 2022, 18:51
kieran709 closed D11410: [Cashtab] Airdrop modal percentage color patch.
May 5 2022, 18:42
kieran709 committed rABC82e236211536: [Cashtab] Airdrop modal percentage color patch (authored by kieran709).
[Cashtab] Airdrop modal percentage color patch
May 5 2022, 18:42
kieran709 requested review of D11428: [Cashtab] Remove separate block explorers for token txs.
May 5 2022, 18:36
kieran709 abandoned D11040: [Cashtab] Remove separate block explorers for token txs..
May 5 2022, 18:31
kieran709 abandoned D11427: [Cashtab] Remove separate block explorers for token txs..
May 5 2022, 18:30
kieran709 updated the diff for D11427: [Cashtab] Remove separate block explorers for token txs..

responding to review feedback

May 5 2022, 18:30
kieran709 abandoned D11427: [Cashtab] Remove separate block explorers for token txs..
May 5 2022, 18:27
kieran709 requested review of D11427: [Cashtab] Remove separate block explorers for token txs..
May 5 2022, 18:26
kieran709 updated the diff for D11410: [Cashtab] Airdrop modal percentage color patch.

responding to review feedback

May 5 2022, 14:50
kieran709 updated the diff for D11409: [Cashtab] Signature Copied text color patch.

Updated snapshots

May 5 2022, 14:37

May 4 2022

kieran709 requested review of D11412: [Cashtab] Parse airdrop txs in tx history.
May 4 2022, 22:02
kieran709 requested review of D11410: [Cashtab] Airdrop modal percentage color patch.
May 4 2022, 17:54
kieran709 requested review of D11409: [Cashtab] Signature Copied text color patch.
May 4 2022, 16:10

May 3 2022

kieran709 closed D11403: [Cashtab] Parse amount param in XEC.
May 3 2022, 18:23
kieran709 committed rABC688711121371: [Cashtab] Parse amount param in XEC (authored by kieran709).
[Cashtab] Parse amount param in XEC
May 3 2022, 18:23
kieran709 closed D11315: [Cashtab] Center collapse headers in Send.js.
May 3 2022, 14:40
kieran709 committed rABC530a41fbf048: [Cashtab] Center collapse headers in Send.js (authored by kieran709).
[Cashtab] Center collapse headers in Send.js
May 3 2022, 14:40
kieran709 updated the diff for D11403: [Cashtab] Parse amount param in XEC.

Responding to review feedback

May 3 2022, 14:35

May 2 2022

kieran709 updated the diff for D11315: [Cashtab] Center collapse headers in Send.js.

updated snapshots

May 2 2022, 22:44
kieran709 updated the diff for D11403: [Cashtab] Parse amount param in XEC.

responding to review feedback

May 2 2022, 22:35
kieran709 requested review of D11403: [Cashtab] Parse amount param in XEC.
May 2 2022, 18:34
kieran709 updated the diff for D11315: [Cashtab] Center collapse headers in Send.js.

Responding to review feedback

May 2 2022, 15:55

Apr 28 2022

kieran709 updated the diff for D11315: [Cashtab] Center collapse headers in Send.js.

Responding to review feedback + rebased & updated snapshots

Apr 28 2022, 15:42

Apr 27 2022

kieran709 closed D11387: [Cashtab] Patch character limit counter font color.
Apr 27 2022, 14:41
kieran709 committed rABC2b43b6e128ba: [Cashtab] Patch character limit counter font color (authored by kieran709).
[Cashtab] Patch character limit counter font color
Apr 27 2022, 14:41