Page MenuHomePhabricator
Feed Advanced Search

Aug 3 2022

kieran709 planned changes to D11823: [Cashtab] Add ability to rename active wallet.
Aug 3 2022, 14:55
kieran709 requested review of D11823: [Cashtab] Add ability to rename active wallet.
Aug 3 2022, 14:44

Jul 29 2022

kieran709 abandoned D11810: [Cashtab] Change toSmallestDenomination and fromSmallestDenomination function names.
Jul 29 2022, 16:22
kieran709 accepted D11771: [cashtab-components] Replace SLPA references with eToken.
Jul 29 2022, 16:05
kieran709 updated the diff for D11627: [Cashtab] Hide msgs from unknown senders option.

Minor styling fix

Jul 29 2022, 14:55
kieran709 updated the diff for D11627: [Cashtab] Hide msgs from unknown senders option.

Replaced Links with custom styled button component. Small styling changes have been made to accommodate the new button component. Updated snapshots.

Jul 29 2022, 14:53

Jul 28 2022

kieran709 closed D11813: [cashtab-components] Remove all references to BCHA and replace with XEC.
Jul 28 2022, 18:41
kieran709 committed rABC019b905282f8: [cashtab-components] Remove all references to BCHA and replace with XEC (authored by kieran709).
[cashtab-components] Remove all references to BCHA and replace with XEC
Jul 28 2022, 18:41
kieran709 updated the diff for D11627: [Cashtab] Hide msgs from unknown senders option.

Rebased per review feedback

Jul 28 2022, 15:25

Jul 27 2022

kieran709 requested review of D11813: [cashtab-components] Remove all references to BCHA and replace with XEC.
Jul 27 2022, 21:26
kieran709 closed D11602: [Cashtab] Hide QR popup setting.
Jul 27 2022, 16:08
kieran709 committed rABC29f46e8cd7cf: [Cashtab] Hide QR popup setting (authored by kieran709).
[Cashtab] Hide QR popup setting
Jul 27 2022, 16:08
kieran709 requested review of D11810: [Cashtab] Change toSmallestDenomination and fromSmallestDenomination function names.
Jul 27 2022, 15:46

Jul 26 2022

kieran709 closed D11804: [Cashtab] Hide spinner in Send.js Amount input on Firefox.
Jul 26 2022, 17:52
kieran709 committed rABCa33f0cff67bd: [Cashtab] Hide spinner in Send.js Amount input on Firefox (authored by kieran709).
[Cashtab] Hide spinner in Send.js Amount input on Firefox
Jul 26 2022, 17:52
kieran709 updated the diff for D11627: [Cashtab] Hide msgs from unknown senders option.

Rebased to master, updated validation test for parseInvalidSettingsForMigration function to include new default setting and added logic to hide the 'Hide' button on outgoing messages.

Jul 26 2022, 16:31
kieran709 updated the test plan for D11804: [Cashtab] Hide spinner in Send.js Amount input on Firefox.
Jul 26 2022, 15:50
kieran709 requested review of D11804: [Cashtab] Hide spinner in Send.js Amount input on Firefox.
Jul 26 2022, 15:49
kieran709 updated the diff for D11602: [Cashtab] Hide QR popup setting.

Rebased and updated validation tests to include new defaultSetting.

Jul 26 2022, 14:33

Jul 19 2022

kieran709 closed D11740: [Cashtab] Add parseInvalidSettingsForMigration function.
Jul 19 2022, 14:28
kieran709 committed rABCfd65d04c4c52: [Cashtab] Add parseInvalidSettingsForMigration function (authored by kieran709).
[Cashtab] Add parseInvalidSettingsForMigration function
Jul 19 2022, 14:28

Jul 13 2022

kieran709 closed D11731: [cashtab-components] Replace all instances of CashTab with Cashtab.
Jul 13 2022, 12:24
kieran709 committed rABC1224b79d4b42: [cashtab-components] Replace all instances of CashTab with Cashtab (authored by kieran709).
[cashtab-components] Replace all instances of CashTab with Cashtab
Jul 13 2022, 12:24

Jul 12 2022

kieran709 requested review of D11741: [Cashtab] currency.prefixes & currency.tokenPrefixes converted to strings.
Jul 12 2022, 19:09
kieran709 updated the summary of D11518: [Cashtab] Added received from address to txHistory display.
Jul 12 2022, 18:40
kieran709 requested review of D11740: [Cashtab] Add parseInvalidSettingsForMigration function.
Jul 12 2022, 15:49
kieran709 abandoned D11662: [Cashtab] Add parseInvalidSettingsForMigration function.

Abandonning as arc diff attempts to commit diff to wrong revision.

Jul 12 2022, 15:37
kieran709 updated the diff for D11731: [cashtab-components] Replace all instances of CashTab with Cashtab.

Bumped extension version in web/cashtab/extension/public/manifest.json, and cashtab-components storybook version in web/cashtab-components/package.json. Updated test plan per review feedback.

Jul 12 2022, 15:08
kieran709 added a comment to D11731: [cashtab-components] Replace all instances of CashTab with Cashtab.

I don't think it is related to this diff, but in storybook, all of the CashtabButton components are throwing this error.

Jul 12 2022, 15:02
kieran709 updated the test plan for D11731: [cashtab-components] Replace all instances of CashTab with Cashtab.
Jul 12 2022, 14:59

Jul 11 2022

kieran709 closed D11730: [Cashtab] contactList PropType error patch.
Jul 11 2022, 12:49
kieran709 committed rABCe328572e90f4: [Cashtab] contactList PropType error patch (authored by kieran709).
[Cashtab] contactList PropType error patch
Jul 11 2022, 12:49

Jul 8 2022

kieran709 updated the diff for D11662: [Cashtab] Add parseInvalidSettingsForMigration function.

Added unit tests to validation.test.js

Jul 8 2022, 19:18
kieran709 updated the summary of D11730: [Cashtab] contactList PropType error patch.
Jul 8 2022, 16:40
kieran709 updated the diff for D11731: [cashtab-components] Replace all instances of CashTab with Cashtab.

responding to review feedback

Jul 8 2022, 14:59
kieran709 updated the test plan for D11731: [cashtab-components] Replace all instances of CashTab with Cashtab.
Jul 8 2022, 14:58

Jul 7 2022

kieran709 added inline comments to D11731: [cashtab-components] Replace all instances of CashTab with Cashtab.
Jul 7 2022, 23:46
kieran709 updated the diff for D11662: [Cashtab] Add parseInvalidSettingsForMigration function.

Responding to review feedback

Jul 7 2022, 23:36
kieran709 updated the diff for D11662: [Cashtab] Add parseInvalidSettingsForMigration function.

Check isValidCasthabSettings(modifiedLocalSettings), updated comment in validation.js to reflect what is happening now.

Jul 7 2022, 19:37
kieran709 requested review of D11731: [cashtab-components] Replace all instances of CashTab with Cashtab.
Jul 7 2022, 18:27
kieran709 updated the summary of D11730: [Cashtab] contactList PropType error patch.
Jul 7 2022, 18:09
kieran709 requested review of D11730: [Cashtab] contactList PropType error patch.
Jul 7 2022, 18:06

Jul 6 2022

kieran709 planned changes to D11062: [Cashtab] fix fee calculation.
Jul 6 2022, 19:11
kieran709 updated the diff for D11062: [Cashtab] fix fee calculation.

Commandeered & rebased to master

Jul 6 2022, 19:11

Jun 30 2022

kieran709 updated the diff for D11662: [Cashtab] Add parseInvalidSettingsForMigration function.

Responding to review feedback

Jun 30 2022, 18:43
kieran709 requested review of D11689: [Cashtab] Parse airdrops in TxHistory.
Jun 30 2022, 14:39

Jun 24 2022

kieran709 closed D11579: [Cashtab] Replaced all instances of react-copy-to-clipboard.
Jun 24 2022, 21:11
kieran709 committed rABCcd32d52d47e7: [Cashtab] Replaced all instances of react-copy-to-clipboard (authored by kieran709).
[Cashtab] Replaced all instances of react-copy-to-clipboard
Jun 24 2022, 21:11

Jun 23 2022

kieran709 updated the diff for D11602: [Cashtab] Hide QR popup setting.

fixed no-unused-vars error

Jun 23 2022, 18:11
kieran709 retitled D11662: [Cashtab] Add parseInvalidSettingsForMigration function from [Cashtab] Add parseInvalidSettingsForMigrationFunction to [Cashtab] Add parseInvalidSettingsForMigration function.
Jun 23 2022, 18:08
kieran709 requested review of D11662: [Cashtab] Add parseInvalidSettingsForMigration function.
Jun 23 2022, 18:06
kieran709 updated the test plan for D11602: [Cashtab] Hide QR popup setting.
Jun 23 2022, 16:44
kieran709 updated the diff for D11602: [Cashtab] Hide QR popup setting.

responding to review feedback

Jun 23 2022, 16:43
kieran709 updated the diff for D11579: [Cashtab] Replaced all instances of react-copy-to-clipboard.

Refactored onClick function

Jun 23 2022, 16:19

Jun 21 2022

kieran709 updated the test plan for D11602: [Cashtab] Hide QR popup setting.
Jun 21 2022, 16:44
kieran709 updated the diff for D11602: [Cashtab] Hide QR popup setting.

responding to review feedback

Jun 21 2022, 16:41

Jun 20 2022

kieran709 commandeered D11062: [Cashtab] fix fee calculation.
Jun 20 2022, 18:22
kieran709 closed D11638: [Cashtab] Reply To Message button should just read Replyr.
Jun 20 2022, 17:01
kieran709 committed rABCd4c1b49be602: [Cashtab] Reply To Message button should just read Replyr (authored by kieran709).
[Cashtab] Reply To Message button should just read Replyr
Jun 20 2022, 17:01

Jun 17 2022

kieran709 requested review of D11638: [Cashtab] Reply To Message button should just read Replyr.
Jun 17 2022, 15:56

Jun 16 2022

kieran709 accepted D11629: [Cashtab] Upgrade chronik-client to patck new block msgs.
Jun 16 2022, 15:54

Jun 15 2022

kieran709 updated the summary of D11602: [Cashtab] Hide QR popup setting.
Jun 15 2022, 17:21
kieran709 updated the diff for D11579: [Cashtab] Replaced all instances of react-copy-to-clipboard.

Responded to review feedback, PropTypes changed to object with title and msg key/value pairs. Logic has been added to the CopyToClipboard component to deal with cases where message + title & msg or title is blank.

Jun 15 2022, 16:24

Jun 14 2022

kieran709 closed D11620: [Cashtab] Patch bracket color for Documentation link.
Jun 14 2022, 17:58
kieran709 committed rABCc54b726a53bd: [Cashtab] Patch bracket color for Documentation link (authored by kieran709).
[Cashtab] Patch bracket color for Documentation link
Jun 14 2022, 17:58
kieran709 requested review of D11627: [Cashtab] Hide msgs from unknown senders option.
Jun 14 2022, 17:55

Jun 13 2022

kieran709 accepted D11621: [Cashtab] Upgrade to latest chronik-client.
Jun 13 2022, 17:25
kieran709 requested review of D11620: [Cashtab] Patch bracket color for Documentation link.
Jun 13 2022, 16:26
kieran709 closed D11614: [Cashtab] Patch collapse proptype error.
Jun 13 2022, 14:43
kieran709 committed rABC4bc441ac7cc8: [Cashtab] Patch collapse proptype error (authored by kieran709).
[Cashtab] Patch collapse proptype error
Jun 13 2022, 14:43

Jun 10 2022

kieran709 requested review of D11614: [Cashtab] Patch collapse proptype error.
Jun 10 2022, 20:05
kieran709 updated the diff for D11602: [Cashtab] Hide QR popup setting.

Per review feedback, the cashtab setting has been switched from autoCameraOff to autoCameraOn, and the default value has been set to match existing cashtab behaviour. Wording has also changed to reflect review feedback.

Jun 10 2022, 19:00
kieran709 updated the diff for D11579: [Cashtab] Replaced all instances of react-copy-to-clipboard.

responding to review feedback

Jun 10 2022, 15:53
kieran709 closed D11518: [Cashtab] Added received from address to txHistory display.
Jun 10 2022, 00:48
kieran709 committed rABCc12187959643: [Cashtab] Added received from address to txHistory display (authored by kieran709).
[Cashtab] Added received from address to txHistory display
Jun 10 2022, 00:48

Jun 9 2022

kieran709 updated the diff for D11518: [Cashtab] Added received from address to txHistory display.

Responding to review feedback

Jun 9 2022, 21:17
kieran709 requested review of D11602: [Cashtab] Hide QR popup setting.
Jun 9 2022, 21:01
kieran709 updated the diff for D11518: [Cashtab] Added received from address to txHistory display.

Responding to review feedback

Jun 9 2022, 15:23

Jun 8 2022

kieran709 accepted D11592: [Cashtab] Prevent caching of index.html.
Jun 8 2022, 19:46
kieran709 updated the diff for D11518: [Cashtab] Added received from address to txHistory display.

Added logic to handle cases where contactAddress !== dataAddress, and changed the key per review feedback.

Jun 8 2022, 17:20
kieran709 updated the diff for D11579: [Cashtab] Replaced all instances of react-copy-to-clipboard.

responding to review feedback

Jun 8 2022, 16:21
kieran709 updated the diff for D11518: [Cashtab] Added received from address to txHistory display.

Responding to review feedback

Jun 8 2022, 14:21

Jun 7 2022

kieran709 updated the test plan for D11579: [Cashtab] Replaced all instances of react-copy-to-clipboard.
Jun 7 2022, 20:30
kieran709 updated the diff for D11518: [Cashtab] Added received from address to txHistory display.

responding to review feedback

Jun 7 2022, 20:27
kieran709 requested review of D11579: [Cashtab] Replaced all instances of react-copy-to-clipboard.
Jun 7 2022, 16:46
kieran709 closed D11572: [Cashtab] Route to onboarding if no wallet present.
Jun 7 2022, 14:49
kieran709 committed rABC5aea9cadfd90: [Cashtab] Route to onboarding if no wallet present (authored by kieran709).
[Cashtab] Route to onboarding if no wallet present
Jun 7 2022, 14:49

Jun 6 2022

kieran709 updated the diff for D11572: [Cashtab] Route to onboarding if no wallet present.

Responding to review feedback

Jun 6 2022, 21:00
kieran709 updated the diff for D11572: [Cashtab] Route to onboarding if no wallet present.

Responding to review feedback

Jun 6 2022, 20:44
kieran709 closed D11559: [Cashtab] Copy own address from Sign Message collapse in Send.js.
Jun 6 2022, 19:55
kieran709 committed rABCe2dd146417da: [Cashtab] Copy own address from Sign Message collapse in Send.js (authored by kieran709).
[Cashtab] Copy own address from Sign Message collapse in Send.js
Jun 6 2022, 19:55
kieran709 requested review of D11572: [Cashtab] Route to onboarding if no wallet present.
Jun 6 2022, 16:28
kieran709 abandoned D11523: [Cashtab] Route to onboarding if not wallet present.
Jun 6 2022, 16:11

Jun 3 2022

kieran709 abandoned D11565: [Cashtab] Automatically update jest snapshots.
Jun 3 2022, 23:47
kieran709 accepted D11566: [Cashtab] Run npm test before commit.
Jun 3 2022, 18:53
kieran709 retitled D11565: [Cashtab] Automatically update jest snapshots from [Cashtab] Autmatically update jest snapshots to [Cashtab] Automatically update jest snapshots.
Jun 3 2022, 17:37
kieran709 planned changes to D11565: [Cashtab] Automatically update jest snapshots.
Jun 3 2022, 17:34
kieran709 updated the diff for D11565: [Cashtab] Automatically update jest snapshots.

Reinstall husky as a dev-dependency.

Jun 3 2022, 17:34
kieran709 planned changes to D11565: [Cashtab] Automatically update jest snapshots.
Jun 3 2022, 17:18
kieran709 updated the diff for D11565: [Cashtab] Automatically update jest snapshots.

Altered pre-commit script

Jun 3 2022, 17:18