Page MenuHomePhabricator
Feed All Stories

Yesterday

bytesofman published D18086: [Cashtab, doc] Suppport empp raw push addition for bip21 and ALP sends for review.
Wed, May 14, 22:07
johnkuney planned changes to D18091: [e.cash] init v2 build.
Wed, May 14, 22:02
johnkuney requested review of D18091: [e.cash] init v2 build.
Wed, May 14, 21:13
PiRK accepted D18089: [chronik] Extract scripthash history lookup into its own function.
Wed, May 14, 20:41
Fabien requested review of D18090: [chronik] Fix "elided lifetime has a name" warnings.
Wed, May 14, 14:57
Fabien requested review of D18089: [chronik] Extract scripthash history lookup into its own function.
Wed, May 14, 14:53
bytesofman accepted D18088: Bump version to 0.31.4.
Wed, May 14, 13:08
Fabien requested review of D18088: Bump version to 0.31.4.
Wed, May 14, 12:35
hazzarust closed D17928: [chronik] Add address.rs from givelotus/bitcoinsuite into bitcoinsuite-chronik-client.
Wed, May 14, 10:03
hazzarust committed rABC5061695e9d5b: [chronik] Add address.rs from givelotus/bitcoinsuite into bitcoinsuite-chronik… (authored by hazzarust).
[chronik] Add address.rs from givelotus/bitcoinsuite into bitcoinsuite-chronik…
Wed, May 14, 10:03
bytesofman requested changes to D18085: [cashtab] Prevent wheel event for agora price setting input..
Wed, May 14, 06:51
alitayin updated the diff for D18085: [cashtab] Prevent wheel event for agora price setting input..

Pass in the type. Here, unlike elsewhere where used text, I used number by default here. This component is
currently only used in these two places.

Wed, May 14, 02:21

Tue, May 13

johnkuney closed D18066: [cashtab] Header UI overhaul.
Tue, May 13, 23:22
johnkuney committed rABC3870a0ac7d0b: [cashtab] Header UI overhaul (authored by johnkuney).
[cashtab] Header UI overhaul
Tue, May 13, 23:22
bytesofman accepted D18066: [cashtab] Header UI overhaul.
Tue, May 13, 22:13
johnkuney updated the diff for D18066: [cashtab] Header UI overhaul.

test edit

Tue, May 13, 21:41
teamcity added a comment to D18066: [cashtab] Header UI overhaul.
Tue, May 13, 21:10
johnkuney updated the diff for D18066: [cashtab] Header UI overhaul.

version bump

Tue, May 13, 21:05
johnkuney updated the diff for D18066: [cashtab] Header UI overhaul.

findbyText instead of findbyTitle

Tue, May 13, 18:18
bytesofman requested changes to D18066: [cashtab] Header UI overhaul.
Tue, May 13, 18:13
teamcity added a comment to D18066: [cashtab] Header UI overhaul.
Tue, May 13, 18:04
johnkuney updated the diff for D18066: [cashtab] Header UI overhaul.

increase timeout to 20000

Tue, May 13, 17:59
teamcity added a comment to D18066: [cashtab] Header UI overhaul.
Tue, May 13, 17:44
teamcity added a comment to D18066: [cashtab] Header UI overhaul.
Tue, May 13, 17:43
johnkuney updated the diff for D18066: [cashtab] Header UI overhaul.

fix test value

Tue, May 13, 17:40
teamcity added a comment to D18066: [cashtab] Header UI overhaul.
Tue, May 13, 17:39
johnkuney updated the diff for D18066: [cashtab] Header UI overhaul.

remove waitFor

Tue, May 13, 17:38
johnkuney updated the diff for D18066: [cashtab] Header UI overhaul.

remove failed-test file, and remove waitFor from test, add increased timeout value to prevent timeout failures in tests

Tue, May 13, 17:34
bytesofman requested changes to D18066: [cashtab] Header UI overhaul.
  • Remove cashtab/failed-tests.txt
  • using await screen.findByText with timeout instead of await waitFor()...
Tue, May 13, 16:54
teamcity added a comment to D18066: [cashtab] Header UI overhaul.
Tue, May 13, 15:15
johnkuney updated the diff for D18066: [cashtab] Header UI overhaul.

test toubleshooting

Tue, May 13, 15:10
johnkuney updated the diff for D18066: [cashtab] Header UI overhaul.

test troubleshooting

Tue, May 13, 14:30
PiRK closed D18079: [assumeutxo] document and enforce incompatability with -chronik.
Tue, May 13, 14:07
PiRK committed rABC29a3da832574: [assumeutxo] document and enforce incompatability with -chronik (authored by PiRK).
[assumeutxo] document and enforce incompatability with -chronik
Tue, May 13, 14:07
johnkuney added a comment to D18066: [cashtab] Header UI overhaul.

Nice, for sure can get those in another diff.

Tue, May 13, 13:53
bytesofman requested changes to D18085: [cashtab] Prevent wheel event for agora price setting input..

this exists in a few spots in Cashtab, and is correctly fixed on the latest input -- the one on the Receive screen

Tue, May 13, 12:59
bytesofman accepted D18066: [cashtab] Header UI overhaul.

nice imo this is much better than what we have currently. testing nit.

Tue, May 13, 12:33
Fabien accepted D18079: [assumeutxo] document and enforce incompatability with -chronik.
Tue, May 13, 09:40
PiRK updated the diff for D18079: [assumeutxo] document and enforce incompatability with -chronik.

we can only pass "-chronik" if chronik is compiled. Unfortunately there is no convenient way to start the node only if chronik is compiled, so start it with no params if we are not going to run that test.
Add a couple of chronik calls to better check that chronik was succesfully started.

Tue, May 13, 08:02
Fabien closed D18084: [chronik-client] Properly handle txs ordering in the test.
Tue, May 13, 07:20
Fabien committed rABCe29827cea629: [chronik-client] Properly handle txs ordering in the test (authored by Fabien).
[chronik-client] Properly handle txs ordering in the test
Tue, May 13, 07:20
Fabien added inline comments to D18084: [chronik-client] Properly handle txs ordering in the test.
Tue, May 13, 07:18
alitayin requested review of D18085: [cashtab] Prevent wheel event for agora price setting input..
Tue, May 13, 06:46
PiRK accepted D18084: [chronik-client] Properly handle txs ordering in the test.

optional suggestions. The bytes flipping + explicit byteorder specification hurts my brain.

Tue, May 13, 06:04
PiRK added inline comments to D18084: [chronik-client] Properly handle txs ordering in the test.
Tue, May 13, 06:03
johnkuney updated the diff for D18066: [cashtab] Header UI overhaul.

rebase

Tue, May 13, 04:18