Page MenuHomePhabricator
Feed Advanced Search

Mar 12 2024

emack published D15672: [standards] Reserve op_return prefix for eCash Chat platform for review.
Mar 12 2024, 23:20

Mar 9 2024

emack requested changes to D15662: [Cashtab] Change wallet structure to store balanceSats as number instead of balances as object.
Mar 9 2024, 05:44
emack closed D15656: [e.cash] Add extension to wallet page.
Mar 9 2024, 05:30
emack committed rABC94450f474e27: [e.cash] Add extension to wallet page (authored by emack).
[e.cash] Add extension to wallet page
Mar 9 2024, 05:30
teamcity awarded D15656: [e.cash] Add extension to wallet page a Piece of Eight token.
Mar 9 2024, 05:21
emack accepted D15669: [Cashtab] Cleaner state setting in activateWallet.
Mar 9 2024, 05:09
emack added a comment to D15656: [e.cash] Add extension to wallet page.

image.png (454×982 px, 84 KB)

Mar 9 2024, 02:50
emack updated the diff for D15656: [e.cash] Add extension to wallet page.

Updated wed/extension logos and wording.

Mar 9 2024, 02:50

Mar 8 2024

emack accepted D15612: [Cashtab] Cashtab 2.0.0 - Migrate to new wallet management API.
Mar 8 2024, 13:59
teamcity awarded D15656: [e.cash] Add extension to wallet page a Haypence token.
Mar 8 2024, 13:43
emack requested review of D15656: [e.cash] Add extension to wallet page.
Mar 8 2024, 13:42
emack requested changes to D15612: [Cashtab] Cashtab 2.0.0 - Migrate to new wallet management API.

Manual testing observations:

  • When switched to another wallet, the wallets[0] is updated but the separate wallet object is still on the previous wallet. Deleting this stale wallet in the wallet object does not update it.
  • Even with this mammoth refactor, wallet cache did not nuke.
  • No longer seeing that edge case where clicking Activate on another wallet loops back to the same wallet, until you click Activate a 2nd time
  • Wallet switching is soooo much faster now
Mar 8 2024, 13:17

Mar 7 2024

emack accepted D15647: [token-server] Add function getTxTimestamp to get best timestamp from a chronik Tx_InNode.
Mar 7 2024, 09:44
emack accepted D15640: [mock-chronik-client] Move to modules.
Mar 7 2024, 08:27

Mar 6 2024

emack requested changes to D15640: [mock-chronik-client] Move to modules.

Error: Cannot find module '../../mock-chronik-client/mocks/mockChronikResponses'
Require stack:

  • /work/apps/examples/test/sendXec.test.js
Mar 6 2024, 03:14
emack accepted D15638: [token-server] Add new function to determine if a given tx involves an address receiving a given tokenId.
Mar 6 2024, 00:54
emack accepted D15639: [token-server] Upgrade chronik-client to get latest types.
Mar 6 2024, 00:53
emack requested changes to D15638: [token-server] Add new function to determine if a given tx involves an address receiving a given tokenId.

Just so I'm clear on the underlying use case here, will this be used to parse through all tx history of the address to figure out whether the address has received this token at least once in its entire history, or is it to determine the user is currently holding a balance of this tokenId? If it's the latter then you can just use the etoken-list lib can't you?

Mar 6 2024, 00:41
emack accepted D15630: [chronik-client] Improve organization of subscriptions in ws object.
Mar 6 2024, 00:22
emack accepted D15637: [mock-chronik-client] Support ws.unsubscribe.
Mar 6 2024, 00:01

Mar 5 2024

emack accepted D15625: [token-server] Add function hasInputsFromOutputScript.
Mar 5 2024, 22:12
emack requested changes to D15637: [mock-chronik-client] Support ws.unsubscribe.
Mar 5 2024, 22:06
emack accepted D15613: [mock-chronik-client] Support sub/unsub address method for ws.

accepted with note

Mar 5 2024, 21:53
emack accepted D15621: Revert "[mock-chronik-client] Publish as npm pkg and install where used".
Mar 5 2024, 21:42
emack accepted D15626: [chronik-client] Improve type definition.
Mar 5 2024, 07:21
emack added a comment to D15625: [token-server] Add function hasInputsFromOutputScript.

I assume txs like this self minting tx are out of scope for this token server right? The function will return false as the minter won't be in the inputs but I guess this wouldn't be generated out of cashtab anyway yea?

Mar 5 2024, 07:09
emack accepted D15628: [chronik-client] Patch comment.
Mar 5 2024, 03:31

Mar 3 2024

emack accepted D15614: [mock-chronik-client] Publish as npm pkg and install where used.
Mar 3 2024, 03:41
emack accepted D15611: [chronik-client] Sub and unsub to and from addresses for websocket.
Mar 3 2024, 03:27

Mar 2 2024

emack requested changes to D15611: [chronik-client] Sub and unsub to and from addresses for websocket.
Mar 2 2024, 23:33
emack accepted D15609: [token-server] Implement typescript.
Mar 2 2024, 23:23
emack accepted D15610: [Cashtab] Replace conflicting functions with more comprehensive validation function.
Mar 2 2024, 22:39
emack planned changes to D15000: [Cashtab] Enable wallet switching from Home screen.
Mar 2 2024, 13:33
emack planned changes to D15079: [Cashtab] Ignore function for tokens - pt 1 of 2.
Mar 2 2024, 13:33
emack planned changes to D15188: [Cashtab] Tx History Pagination.
Mar 2 2024, 13:33
emack planned changes to D15375: [Cashtab] Improve multi send value validation.
Mar 2 2024, 13:33
emack planned changes to D15466: [Cashtab] Update alias.js with direct antd calls.
Mar 2 2024, 13:33
emack planned changes to D15542: [Cashtab] Split out alias pricing validation errors.
Mar 2 2024, 13:32
emack accepted D15606: [mock-chronik-client] Make sure assert rejects is called properly in tests.
Mar 2 2024, 09:33
emack accepted D15607: [Cashtab] Fix bugs in parseChronikTx.
Mar 2 2024, 08:48
emack accepted D15604: [Cashtab] Create and test new wallet creation and validation functions.
Mar 2 2024, 08:25
emack accepted D15608: [Cashtab] Remove references to legacy ticker.
Mar 2 2024, 08:03
emack accepted D15586: [token-server] Initialize a new app to manage rewards tokens.
Mar 2 2024, 07:52

Mar 1 2024

emack requested changes to D15586: [token-server] Initialize a new app to manage rewards tokens.
Mar 1 2024, 12:17
emack accepted D15566: [Cashtab] Move cashtabCache to cashtabState.
Mar 1 2024, 11:48

Feb 29 2024

emack requested changes to D15566: [Cashtab] Move cashtabCache to cashtabState.
  1. I can see the reasoning for getting rid of token ID is because it's not in chronik-client's genesisInfo, but why are the other properties grouped together in index [1]? Isn't it simpler to have them as individual props? Is there a performance/caching consideration here?

image.png (365×473 px, 41 KB)

Feb 29 2024, 12:46
emack accepted D15576: [Cashtab] Standardize price api mocks in test wrappers.
Feb 29 2024, 11:42
emack accepted D15575: [Cashtab] Enable min fee sends for users with 1 million grumpy.

image.png (42×459 px, 1 KB)

This might actually drive up a price market for grump tokens lol

Feb 29 2024, 05:38

Feb 28 2024

emack accepted D15568: [Cashtab] Update tests and patch bug in SendByUrlParams.test.js.
Feb 28 2024, 23:52
emack added inline comments to D15568: [Cashtab] Update tests and patch bug in SendByUrlParams.test.js.
Feb 28 2024, 13:30
emack added inline comments to D15568: [Cashtab] Update tests and patch bug in SendByUrlParams.test.js.
Feb 28 2024, 13:27
emack requested changes to D15568: [Cashtab] Update tests and patch bug in SendByUrlParams.test.js.
Feb 28 2024, 13:26
emack accepted D15564: [Cashtab] Implement standardized test wrappers in Receive.test.js.
Feb 28 2024, 13:12
emack accepted D15572: [Cashtab] Remove obsolete cache dependencies.
Feb 28 2024, 12:57
emack accepted D15567: [Cashtab] Upgrade signverifymsg tests.
Feb 28 2024, 10:26
emack accepted D15565: [Cashtab] Adjust TRIGGER_UTXO_REFRESH_INTERVAL_MS to prevent multiple calls to update.

👍🏼

image.png (44×247 px, 2 KB)

Feb 28 2024, 10:15

Feb 27 2024

emack accepted D15562: [Cashtab] Move settings to new cashtabState.
Feb 27 2024, 21:58
emack requested changes to D15562: [Cashtab] Move settings to new cashtabState.
Feb 27 2024, 21:48
emack accepted D15561: [Cashtab] Remove proptypes from component with no props.
Feb 27 2024, 21:19
emack accepted D15553: [Cashtab] Calculate max send amount in appropriate way using updated ecash-coinselect.
Feb 27 2024, 20:18
emack accepted D15556: [Cashtab] Standardize and improve SendXec.test.js.
Feb 27 2024, 08:07
emack requested changes to D15553: [Cashtab] Calculate max send amount in appropriate way using updated ecash-coinselect.
Feb 27 2024, 07:30
emack accepted D15558: [ecash-coinselect] Remove double defined const.
Feb 27 2024, 07:04
emack closed D15403: [Cashtab] Increase txHistoryCount to 20.
Feb 27 2024, 06:51
emack committed rABC9b6623d0bc1e: [Cashtab] Increase txHistoryCount to 20 (authored by emack).
[Cashtab] Increase txHistoryCount to 20
Feb 27 2024, 06:51
emack updated the diff for D15403: [Cashtab] Increase txHistoryCount to 20.

version bump and rebase

Feb 27 2024, 01:22

Feb 26 2024

emack abandoned D15543: [Cashtab] Temporarily mitigate asyc unit test queries occasionally returning unmounted elements.
Feb 26 2024, 20:22
emack accepted D15541: [Cashtab] Replace address function with equivalent lib function.
Feb 26 2024, 06:03
emack accepted D15540: [Cashtab] Delete all functions, files, and mocks related to legacy tx building.
Feb 26 2024, 03:31
emack added a comment to D15543: [Cashtab] Temporarily mitigate asyc unit test queries occasionally returning unmounted elements.

image.png (300×478 px, 283 KB)

Feb 26 2024, 03:10
emack updated the diff for D15543: [Cashtab] Temporarily mitigate asyc unit test queries occasionally returning unmounted elements.

lint fix

Feb 26 2024, 03:00
emack updated the summary of D15543: [Cashtab] Temporarily mitigate asyc unit test queries occasionally returning unmounted elements.
Feb 26 2024, 02:59
emack requested review of D15543: [Cashtab] Temporarily mitigate asyc unit test queries occasionally returning unmounted elements.
Feb 26 2024, 02:58
emack updated the diff for D15403: [Cashtab] Increase txHistoryCount to 20.

Updated pagesize to 20

Feb 26 2024, 00:35
emack updated the diff for D15542: [Cashtab] Split out alias pricing validation errors.

rebase

Feb 26 2024, 00:01

Feb 25 2024

teamcity awarded D15542: [Cashtab] Split out alias pricing validation errors a Haypence token.
Feb 25 2024, 23:56
emack added a comment to D15542: [Cashtab] Split out alias pricing validation errors.

@bot cashtab-tests

Feb 25 2024, 23:56
emack retitled D15403: [Cashtab] Increase txHistoryCount to 20 from [Cashtab] Increase txHistoryCount to 50 to [Cashtab] Increase txHistoryCount to 20.
Feb 25 2024, 23:55
emack updated the diff for D15403: [Cashtab] Increase txHistoryCount to 20.

Updated txhistorycount to 20

Feb 25 2024, 23:54
emack published D15542: [Cashtab] Split out alias pricing validation errors for review.
Feb 25 2024, 23:46
emack closed D15483: [Cashtab] Improve alias error handling.
Feb 25 2024, 02:53
emack committed rABC229089d71eba: [Cashtab] Improve alias error handling (authored by emack).
[Cashtab] Improve alias error handling
Feb 25 2024, 02:53
emack added a comment to D15483: [Cashtab] Improve alias error handling.

image.png (492×488 px, 202 KB)

Feb 25 2024, 02:52
emack updated the diff for D15483: [Cashtab] Improve alias error handling.

rebase after npm ci

Feb 25 2024, 02:46
emack updated the diff for D15483: [Cashtab] Improve alias error handling.

version bump

Feb 25 2024, 02:30

Feb 24 2024

emack published D15403: [Cashtab] Increase txHistoryCount to 20 for review.
Feb 24 2024, 07:32
emack updated the diff for D15483: [Cashtab] Improve alias error handling.

Combined similar .toHaveTextContent() tests

Feb 24 2024, 07:22
emack added a comment to D15483: [Cashtab] Improve alias error handling.

why does no price trigger aliasValidationError?

Feb 24 2024, 00:34

Feb 23 2024

emack updated the diff for D15483: [Cashtab] Improve alias error handling.

Added integration tests that validates behavior between aliasValidationError and aliasServerError states.

Feb 23 2024, 14:30
emack updated the test plan for D15483: [Cashtab] Improve alias error handling.
Feb 23 2024, 13:15

Feb 22 2024

emack added a comment to D15501: [chronik-client] Support new tokenId endpoints.
Feb 22 2024, 13:37
emack accepted D15515: [Cashtab] Bump jest timeout.

version bump

Feb 22 2024, 13:36
emack accepted D15514: [Cashtab] Pass localforage as a param in cashtab test initializer function.
Feb 22 2024, 13:33

Feb 20 2024

emack closed D15476: [Cashtab] Update incoming txs with direct calls to antd.
Feb 20 2024, 09:17
emack committed rABCf8d0931e35e3: [Cashtab] Update incoming txs with direct calls to antd (authored by emack).
[Cashtab] Update incoming txs with direct calls to antd
Feb 20 2024, 09:17
emack updated the diff for D15476: [Cashtab] Update incoming txs with direct calls to antd.

Rebase, version bump and commenting updates

Feb 20 2024, 08:39
emack accepted D15482: [Cashtab] Improve and standardize CreateToken tests.
Feb 20 2024, 08:19

Feb 19 2024

emack accepted D15480: [Cashtab] Bring QRCode tests in line with rest of react testing lib tests.
Feb 19 2024, 20:35
emack accepted D15419: [Cashtab] Standardize getter and setter functions for db and state.

Great approach, doesn't even need migration logic since it's updating the same key in localforage. I did a manual test and the existing wallet did not lose existing contacts either.

Feb 19 2024, 08:22
emack requested changes to D15482: [Cashtab] Improve and standardize CreateToken tests.
Feb 19 2024, 07:36