Page MenuHomePhabricator
Feed Advanced Search

Yesterday

emack accepted D16043: [Cashtab] Support minting NFTs.

LGTM.
My only other feedback is to have a back button to navigate from the NFT back to the Collection otherwise it's a whole lot of clicks when viewing each NFT, but that can be done as part of the NFT child implementation.
Also the fan out tx seems to cost around 300-500 XEC each tx, incl fees. Should this be mentioned anywhere in case the user fans out a dozen times and is surprised by the cost. (this is in the context of a few people recently even complaining about the 5.5 XEC fee =) )

Thu, Apr 25, 13:31
emack requested changes to D16043: [Cashtab] Support minting NFTs.

After fan out tx, the Mint NFT UI should indicate the total number of NFT mint inputs available. I can see this info is already available on Tx.js, so tracking it here would also be useful.

Thu, Apr 25, 11:52

Wed, Apr 24

emack closed D16047: [Cashtab Extension] Increase height to improve app->extension UX.
Wed, Apr 24, 13:22
emack committed rABC289e2698f0a7: [Cashtab Extension] Increase height to improve app->extension UX (authored by emack).
[Cashtab Extension] Increase height to improve app->extension UX
Wed, Apr 24, 13:22
emack updated the diff for D16047: [Cashtab Extension] Increase height to improve app->extension UX.

version bump

Wed, Apr 24, 13:16
emack added a comment to D16043: [Cashtab] Support minting NFTs.

Per tg chat, here's the trace:

image.png (183×337 px, 21 KB)

hex: 0200000002e6410089e84b4fe22d2baf00b29f1aaf2d45b56a84491fb946aa9fb737d9a2e4010000006b483045022100f1bba9bac4356882f91309fad8ecd7d5303317ad5f7c4345baeee89d6eea222302206f96083beda6b821bcbf164301b2fa390ff3104f1b69d63ce3201d54bc2b0a86412102a607da95600985319cc9009d0970a92161c8b7cd5c8e04ac67e203cd64383600ffffffff34f4135763d899ecaf4a74c349a30d266fd733112178fe1a580a752b22817fa3020000006b483045022100d1879f63ee2974f1edb56335bfd84a67425e1e5b0ca120da02596c31d225ec3102204c175b67bffdfddac5ff66f543fa4315688cf7e962d11c521500d41aa8253dd1412102a607da95600985319cc9009d0970a92161c8b7cd5c8e04ac67e203cd64383600ffffffff150000000000000000d96a04534c500001810453454e4420e4a2d937b79faa46b91f49846ab5452daf1a9fb200af2b2de24f4be8890041e608000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000000108000000000000005122020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac22020000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288acb8120000000000001976a914a8be64f2249615f5abbe216764b386e9c49d9bc288ac00000000

Wed, Apr 24, 13:13
emack updated the diff for D16047: [Cashtab Extension] Increase height to improve app->extension UX.

Move off master branch

Wed, Apr 24, 13:02
emack updated the summary of D16047: [Cashtab Extension] Increase height to improve app->extension UX.
Wed, Apr 24, 12:29
emack requested review of D16047: [Cashtab Extension] Increase height to improve app->extension UX.
Wed, Apr 24, 12:26
emack requested changes to D16043: [Cashtab] Support minting NFTs.

image.png (947×1 px, 320 KB)

Wed, Apr 24, 11:32

Sun, Apr 21

emack accepted D16038: [Cashtab] Stop notifying on every avalanche finalized block.
Sun, Apr 21, 14:40
emack accepted D16037: [Cashtab] Improve OnBoarding component.
Sun, Apr 21, 12:48

Sat, Apr 20

emack accepted D16036: [Cashtab] Show whether token supply is fixed or variable in create token preview modal.
Sat, Apr 20, 15:00
emack accepted D16035: [Cashtab] Improve scrolling and header minification.
Sat, Apr 20, 12:06
emack accepted D16032: [Cashtab] Support for creating NFT Collections.
Sat, Apr 20, 12:05
emack accepted D16033: [token-server] Support creating tokens with icons from locally run cashtab.

image.png (426×490 px, 418 KB)

Sat, Apr 20, 07:57
emack accepted D16031: [Cashtab] Word-break for validation msgs.
Sat, Apr 20, 07:54
emack requested changes to D16035: [Cashtab] Improve scrolling and header minification.

Tested fine, just a nit on code pattern

Sat, Apr 20, 07:51
emack requested changes to D16032: [Cashtab] Support for creating NFT Collections.

The sha256 hash matches all ok.
Is it intended that the collection NFT is rendered in amongst the standard slp1 eTokens with no differentiation? Is this just a staging area until you do the next diff to implement NFTs? That carousel styling would be good, one for each type of token.

Sat, Apr 20, 07:41

Fri, Apr 19

emack accepted D16012: [Cashtab] Searchable, alphabetical token list.
Fri, Apr 19, 08:42
emack accepted D16017: [Cashtab] Fix airdrop tx render issue.
Fri, Apr 19, 01:41

Thu, Apr 18

emack accepted D16014: [Cashtab] Start reward countdown automatically after claiming rewards.

As per tg chat

Thu, Apr 18, 13:09
emack requested changes to D16014: [Cashtab] Start reward countdown automatically after claiming rewards.

The button changes to the timer all ok, and the reward is received all ok as well. However clicking on the received CACHET throws this:

image.png (450×987 px, 95 KB)

Thu, Apr 18, 13:07
emack accepted D16013: [token-server] Use ecash-coinselect from npm.
Thu, Apr 18, 12:41
emack accepted D15997: [Cashtab + token-server + ecash-coinselect] Implement token rewards for Cashtab users.

Accepted post TG chat

Thu, Apr 18, 05:42
emack requested changes to D15997: [Cashtab + token-server + ecash-coinselect] Implement token rewards for Cashtab users.
Thu, Apr 18, 03:08
emack accepted D16011: [Cashtab] Show cursor pointer for extension open in tab button.
Thu, Apr 18, 02:34
emack accepted D16005: [Cashtab] Better validation for token document url.
Thu, Apr 18, 02:22

Wed, Apr 17

emack accepted D16001: [Cashtab] Add unimplemented functions to support NFT minting and sending.
Wed, Apr 17, 14:56
emack accepted D16000: [Cashtab] Better formdata organization in create token form.

accepted with minor nits

Wed, Apr 17, 14:47
emack accepted D16003: [Cashtab] Faster transition for opening and closing hamburger menu.
Wed, Apr 17, 14:35
emack accepted D16002: [Cashtab] Organize styles in own file for Token screen.
Wed, Apr 17, 14:30
emack accepted D15999: [Cashtab] Better organization for create token form.
Wed, Apr 17, 13:16
emack accepted D15998: [Cashtab] Do not render mint switch on token page unless user has mint baton.
Wed, Apr 17, 13:13
emack accepted D15993: [Cashtab] Add functions to build and broadcast NFT1 parent fan-out txs.
Wed, Apr 17, 13:02
emack requested changes to D15993: [Cashtab] Add functions to build and broadcast NFT1 parent fan-out txs.
Wed, Apr 17, 07:09
emack accepted D15996: [explorer] Update README to chronik-native instance.
Wed, Apr 17, 05:28
emack accepted D15995: [Cashtab] Better hamburger menu.
Wed, Apr 17, 05:27
emack accepted D15992: [Cashtab] Change route and component for SendToken to Token.
Wed, Apr 17, 01:58
emack accepted D15987: [Cashtab] Add animation for avalanche finalized txs.
Wed, Apr 17, 01:48

Tue, Apr 16

emack accepted D15981: [Cashtab] Patch minify menu flicker.
Tue, Apr 16, 01:18
emack accepted D15986: [Cashtab] Stop redirecting to /wallet route from cashtab home.
Tue, Apr 16, 01:18
emack accepted D15985: [Cashtab] Do not render reply option to eCash chat.
Tue, Apr 16, 00:31
emack accepted D15984: [Cashtab] Use dust for dust throughout app.
Tue, Apr 16, 00:19
emack added a comment to D15981: [Cashtab] Patch minify menu flicker.

The effects of D15972 seems to have regressed here, allowing scrolling down when there is no content below.

could you show an example?

but also, imo the flickering is much worse than the extra scrolling. The extra scrolling situation still needs another patch anyway to deal with the size of other non-footer elements.

Tue, Apr 16, 00:09
emack accepted D15983: [Cashtab] Update airdrop icon.

Minor nit not for this diff, but should add "XEC" to the Airdrop label, otherwise it looks like it was an eToken airdrop.

Tue, Apr 16, 00:05
emack accepted D15982: [Cashtab] Improve focus-visible for wallet dropdown menu.
Tue, Apr 16, 00:00

Mon, Apr 15

emack accepted D15980: [Cashtab] Add function to generate target outputs for an slpv1 nft parent mint tx.

On a related note, are we sticking with the whole parent vs child terminology all the way through to the frontend? I recall back in 2021 there was discussion on using more user friendly terminology in the frontend, like using "Collection" for parent and "NFT" for child. This way it'll be a smoother experience for users who are used to NFT terminology from other chains.

Mon, Apr 15, 23:55
emack requested changes to D15981: [Cashtab] Patch minify menu flicker.

The effects of D15972 seems to have regressed here, allowing scrolling down when there is no content below.

Mon, Apr 15, 23:50
emack accepted D15967: [Cashtab] Handle multiple token types on token action screen.
Mon, Apr 15, 23:37
emack requested changes to D15967: [Cashtab] Handle multiple token types on token action screen.

Can you send some ALP and NFT parent tokens to ecash:qzz0p9yux89uvgnq86u5qnztver6u7g0vqc65920xr pls? thx.

Mon, Apr 15, 14:25
emack accepted D15973: [Cashtab] Debounce scroll event handler.
Mon, Apr 15, 05:47

Sun, Apr 14

emack accepted D15972: [Cashtab] No scrolling of no content below fold.

It still scrolls, albeit by a negligible 1px or so, across both mobile and web. Not a blocking issue.

Sun, Apr 14, 13:58

Sat, Apr 13

emack accepted D15968: [Cashtab] Add function to get target outputs for NFT1 parent genesis tx.
Sat, Apr 13, 14:12
emack accepted D15971: [Cashtab] Fix svg icons.
Sat, Apr 13, 10:16
emack accepted D15970: [Cashtab] After importing a wallet, automatically close the import wallet modal.
Sat, Apr 13, 10:12
emack requested changes to D15968: [Cashtab] Add function to get target outputs for NFT1 parent genesis tx.
Sat, Apr 13, 10:03
emack accepted D15969: [Cashtab] Get token info from cache in airdrop calc screen.
Sat, Apr 13, 02:31
emack accepted D15947: [Cashtab] Minify and pin wallet header on scroll.
Sat, Apr 13, 00:47

Fri, Apr 12

emack accepted D15958: [Cashtab] Do not specify change address in getSlpGenesisTargetOutput.
Fri, Apr 12, 13:18
emack accepted D15955: [Cashtab] After a token is created, automatically navigate to its actions screen.
Fri, Apr 12, 04:25
emack accepted D15953: [Cashtab] Better switch mgmt in send token.
Fri, Apr 12, 04:23
emack requested changes to D15953: [Cashtab] Better switch mgmt in send token.

This is already the behavior in prod isn't it? Toggling another send token function will disable all others.

Fri, Apr 12, 01:05
emack requested changes to D15955: [Cashtab] After a token is created, automatically navigate to its actions screen.

It's not routing for me as the createdTokenId is always coming up as null in the console logs.

Fri, Apr 12, 01:00
emack accepted D15951: [Cashtab] Standardize svg icon buttons.
Fri, Apr 12, 00:41
emack accepted D15950: [Cashtab] Do not change text color on hover for link button.
Fri, Apr 12, 00:17
emack requested changes to D15947: [Cashtab] Minify and pin wallet header on scroll.

Tested fine on desktop and extension, but on mobile it's got some cray cray clipping happening on the onboarding screen

Fri, Apr 12, 00:12

Thu, Apr 11

emack accepted D15942: [Cashtab] Remove data-testid from everything but Select menus.
Thu, Apr 11, 07:41
emack accepted D15941: [Cashtab] Remove antd pointerevents shim from tests.
Thu, Apr 11, 05:51
emack accepted D15939: [Cashtab] Deprecate the rest of antd.
Thu, Apr 11, 03:19
emack requested changes to D15939: [Cashtab] Deprecate the rest of antd.
Thu, Apr 11, 00:47
emack accepted D15937: [token-server] Add method to get token inputs and outputs for a token reward tx.

Accepted with minor nit on function name.

Thu, Apr 11, 00:19

Wed, Apr 10

emack accepted D15920: [Cashtab] Upgrade tx parsing.

Minor non-blocking nit:
Use the existing shading in prod for the horizonal separator between txs. It's obvious enough to be a separator but not too obvious that it starts adding to the busy-ness of the screen.
Prod

image.png (29×496 px, 625 B)

Wed, Apr 10, 23:43
emack added a comment to D15920: [Cashtab] Upgrade tx parsing.

Also the existing horizontal lines separating each tx should be retained, otherwise each grouping of info is not immediately obvious.

Wed, Apr 10, 11:02
emack requested changes to D15920: [Cashtab] Upgrade tx parsing.
Wed, Apr 10, 10:57

Tue, Apr 9

emack accepted D15925: [Cashtab] Upgrade Aliases screen.
Tue, Apr 9, 03:24
emack requested changes to D15925: [Cashtab] Upgrade Aliases screen.

Since this diff touches on how refreshAliases is called in useWallet, can you patch the bug where right after a registration broadcast the pending alias is not immediately added to the pending aliases list, but navigating away and back to the alias screen fixes it? From a glance one of the useEffect() blocks needs to have a dependency on the aliases.pending map coming out of useWallet, so that once it is added to the pending list it can call refreshAliases.

Tue, Apr 9, 02:37

Mon, Apr 8

emack accepted D15914: [Cashtab] Deprecate antd select from Configure screen.
Mon, Apr 8, 04:59
emack accepted D15917: [Cashtab] Move wallet mgmt to its own screen.
Mon, Apr 8, 04:54

Sun, Apr 7

emack accepted D15919: [Cashtab] Remove unused validation function.
Sun, Apr 7, 10:22
emack accepted D15918: [Cashtab] Add ecash logo as icon for price notifications.
Sun, Apr 7, 10:17
emack requested changes to D15917: [Cashtab] Move wallet mgmt to its own screen.
Sun, Apr 7, 10:03
emack accepted D15915: [Cashtab] Do not show parsed op return raw field if no input.
Sun, Apr 7, 09:10
emack requested changes to D15914: [Cashtab] Deprecate antd select from Configure screen.
Sun, Apr 7, 09:02
emack accepted D15916: [Cashtab] Correct routing for sending to contact.
Sun, Apr 7, 08:56

Sat, Apr 6

emack accepted D15884: [Cashtab] Move contact lists to own screen.

Possibly there is the same address twice in your contact list from testing

That was it

Sat, Apr 6, 22:02
emack accepted D15912: [Cashtab] Show notifications for price milestones.
Sat, Apr 6, 21:06
emack accepted D15909: [Cashtab] Improvements to modal component.
Sat, Apr 6, 09:21
emack requested changes to D15912: [Cashtab] Show notifications for price milestones.

The issue I can see with this feature is the process of killing a zero is never a one off event. You could have the scenario where we go months on end where the price is constantly killing and reviving a zero, which would result in wallets being inundated with these alerts. One mitigation would be to introduce this with a toggle in General Settings, so users who don't mind frequent alerts can explicitly switch it on. And if they get sick of it then have the option of disabling it.

Sat, Apr 6, 07:41
emack requested changes to D15884: [Cashtab] Move contact lists to own screen.

It allows duplicate contact names to be added (with different addresses). If they have a long contact list this might become hard to manage. It's the case in prod as well but if we want to check on unique contact names it might be fine to do it in this diff.

Sat, Apr 6, 07:25

Thu, Apr 4

emack accepted D15889: [Cashtab] Improvements to app handling of new blocks.

image.png (112×350 px, 10 KB)

Thu, Apr 4, 23:52
emack accepted D15886: [Cashtab] Support locale display for locales with no thousands separator.
Thu, Apr 4, 12:13
emack accepted D15883: [Cashtab] Use cursor not-allowed when select menu is disabled.
Thu, Apr 4, 05:48
emack accepted D15869: [ecash-herald] Add a countdown for the eCash halving.
Thu, Apr 4, 05:42
emack accepted D15866: [Cashtab] Patch proptypes issues.
Thu, Apr 4, 05:37
emack accepted D15874: [Cashtab] Add op return raw field to send xec screen.

Manual op_return raw input works well

image.png (586×532 px, 57 KB)

Thu, Apr 4, 05:22
emack accepted D15867: [Cashtab] Move seed phrase to dedicated wallet backup screen.
Thu, Apr 4, 04:50
emack requested changes to D15866: [Cashtab] Patch proptypes issues.

TokenListItem isn't liking this

image.png (643×361 px, 87 KB)

Thu, Apr 4, 04:38

Wed, Apr 3

emack accepted D15865: [Cashtab] Move App to components/App and remove lingering relative imports.
Wed, Apr 3, 06:35
emack accepted D15864: [Cashtab] Deprecate hooks directory and move hooks to where they are used.
Wed, Apr 3, 04:58