Page MenuHomePhabricator
Feed Advanced Search

Apr 3 2024

emack accepted D15863: [Cashtab] Improve switches on Configure screen.
Apr 3 2024, 01:29
emack accepted D15862: [Cashtab] Improvements to send to many switch.
Apr 3 2024, 01:19
emack accepted D15847: [Cashtab] Add circulating supply to token stats.
Apr 3 2024, 00:00

Apr 2 2024

emack added a comment to D15847: [Cashtab] Add circulating supply to token stats.
  • Unit tested helper function to get circulating supply
  • Unit tested helper function to get (net) burn or mint
  • Implement functions
  • Clean up rendering (spinner instead of "Loading..." ?)
Apr 2 2024, 23:16
emack accepted D15844: [Cashtab] Improve UX for sending cashtab msg.
Apr 2 2024, 23:06
emack accepted D15846: [Cashtab] Revamp UX and remove antd from SignVerifyMsg.
Apr 2 2024, 08:09
emack requested changes to D15844: [Cashtab] Improve UX for sending cashtab msg.

Now if you enter in an invalid message (i.e. over length limit), then close the message toggle, the Send button is disabled even though theoretically it should be sending the tx without the message.

Apr 2 2024, 07:42
emack requested changes to D15846: [Cashtab] Revamp UX and remove antd from SignVerifyMsg.
Apr 2 2024, 02:21
emack requested changes to D15844: [Cashtab] Improve UX for sending cashtab msg.

Is the following expected behavior?

  1. fill in valid address, amount and message
  2. close the message toggle indicating the user has changed their mind about sending this with a message
  3. click send and observe on the explorer that the message was sent anyway
Apr 2 2024, 01:53
emack accepted D15845: [Cashtab] Patch bug in disable send logic.
Apr 2 2024, 01:40

Apr 1 2024

emack accepted D15837: [Cashtab] Parse mint txs.

As per tg chat

Apr 1 2024, 13:54
emack accepted D15840: [Cashtab] Keep upgrade modal title from overflow breaking onto next line.
Apr 1 2024, 07:09
emack accepted D15839: [token-server] Remove debug logs.
Apr 1 2024, 07:06
emack requested changes to D15837: [Cashtab] Parse mint txs.

This is the same in master.

Apr 1 2024, 07:05
emack requested changes to D15837: [Cashtab] Parse mint txs.

I'm getting little squares where there would have been -0 XECs. Is this a font thing?

image.png (517×550 px, 73 KB)

Apr 1 2024, 02:38
emack accepted D15835: [Cashtab] Add some clarifying comments on the confusing use of BN in slpv1 tx building.
Apr 1 2024, 02:26
emack accepted D15834: [Cashtab] use correct validation for max genesis token amounts.
Apr 1 2024, 02:24
emack accepted D15833: [token-server] Test patch for tg admin bot msgs.
Apr 1 2024, 02:02

Mar 31 2024

emack accepted D15832: [token-server] Add debug log for troubleshooting admin token bot.
Mar 31 2024, 13:54
emack planned changes to D15831: [Cashtab Extension] New API to share contacts with external web apps.
Mar 31 2024, 13:27
emack accepted D15829: [Cashtab] Support slpv1 mint txs.
Mar 31 2024, 13:26
emack requested changes to D15829: [Cashtab] Support slpv1 mint txs.
Mar 31 2024, 13:16
emack accepted D15830: [Cashtab] Better display of seed phrase.
Mar 31 2024, 12:53
emack updated the test plan for D15831: [Cashtab Extension] New API to share contacts with external web apps.
Mar 31 2024, 12:37
emack requested review of D15831: [Cashtab Extension] New API to share contacts with external web apps.
Mar 31 2024, 12:36
emack accepted D15826: [Cashtab] Better validation functions for token send or burn amounts.

Subject to some material rebases

Mar 31 2024, 00:40
emack accepted D15821: [Cashtab] Standardize padding and wrapping of app components.

subject to rebasing to latest changes to txHistory parsing and sendToken UI

Mar 31 2024, 00:27

Mar 30 2024

emack accepted D15819: [Cashtab] Improve UI for SendToken screen.
Mar 30 2024, 23:55
emack closed D15822: [Cashtab] Parse eCash Chat prefixed messages.
Mar 30 2024, 23:27
emack committed rABCa1c959a43f10: [Cashtab] Parse eCash Chat prefixed messages (authored by emack).
[Cashtab] Parse eCash Chat prefixed messages
Mar 30 2024, 23:27
emack updated the diff for D15822: [Cashtab] Parse eCash Chat prefixed messages.

version bump and rebase

Mar 30 2024, 23:22
emack accepted D15823: [Cashtab] Patch - cleanup rebase miss.
Mar 30 2024, 14:48
emack accepted D15806: [token-server] Initialize wallet methods.
Mar 30 2024, 14:32
emack accepted D15816: [Cashtab] Patch send to many with improved validation.
Mar 30 2024, 14:29
emack updated the test plan for D15822: [Cashtab] Parse eCash Chat prefixed messages.
Mar 30 2024, 10:11
emack requested review of D15822: [Cashtab] Parse eCash Chat prefixed messages.
Mar 30 2024, 10:11
emack accepted D15820: [Cashtab] Support slpv1 genesis txs for mint batons.
Mar 30 2024, 08:16
emack requested changes to D15819: [Cashtab] Improve UI for SendToken screen.

How do you feel about using a carousel type UI to browse through the list of tokens? It's something that NFT wallets in ethereum uses to great effect because the UI size is ringfenced regardless of how many tokens you have.

Mar 30 2024, 08:05
emack accepted D15818: [Cashtab] Remove unused hook files.
Mar 30 2024, 07:37
emack accepted D15810: [Cashtab] Replace all console.log statements with error or info and remove debug logs.

grep -r console.log src/ -- still a few left, but they are removed in D15804

Still seeing two remaining in useImage even though D15804 has since landed

image.png (45×572 px, 12 KB)

Mar 30 2024, 07:30
emack requested changes to D15810: [Cashtab] Replace all console.log statements with error or info and remove debug logs.

grep -r console.log src/ -- still a few left, but they are removed in D15804

Mar 30 2024, 07:25
emack requested changes to D15816: [Cashtab] Patch send to many with improved validation.

It current enables the Send button when the aggregate send amount is exactly the same as the wallet balance, which shouldn't be the case because then there wouldn't be enough to pay for the txFee.

image.png (489×535 px, 56 KB)

Mar 30 2024, 07:19
emack requested changes to D15806: [token-server] Initialize wallet methods.
Mar 30 2024, 06:57
emack accepted D15817: [token-server] Remove unnecessary assertion from unit test file.
Mar 30 2024, 06:27

Mar 29 2024

emack accepted D15783: [Cashtab] Build custom switch to deprecate antd switch.
Mar 29 2024, 22:21
emack requested changes to D15783: [Cashtab] Build custom switch to deprecate antd switch.

The switches on the airdrop screen are too large relative to the rest of the UI, should resize to match the ones on config

image.png (477×514 px, 40 KB)

Mar 29 2024, 14:04
emack accepted D15804: [Cashtab] Remove legacy antd form components from CreateTokenForm.

Accepted, assuming the overall UI here will be improved separately.

Mar 29 2024, 13:31
emack accepted D15784: [Cashtab] Improve and standardize cashtab token cache.
Mar 29 2024, 13:29
emack added a comment to D15804: [Cashtab] Remove legacy antd form components from CreateTokenForm.

Testing in incognito solved the issue above, however now when creating a new token with an icon, getting the following:

image.png (548×601 px, 112 KB)

image.png (93×324 px, 8 KB)

The token is created regardless.

Based on my previous reviews of the token server I think this is due to the icon being over 500kb? The test png I used was 2mb. In which case the size error here should be clearer to the user so they can adjust it themselves.

Edit: nvm, tested it with a 114kb png and it's still getting rejected as well with the same message and console logs.

is this from localhost:3000 ? could be the whitelist at token server

will check it out

Mar 29 2024, 13:07
emack requested changes to D15804: [Cashtab] Remove legacy antd form components from CreateTokenForm.

Testing in incognito solved the issue above, however now when creating a new token with an icon, getting the following:

Mar 29 2024, 12:57
emack requested changes to D15784: [Cashtab] Improve and standardize cashtab token cache.

Burning the remaining balance of an eToken results in a blank page rather than being routed back to the token list view (as per master/prod).

image.png (879×1 px, 136 KB)

Mar 29 2024, 12:38
emack requested changes to D15784: [Cashtab] Improve and standardize cashtab token cache.
Mar 29 2024, 11:53
emack requested changes to D15783: [Cashtab] Build custom switch to deprecate antd switch.

Same issue upon startup as D15804, however for reference D15748 loads fine without this issue.

Mar 29 2024, 11:45
emack requested changes to D15804: [Cashtab] Remove legacy antd form components from CreateTokenForm.

Getting this uncaught exception upon startup. This is after npm ci.

Mar 29 2024, 11:27
emack requested changes to D15784: [Cashtab] Improve and standardize cashtab token cache.

Now consistently getting this uncaught exception upon the creation of a new token, line 593 of useWallet didn't seem to have an obvious cause for this.

image.png (909×881 px, 202 KB)

Mar 29 2024, 10:33

Mar 28 2024

emack requested changes to D15784: [Cashtab] Improve and standardize cashtab token cache.
Mar 28 2024, 12:36

Mar 27 2024

emack accepted D15794: [mock-chronik-client] Support history() calls without pageNumber and pageSize specified.
Mar 27 2024, 22:51

Mar 26 2024

emack accepted D15776: [Cashtab] Implement custom Input elements in Send, SendToken, and Configure.
Mar 26 2024, 14:18
emack requested changes to D15776: [Cashtab] Implement custom Input elements in Send, SendToken, and Configure.

computer says no

Mar 26 2024, 06:42
emack requested changes to D15776: [Cashtab] Implement custom Input elements in Send, SendToken, and Configure.

Error workflow:

  1. Open Send and observe the camera auto opens as expected (since the config toggle is true)
  2. Toggle the auto open camera config to false
  3. Open Send and observe camera does not auto open
  4. Toggle the auto open camera config to true
  5. Open Send and the camera does not auto open again
  6. Despite refreshing app a few times, camera still does not auto open with the config set to true.
Mar 26 2024, 02:14

Mar 25 2024

emack accepted D15774: [Cashtab] Autosize the wallet select based on text width.
Mar 25 2024, 04:22
emack requested changes to D15774: [Cashtab] Autosize the wallet select based on text width.

Tested ok, just a minor nit in function comments

Mar 25 2024, 00:02

Mar 24 2024

emack accepted D15773: [Cashtab] Use latest chronik-client.
Mar 24 2024, 23:54
emack accepted D15772: [Cashtab] Better error handling for rendering txs.
Mar 24 2024, 23:28
emack requested changes to D15772: [Cashtab] Better error handling for rendering txs.
Mar 24 2024, 13:27
emack accepted D15769: [Cashtab] Replace antd notifications and pop-up modals with react-toastify.
Mar 24 2024, 13:23
emack accepted D15771: [chronik-client] Add timeout failure to ws connections.
Mar 24 2024, 13:20
emack accepted D15770: [Cashtab] Clean up upgrade modal component.
Mar 24 2024, 02:21
emack requested changes to D15771: [chronik-client] Add timeout failure to ws connections.
Mar 24 2024, 02:12
emack requested changes to D15769: [Cashtab] Replace antd notifications and pop-up modals with react-toastify.

It's not immediately clear whether each notification is an error, success or warning message at a quick glance. I would suggest using either a green tick/red cross/yellow exclamation mark to accompany each notification (via the icon prop) or customize the background color depending on the nature of the message. White text on black bg can be interpreted in different ways.

Mar 24 2024, 02:05

Mar 23 2024

emack accepted D15766: [Cashtab] Use in-node chronik to calculate airdrops.
Mar 23 2024, 09:46

Mar 22 2024

emack accepted D15764: [Cashtab] Change wallet from dropdown menu in header.

Much better

Mar 22 2024, 23:49
emack requested changes to D15766: [Cashtab] Use in-node chronik to calculate airdrops.

Error workflow:

  1. 100 XEC airdrop for 1c6c9c64d70b285befe733f175d0f384538576876bd280b10587df81279d3f5e, which should give you the following:

image.png (149×466 px, 20 KB)

Mar 22 2024, 23:44
emack requested changes to D15764: [Cashtab] Change wallet from dropdown menu in header.

Tested all ok but it looks really out of place with the thick border

image.png (200×290 px, 12 KB)

Mar 22 2024, 14:09

Mar 21 2024

emack accepted D15711: [Cashtab] Render onboarding screen if user does not have a wallet.
Mar 21 2024, 10:56
emack accepted D15744: [token-server] Accept uploaded token icons.
Mar 21 2024, 03:50
emack requested changes to D15711: [Cashtab] Render onboarding screen if user does not have a wallet.

I'm seeing a perma-lock on incognito mode (which has no existing wallet in storage).

  • No errors in console.
  • Already tried npm ci.
  • Reloaded and hard-refreshed multiple times.

Likely the cashtabLoaded state var isn't being set in the onboarding process?

Mar 21 2024, 01:27
emack requested changes to D15744: [token-server] Accept uploaded token icons.

I'll ping you on tg to whitelist my IP. Given the changes it would be good if I can manually test the token creation process in case there's something not obvious to the int tests coverage.

image.png (246×359 px, 39 KB)

Mar 21 2024, 00:51

Mar 19 2024

emack accepted D15729: [Cashtab] Handle unknown tokens.
Mar 19 2024, 09:59
emack accepted D15728: [Cashtab] Update ws onmessage handler so latest cashtabState is always available.
Mar 19 2024, 07:14
emack added a comment to D15728: [Cashtab] Update ws onmessage handler so latest cashtabState is always available.

image.png (130×1 px, 24 KB)

Starting to see 120,000 ms being exceeded

Mar 19 2024, 07:03
emack accepted D15731: [Cashtab] Default chronik server to ABC instance.
Mar 19 2024, 06:51
emack added a comment to D15729: [Cashtab] Handle unknown tokens.

Is there a difference between an unknown token vs an invalid token that does not conform to SLPv1 or ALP standards?

Mar 19 2024, 06:30
emack accepted D15701: [Cashtab] Build our own modal to stop using antd.
Mar 19 2024, 06:26
emack closed D15672: [standards] Reserve op_return prefix for eCash Chat platform.
Mar 19 2024, 06:24
emack committed rABCcf4c60913dd3: [standards] Reserve op_return prefix for eCash Chat platform (authored by emack).
[standards] Reserve op_return prefix for eCash Chat platform
Mar 19 2024, 06:24

Mar 16 2024

emack retitled D15672: [standards] Reserve op_return prefix for eCash Chat platform from [standards] Reserve op_return prefix for eCash Social platform to [standards] Reserve op_return prefix for eCash Chat platform.
Mar 16 2024, 12:30
emack updated the diff for D15672: [standards] Reserve op_return prefix for eCash Chat platform.

Updated prefix reservation

Mar 16 2024, 12:30
emack requested changes to D15701: [Cashtab] Build our own modal to stop using antd.
Mar 16 2024, 09:47
emack added a comment to D15701: [Cashtab] Build our own modal to stop using antd.

If you toggle Send Confirmations in config to true, then send a normal XEC tx, that setting resets to false after tx broadcast.

Mar 16 2024, 09:45
emack accepted D15710: [Cashtab] Patch improper useNavigate usage.
Mar 16 2024, 09:26
emack accepted D15693: [Cashtab] Use in-node chronik.
Mar 16 2024, 08:40

Mar 15 2024

emack accepted D15703: [Cashtab] Clean up how fiat price for min token creation is displayed.
Mar 15 2024, 11:02
emack requested changes to D15693: [Cashtab] Use in-node chronik.

Edge case: Send a token tx where you're sending the entire remaining token balance so that it needs to automatically route out of the SendToken.js and back to Home. The following bad state use warning is shown:

image.png (337×354 px, 48 KB)

Mar 15 2024, 10:46

Mar 13 2024

emack accepted D15679: [Cashtab] Improve Cashtab wallet shape.
Mar 13 2024, 12:22
emack accepted D15684: [Cashtab] Create custom modal for version upgrades.
Mar 13 2024, 12:19
emack requested changes to D15679: [Cashtab] Improve Cashtab wallet shape.
Mar 13 2024, 11:51
emack requested changes to D15684: [Cashtab] Create custom modal for version upgrades.

So my steps were:

  1. Deploy v2.0.10 to netlify
  2. Create new wallet on there
  3. Bump version to v2.0.11, then redeploy to netlify
  4. Waited around with the wallet open but no modal.
  5. Closed and re-opened browser, upgrade modal shows up on load
  6. Click OK, cashtab refreshes but Configure.js is still showing v2.0.10
  7. Hard refresh browser, cashtab now shows v2.0.11
Mar 13 2024, 08:48
emack accepted D15689: [Cashtab] Remove parenthesis around buttons.
Mar 13 2024, 08:30
emack accepted D15678: [token-server] Add endpoint to check address eligiblity for token rewards.
Mar 13 2024, 08:27