Page MenuHomePhabricator
Feed All Stories

Jun 1 2023

PiRK committed rABC8f8e1faca1f0: depends: Split boost into build/host packages + bump + cleanup (authored by Carl Dong <contact@carldong.me>).
depends: Split boost into build/host packages + bump + cleanup
Jun 1 2023, 20:53
PiRK committed rABC19b8259059e6: build: use a static .tiff for macOS .dmg rather than generating (authored by PiRK).
build: use a static .tiff for macOS .dmg rather than generating
Jun 1 2023, 20:51
PiRK closed D13957: build: use a static .tiff for macOS .dmg rather than generating.
Jun 1 2023, 20:51
PiRK closed D13956: build: mac deployment unification.
Jun 1 2023, 20:51
PiRK committed rABC13056d3c0ea7: build: mac deployment unification (authored by fanquake <fanquake@gmail.com>).
build: mac deployment unification
Jun 1 2023, 20:51
Fabien accepted D13966: refactor: use std::shared_mutex & remove Boost Thread.
Jun 1 2023, 19:28
teamcity awarded D13966: refactor: use std::shared_mutex & remove Boost Thread a Piece of Eight token.
Jun 1 2023, 19:17
Fabien added a comment to D13966: refactor: use std::shared_mutex & remove Boost Thread.

@bot build-linux64

Jun 1 2023, 19:17
Fabien accepted D13963: depends: Split boost into build/host packages + bump + cleanup.
Jun 1 2023, 19:17
teamcity awarded D13963: depends: Split boost into build/host packages + bump + cleanup a Like token.
Jun 1 2023, 18:47
Fabien added a comment to D13963: depends: Split boost into build/host packages + bump + cleanup.

@bot build-linux64

Jun 1 2023, 18:47
Fabien requested changes to D13964: [alias-server] push parsing for op return.

You're missing a test for the case the pushdata length doesn't match the operator, like my previous example 4d42 (aka PUSHDATA2 42)

Jun 1 2023, 18:45
teamcity triaged T3179: Build Bitcoin-ABC / Master / Coverage is broken. as Unbreak Now! priority.
Jun 1 2023, 18:01
bytesofman updated the diff for D13964: [alias-server] push parsing for op return.

Responding to feedback (better comments, remove 6a from unit test mocks)

Jun 1 2023, 17:55
teamcity closed T3178: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Resolved.
Jun 1 2023, 17:02
Fabien requested changes to D13964: [alias-server] push parsing for op return.
Jun 1 2023, 17:01
Fabien closed D13967: Remove mempool tx package limits.
Jun 1 2023, 16:45
Fabien committed rABCe9aae6bb4e04: Remove mempool tx package limits (authored by Fabien).
Remove mempool tx package limits
Jun 1 2023, 16:45
bytesofman added inline comments to D13964: [alias-server] push parsing for op return.
Jun 1 2023, 16:27
bytesofman added inline comments to D13964: [alias-server] push parsing for op return.
Jun 1 2023, 16:25
bytesofman updated the diff for D13964: [alias-server] push parsing for op return.

Responding to feedback

Jun 1 2023, 16:25
PiRK published D13966: refactor: use std::shared_mutex & remove Boost Thread for review.
Jun 1 2023, 16:23
teamcity awarded D13956: build: mac deployment unification a Like token.
Jun 1 2023, 16:22
PiRK added a comment to D13956: build: mac deployment unification.

@bot gitian-osx

Jun 1 2023, 16:22
PiRK updated the diff for D13956: build: mac deployment unification.

fix wrong name for BitcoinABC-Qt.app

Jun 1 2023, 16:19
teamcity closed T3177: Build Bitcoin-ABC / Master / Sanitizers / Undefined Behavior Sanitizer (UBSAN) is broken. as Resolved.
Jun 1 2023, 16:14
teamcity triaged T3178: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
Jun 1 2023, 16:04
PiRK planned changes to D13962: misc updates security-check and symbol-check.
Jun 1 2023, 15:58
teamcity added a comment to D13962: misc updates security-check and symbol-check.
Jun 1 2023, 15:50
bytesofman closed D13961: [herald] Improved miner parsing.
Jun 1 2023, 15:48
bytesofman committed rABCd637f245a649: [herald] Improved miner parsing (authored by bytesofman).
[herald] Improved miner parsing
Jun 1 2023, 15:48
PiRK accepted D13967: Remove mempool tx package limits.
Jun 1 2023, 15:22
Fabien requested review of D13967: Remove mempool tx package limits.
Jun 1 2023, 15:20
PiRK updated the summary of D13962: misc updates security-check and symbol-check.
Jun 1 2023, 15:20
teamcity awarded D13962: misc updates security-check and symbol-check a Piece of Eight token.
Jun 1 2023, 15:19
PiRK added a comment to D13962: misc updates security-check and symbol-check.

@bot gitian-osx

Jun 1 2023, 15:19
PiRK updated the diff for D13962: misc updates security-check and symbol-check.

rebase onto D13963

Jun 1 2023, 15:19
teamcity awarded D13966: refactor: use std::shared_mutex & remove Boost Thread a Haypence token.
Jun 1 2023, 15:08
teamcity awarded D13963: depends: Split boost into build/host packages + bump + cleanup a Love token.
Jun 1 2023, 14:56
PiRK added a comment to D13963: depends: Split boost into build/host packages + bump + cleanup.

@bot gitian-osx gitian-win gitian-linux

Jun 1 2023, 14:56
PiRK updated the diff for D13963: depends: Split boost into build/host packages + bump + cleanup.

set(Boost_USE_STATIC_LIBS ON)

Jun 1 2023, 14:54
teamcity added a comment to D13963: depends: Split boost into build/host packages + bump + cleanup.
Jun 1 2023, 13:59
PiRK planned changes to D13963: depends: Split boost into build/host packages + bump + cleanup.

Need to update CMakeLists.txt

Jun 1 2023, 13:47
teamcity added a comment to D13963: depends: Split boost into build/host packages + bump + cleanup.
Jun 1 2023, 13:43
teamcity awarded D13963: depends: Split boost into build/host packages + bump + cleanup a Like token.
Jun 1 2023, 13:42
PiRK added a comment to D13963: depends: Split boost into build/host packages + bump + cleanup.

@bot gitian-win gitian-osx

Jun 1 2023, 13:42
Fabien accepted D13965: [alias-server] Remove debug logging.
Jun 1 2023, 13:27
Fabien requested changes to D13964: [alias-server] push parsing for op return.
Jun 1 2023, 13:26
PiRK added inline comments to D13963: depends: Split boost into build/host packages + bump + cleanup.
Jun 1 2023, 13:10
teamcity awarded D13963: depends: Split boost into build/host packages + bump + cleanup a Mountain of Wealth token.
Jun 1 2023, 13:08
PiRK added a comment to D13963: depends: Split boost into build/host packages + bump + cleanup.

@bot gitian-linux

Jun 1 2023, 13:08
PiRK updated the diff for D13963: depends: Split boost into build/host packages + bump + cleanup.

hardcode boost package name in boost_file_name, because native_b2.mk refers to $(package)_download_path=$(boost_download_path) and we don't want it to substitute $package with it's own package name

Jun 1 2023, 13:07
Fabien accepted D13961: [herald] Improved miner parsing.
Jun 1 2023, 12:56
bytesofman requested review of D13965: [alias-server] Remove debug logging.
Jun 1 2023, 12:55
bytesofman requested review of D13964: [alias-server] push parsing for op return.
Jun 1 2023, 12:54
PiRK planned changes to D13963: depends: Split boost into build/host packages + bump + cleanup.
Jun 1 2023, 12:32
teamcity added a comment to D13963: depends: Split boost into build/host packages + bump + cleanup.
Jun 1 2023, 12:13
teamcity added a comment to D13963: depends: Split boost into build/host packages + bump + cleanup.
Jun 1 2023, 12:13
teamcity added a comment to D13963: depends: Split boost into build/host packages + bump + cleanup.
Jun 1 2023, 12:13
teamcity awarded D13963: depends: Split boost into build/host packages + bump + cleanup a Doubloon token.
Jun 1 2023, 12:11
PiRK added a comment to D13963: depends: Split boost into build/host packages + bump + cleanup.

@bot gitian-osx gitian-linux gitian-win

Jun 1 2023, 12:11
PiRK updated the diff for D13963: depends: Split boost into build/host packages + bump + cleanup.

squash with core#21662 for a download link that works

Jun 1 2023, 12:11
teamcity added a comment to D13963: depends: Split boost into build/host packages + bump + cleanup.
Jun 1 2023, 12:10
teamcity added a comment to D13963: depends: Split boost into build/host packages + bump + cleanup.
Jun 1 2023, 12:09
teamcity added a comment to D13963: depends: Split boost into build/host packages + bump + cleanup.
Jun 1 2023, 12:07
teamcity added a comment to D13963: depends: Split boost into build/host packages + bump + cleanup.
Jun 1 2023, 12:05
teamcity awarded D13963: depends: Split boost into build/host packages + bump + cleanup a Piece of Eight token.
Jun 1 2023, 12:05
PiRK added a comment to D13963: depends: Split boost into build/host packages + bump + cleanup.

@bot gitian-osx gitian-linux gitian-win

Jun 1 2023, 12:05
teamcity awarded D13963: depends: Split boost into build/host packages + bump + cleanup a Haypence token.
Jun 1 2023, 12:03
PiRK added a comment to D13963: depends: Split boost into build/host packages + bump + cleanup.

@bot gitian-osx gitian-linux gitian-win

Jun 1 2023, 12:03
teamcity updated the summary of D13963: depends: Split boost into build/host packages + bump + cleanup.
Jun 1 2023, 12:01
PiRK requested review of D13963: depends: Split boost into build/host packages + bump + cleanup.
Jun 1 2023, 12:01
teamcity triaged T3177: Build Bitcoin-ABC / Master / Sanitizers / Undefined Behavior Sanitizer (UBSAN) is broken. as Unbreak Now! priority.
Jun 1 2023, 11:51
bytesofman added inline comments to D13961: [herald] Improved miner parsing.
Jun 1 2023, 11:40
bytesofman closed D13960: [alias-server] add consume function in new script parsing file.
Jun 1 2023, 11:36
bytesofman committed rABC28c0a2034c43: [alias-server] add consume function in new script parsing file (authored by bytesofman).
[alias-server] add consume function in new script parsing file
Jun 1 2023, 11:36
PiRK planned changes to D13962: misc updates security-check and symbol-check.
Jun 1 2023, 11:33
teamcity added a comment to D13962: misc updates security-check and symbol-check.
Jun 1 2023, 10:54
teamcity awarded D13962: misc updates security-check and symbol-check a Haypence token.
Jun 1 2023, 10:22
PiRK added a comment to D13962: misc updates security-check and symbol-check.

@bot gitian-osx

Jun 1 2023, 10:22
PiRK updated the summary of D13962: misc updates security-check and symbol-check.
Jun 1 2023, 10:20
teamcity updated the summary of D13962: misc updates security-check and symbol-check.
Jun 1 2023, 10:19
PiRK requested review of D13962: misc updates security-check and symbol-check.
Jun 1 2023, 10:19
Fabien added inline comments to D13961: [herald] Improved miner parsing.
Jun 1 2023, 07:31
Fabien accepted D13960: [alias-server] add consume function in new script parsing file.
Jun 1 2023, 07:27
teamcity awarded D13956: build: mac deployment unification a Love token.
Jun 1 2023, 07:15
PiRK added a comment to D13956: build: mac deployment unification.

@bot gitian-osx

Jun 1 2023, 07:15
abc-bot committed rABC05cd52151373: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Jun 1 2023, 03:37
abc-bot committed rABC275998e6ffb0: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Jun 1 2023, 02:18
abc-bot committed rABC5cd25b29fbdb: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Jun 1 2023, 02:08

May 31 2023

bytesofman updated the diff for D13961: [herald] Improved miner parsing.

responding to feedback

May 31 2023, 17:54
bytesofman updated the diff for D13960: [alias-server] add consume function in new script parsing file.

Responding to feedback and improving input validation

May 31 2023, 17:20
Fabien accepted D13956: build: mac deployment unification.
May 31 2023, 16:09
teamcity awarded D13957: build: use a static .tiff for macOS .dmg rather than generating a Piece of Eight token.
May 31 2023, 15:40
PiRK added a comment to D13957: build: use a static .tiff for macOS .dmg rather than generating.

@bot build-osx gitian-osx

May 31 2023, 15:40
PiRK updated the diff for D13957: build: use a static .tiff for macOS .dmg rather than generating.

rebase

May 31 2023, 15:35
PiRK updated the diff for D13956: build: mac deployment unification.

squash with PR20333. There is not much overlap between the 2 changesets; o it will not make the review even harder.

May 31 2023, 15:34
Fabien accepted D13957: build: use a static .tiff for macOS .dmg rather than generating.
May 31 2023, 15:26
PiRK planned changes to D13956: build: mac deployment unification.

Not yet. This needs to be squashed with or rebased onto https://github.com/bitcoin/bitcoin/pull/20333

May 31 2023, 15:23
Fabien accepted D13956: build: mac deployment unification.
May 31 2023, 15:23