Page MenuHomePhabricator
People PiRK

PiRK (Pierre K)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 5 2020, 16:14 (277 w, 4 d)

Recent Activity
View All

Fri, Nov 28

PiRK accepted D19008: [e.cash] Add Marlin Wallet.
Fri, Nov 28, 17:03
PiRK committed rABCffa758b1dc48: refactor: Avoid UB in SHA3_256::Write (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
refactor: Avoid UB in SHA3_256::Write
Fri, Nov 28, 16:48
PiRK closed D19005: refactor: Avoid UB in SHA3_256::Write.
Fri, Nov 28, 16:48
PiRK closed D19004: Reduce cache lookups in CCoinsViewCache::FetchCoin.
Fri, Nov 28, 16:48
PiRK committed rABCbf2683f2509c: Reduce cache lookups in CCoinsViewCache::FetchCoin (authored by Lőrinc <pap.lorinc@gmail.com>).
Reduce cache lookups in CCoinsViewCache::FetchCoin
Fri, Nov 28, 16:48
PiRK closed D19006: [electrum] fix context menu in Contacts tab.
Fri, Nov 28, 16:47
PiRK committed rABC317043f74951: [electrum] fix context menu in Contacts tab (authored by PiRK).
[electrum] fix context menu in Contacts tab
Fri, Nov 28, 16:47
PiRK requested review of D19006: [electrum] fix context menu in Contacts tab.
Fri, Nov 28, 14:14
PiRK requested review of D19005: refactor: Avoid UB in SHA3_256::Write.
Fri, Nov 28, 12:25
PiRK requested review of D19004: Reduce cache lookups in CCoinsViewCache::FetchCoin.
Fri, Nov 28, 12:14

Thu, Nov 27

PiRK committed rABC54d2ecc63be5: [electrum] appimage: bump appimagetool to new version/repo (authored by SomberNight <somber.night@protonmail.com>).
[electrum] appimage: bump appimagetool to new version/repo
Thu, Nov 27, 11:27
PiRK closed D19002: [electrum] appimage: bump appimagetool to new version/repo.
Thu, Nov 27, 11:27
PiRK closed D19001: [electrum] unbreak the appimage build (new transitive dependency required newer version of Cargo).
Thu, Nov 27, 11:27
PiRK committed rABC3fe6881805a0: [electrum] unbreak the appimage build (new transitive dependency required newer… (authored by PiRK).
[electrum] unbreak the appimage build (new transitive dependency required newer…
Thu, Nov 27, 11:27

Wed, Nov 26

PiRK retitled D19002: [electrum] appimage: bump appimagetool to new version/repo from appimage: bump appimagetool to new version/repo to [electrum] appimage: bump appimagetool to new version/repo.
Wed, Nov 26, 16:11
PiRK retitled D19001: [electrum] unbreak the appimage build (new transitive dependency required newer version of Cargo) from [electrum] unbreak the appimage build to [electrum] unbreak the appimage build (new transitive dependency required newer version of Cargo).
Wed, Nov 26, 16:09
PiRK published D19002: [electrum] appimage: bump appimagetool to new version/repo for review.
Wed, Nov 26, 16:09
PiRK updated the test plan for D19001: [electrum] unbreak the appimage build (new transitive dependency required newer version of Cargo).
Wed, Nov 26, 16:04
PiRK updated the summary of D19001: [electrum] unbreak the appimage build (new transitive dependency required newer version of Cargo).
Wed, Nov 26, 15:54
PiRK updated the summary of D19001: [electrum] unbreak the appimage build (new transitive dependency required newer version of Cargo).
Wed, Nov 26, 15:52
PiRK requested review of D19001: [electrum] unbreak the appimage build (new transitive dependency required newer version of Cargo).
Wed, Nov 26, 15:51
PiRK closed D18999: [electrum] bump version to 5.4.3 and add release notes.
Wed, Nov 26, 09:25
PiRK committed rABCf16ea9329549: [electrum] bump version to 5.4.3 and add release notes (authored by PiRK).
[electrum] bump version to 5.4.3 and add release notes
Wed, Nov 26, 09:25

Tue, Nov 25

PiRK accepted D18998: [avalanche] Reduce the logs verbosity.
Tue, Nov 25, 16:30
PiRK requested review of D18999: [electrum] bump version to 5.4.3 and add release notes.
Tue, Nov 25, 15:46
PiRK committed rABC7dfbd230ab82: [electrum] enable sorting when selecting utxos for a proof (authored by PiRK).
[electrum] enable sorting when selecting utxos for a proof
Tue, Nov 25, 07:34
PiRK committed rABCb1a9bf8ffab0: [electrum] fix unit for proof editor (authored by PiRK).
[electrum] fix unit for proof editor
Tue, Nov 25, 07:34
PiRK closed D18990: [electrum] enable sorting when selecting utxos for a proof.
Tue, Nov 25, 07:34
PiRK closed D18989: [electrum] fix unit for proof editor.
Tue, Nov 25, 07:34
PiRK closed D18988: [electrum] don't use magic values for decimal_point and num_zeros.
Tue, Nov 25, 07:34
PiRK committed rABC47ba985d7727: [electrum] don't use magic values for decimal_point and num_zeros (authored by PiRK).
[electrum] don't use magic values for decimal_point and num_zeros
Tue, Nov 25, 07:34

Mon, Nov 24

PiRK closed D18991: [electrum] bump version of ubuntu packages.
Mon, Nov 24, 21:43
PiRK committed rABCa6547c4f27f0: [electrum] bump version of ubuntu packages (authored by PiRK).
[electrum] bump version of ubuntu packages
Mon, Nov 24, 21:43
PiRK requested review of D18991: [electrum] bump version of ubuntu packages.
Mon, Nov 24, 16:34
PiRK updated the summary of D18990: [electrum] enable sorting when selecting utxos for a proof.
Mon, Nov 24, 16:18
PiRK added a comment to D18990: [electrum] enable sorting when selecting utxos for a proof.

See https://doc.qt.io/qt-6/qtablewidget.html#setItem:

Mon, Nov 24, 16:17
PiRK updated the diff for D18990: [electrum] enable sorting when selecting utxos for a proof.

back out blank line change and pointless sorting enabling in init (we need to enable it only after filling the table, or else the sorting will mess with the row number as we fill the block height and add the delete button))

Mon, Nov 24, 16:15
PiRK requested review of D18990: [electrum] enable sorting when selecting utxos for a proof.
Mon, Nov 24, 16:11
PiRK updated the diff for D18989: [electrum] fix unit for proof editor.

additional linting

Mon, Nov 24, 15:37
PiRK requested review of D18989: [electrum] fix unit for proof editor.
Mon, Nov 24, 15:37
PiRK requested review of D18988: [electrum] don't use magic values for decimal_point and num_zeros.
Mon, Nov 24, 15:34
PiRK committed rABC4be4af3280bd: [IBD] coins: increase default UTXO flush batch size to 32 MiB (authored by Lőrinc <pap.lorinc@gmail.com>).
[IBD] coins: increase default UTXO flush batch size to 32 MiB
Mon, Nov 24, 08:58
PiRK closed D18987: [IBD] coins: increase default UTXO flush batch size to 32 MiB.
Mon, Nov 24, 08:58
PiRK closed D18986: txpool: add a fast path in TxPool::EraseForBlock when the pool is empty.
Mon, Nov 24, 08:58
PiRK committed rABCe2831d3d5f30: txpool: add a fast path in TxPool::EraseForBlock when the pool is empty (authored by PiRK).
txpool: add a fast path in TxPool::EraseForBlock when the pool is empty
Mon, Nov 24, 08:58

Sun, Nov 23

PiRK requested review of D18987: [IBD] coins: increase default UTXO flush batch size to 32 MiB.
Sun, Nov 23, 08:20
PiRK requested review of D18986: txpool: add a fast path in TxPool::EraseForBlock when the pool is empty.
Sun, Nov 23, 08:08

Sat, Nov 22

PiRK accepted D18978: Cleanup Shibusawa activation after the November 15, 2025 upgrade.
Sat, Nov 22, 08:55
PiRK closed D18983: Add AutoFile::detail_fread member function.
Sat, Nov 22, 08:34
PiRK committed rABC91e8595944a9: Add AutoFile::detail_fread member function (authored by PiRK).
Add AutoFile::detail_fread member function
Sat, Nov 22, 08:34
PiRK closed D18982: refactor: Modernize AutoFile.
Sat, Nov 22, 08:34
PiRK committed rABC84fc11853760: doc: Remove comments that just repeat what the code does (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
doc: Remove comments that just repeat what the code does
Sat, Nov 22, 08:34
PiRK closed D18981: doc: Remove comments that just repeat what the code does.
Sat, Nov 22, 08:34
PiRK committed rABC9c3699c8ad3b: refactor: Modernize AutoFile (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
refactor: Modernize AutoFile
Sat, Nov 22, 08:34
PiRK closed D18980: refactor: Remove redundant file check from AutoFile shift operators.
Sat, Nov 22, 08:34
PiRK committed rABC254d51e18787: refactor: Remove redundant file check from AutoFile shift operators (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
refactor: Remove redundant file check from AutoFile shift operators
Sat, Nov 22, 08:33

Fri, Nov 21

PiRK requested review of D18983: Add AutoFile::detail_fread member function.
Fri, Nov 21, 16:56
PiRK updated the diff for D18982: refactor: Modernize AutoFile.

anticipating a clang-tidy failure

Fri, Nov 21, 16:52
PiRK requested review of D18982: refactor: Modernize AutoFile.
Fri, Nov 21, 16:50
PiRK updated the summary of D18981: doc: Remove comments that just repeat what the code does.
Fri, Nov 21, 16:50
PiRK requested review of D18981: doc: Remove comments that just repeat what the code does.
Fri, Nov 21, 16:49
PiRK requested review of D18980: refactor: Remove redundant file check from AutoFile shift operators.
Fri, Nov 21, 16:49
PiRK committed rABC73ad4f8bc093: refactor: Remove unused CDataStream SerializeMany constructor (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
refactor: Remove unused CDataStream SerializeMany constructor
Fri, Nov 21, 16:48
PiRK closed D18979: refactor: Remove unused CDataStream SerializeMany constructor.
Fri, Nov 21, 16:48
PiRK requested review of D18979: refactor: Remove unused CDataStream SerializeMany constructor.
Fri, Nov 21, 16:18
PiRK committed rABC3a3d9942a46d: log: Nuke error(...) (authored by PiRK).
log: Nuke error(...)
Fri, Nov 21, 14:38
PiRK closed D18977: log: Nuke error(...).
Fri, Nov 21, 14:38
PiRK published D18977: log: Nuke error(...) for review.
Fri, Nov 21, 11:12
PiRK closed D18974: blockstorage: Separate reindexing from saving new blocks.
Fri, Nov 21, 10:28
PiRK committed rABC9a73c1576529: blockstorage: Separate reindexing from saving new blocks (authored by Martin Zumsande <mzumsande@gmail.com>).
blockstorage: Separate reindexing from saving new blocks
Fri, Nov 21, 10:28

Thu, Nov 20

PiRK updated the summary of D18974: blockstorage: Separate reindexing from saving new blocks.
Thu, Nov 20, 16:15
PiRK requested review of D18974: blockstorage: Separate reindexing from saving new blocks.
Thu, Nov 20, 16:14
PiRK closed D18969: kernel: Add fatalError method to notifications.
Thu, Nov 20, 14:00
PiRK closed D18973: blockstorage: do not flush block to disk if it is already there.
Thu, Nov 20, 14:00
PiRK committed rABC4948c69ca3d3: blockstorage: do not flush block to disk if it is already there (authored by Matthew Zipkin <pinheadmz@gmail.com>).
blockstorage: do not flush block to disk if it is already there
Thu, Nov 20, 14:00
PiRK closed D18971: test: cover read-only blockstore.
Thu, Nov 20, 14:00
PiRK committed rABC8ac6dcd4b9f9: kernel: Add fatalError method to notifications (authored by TheCharlatan <seb.kung@gmail.com>).
kernel: Add fatalError method to notifications
Thu, Nov 20, 14:00
PiRK committed rABCa50ebbf5c376: test: cover read-only blockstore (authored by Matthew Zipkin <pinheadmz@gmail.com>).
test: cover read-only blockstore
Thu, Nov 20, 14:00
PiRK closed D18968: kernel: Add flushError method to notifications.
Thu, Nov 20, 14:00
PiRK committed rABC60bc1a5bd8e4: kernel: Add flushError method to notifications (authored by TheCharlatan <seb.kung@gmail.com>).
kernel: Add flushError method to notifications
Thu, Nov 20, 14:00
PiRK closed D18966: kernel: Pass interrupt reference to chainman.
Thu, Nov 20, 14:00
PiRK closed D18967: scripted-diff: Rename FatalError to FatalErrorf.
Thu, Nov 20, 14:00
PiRK committed rABC777075520a97: scripted-diff: Rename FatalError to FatalErrorf (authored by PiRK).
scripted-diff: Rename FatalError to FatalErrorf
Thu, Nov 20, 14:00
PiRK committed rABC6b210bfb2627: kernel: Pass interrupt reference to chainman (authored by TheCharlatan <seb.kung@gmail.com>).
kernel: Pass interrupt reference to chainman
Thu, Nov 20, 14:00
PiRK closed D18965: util: Add SignalInterrupt class and use in shutdown.cpp.
Thu, Nov 20, 14:00
PiRK committed rABCb259f8eed5fa: util: Add SignalInterrupt class and use in shutdown.cpp (authored by TheCharlatan <seb.kung@gmail.com>).
util: Add SignalInterrupt class and use in shutdown.cpp
Thu, Nov 20, 14:00
PiRK closed D18964: util: move threadinterrupt into util.
Thu, Nov 20, 14:00
PiRK committed rABCc6b38d1d9b9e: util: move threadinterrupt into util (authored by fanquake <fanquake@gmail.com>).
util: move threadinterrupt into util
Thu, Nov 20, 14:00
PiRK updated the diff for D18973: blockstorage: do not flush block to disk if it is already there.

rebase

Thu, Nov 20, 12:20
PiRK abandoned D18970: txdb: remove dependency on ui_interface.
Thu, Nov 20, 12:12
PiRK closed D18972: Remove utxo db upgrade code.
Thu, Nov 20, 12:07
PiRK committed rABC33b97b07c28c: Remove utxo db upgrade code (authored by MarcoFalke <falke.marco@gmail.com>).
Remove utxo db upgrade code
Thu, Nov 20, 12:07
PiRK requested review of D18973: blockstorage: do not flush block to disk if it is already there.
Thu, Nov 20, 10:53
PiRK added a comment to D18972: Remove utxo db upgrade code.

Note that if this is merged it will replace D18970 and require a rebase the rest of that stack (some changes in D18966 are no longer relevant)

Thu, Nov 20, 10:35
PiRK requested review of D18969: kernel: Add fatalError method to notifications.
Thu, Nov 20, 10:31
PiRK requested review of D18972: Remove utxo db upgrade code.
Thu, Nov 20, 10:08

Wed, Nov 19

PiRK updated the diff for D18971: test: cover read-only blockstore.

shebang --, file permissions

Wed, Nov 19, 19:41
PiRK updated the summary of D18971: test: cover read-only blockstore.
Wed, Nov 19, 19:40
PiRK updated the summary of D18955: [64-bit ints] 32-bit integers? I never knew you.
Wed, Nov 19, 19:38
PiRK updated the summary of D18970: txdb: remove dependency on ui_interface.
Wed, Nov 19, 19:36