Page MenuHomePhabricator

PiRK (Pierre K)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 5 2020, 16:14 (234 w, 21 h)

Recent Activity

Today

PiRK requested review of D17611: [chronik] return empty transcation history for an unknown scripthash.
Thu, Jan 30, 13:02

Yesterday

PiRK committed rABCb4ca4a8c259c: [chronik] make -chronikelectrumbind require -chronikscripthashindex (authored by PiRK).
[chronik] make -chronikelectrumbind require -chronikscripthashindex
Wed, Jan 29, 12:09
PiRK closed D17599: [chronik] make -chronikelectrumbind require -chronikscripthashindex.
Wed, Jan 29, 12:09

Tue, Jan 28

PiRK accepted D17604: [cmake] Fix check-crates.
Tue, Jan 28, 15:53
PiRK updated the diff for D17599: [chronik] make -chronikelectrumbind require -chronikscripthashindex.

fix test_init_errors (now chronikelectrumbind must be explicitely specified)

Tue, Jan 28, 14:05
PiRK planned changes to D17599: [chronik] make -chronikelectrumbind require -chronikscripthashindex.
Tue, Jan 28, 14:02
PiRK updated the diff for D17599: [chronik] make -chronikelectrumbind require -chronikscripthashindex.

fix functional tests

Tue, Jan 28, 13:04
PiRK accepted D17602: [doc] Cleanup trailing whitespaces.
Tue, Jan 28, 11:54
PiRK accepted D17601: [chronik] Fix check-crates.
Tue, Jan 28, 08:15
PiRK requested changes to D17602: [doc] Cleanup trailing whitespaces.

One more to be removed

Tue, Jan 28, 07:45

Mon, Jan 27

PiRK planned changes to D17599: [chronik] make -chronikelectrumbind require -chronikscripthashindex.
Mon, Jan 27, 19:07
PiRK requested review of D17599: [chronik] make -chronikelectrumbind require -chronikscripthashindex.
Mon, Jan 27, 16:12
PiRK accepted D17596: Bump the timeout for searching the debug log in p2p_ibd_stalling.
Mon, Jan 27, 12:44
PiRK accepted D17594: [Cashtab] Deprecate the auto-open camera on send feature.
Mon, Jan 27, 07:23

Sat, Jan 25

PiRK closed D17587: [electrum] push release notification for 5.4.0.
Sat, Jan 25, 18:24
PiRK committed rABC9b59caa7f802: [electrum] push release notification for 5.4.0 (authored by PiRK).
[electrum] push release notification for 5.4.0
Sat, Jan 25, 18:24

Fri, Jan 24

PiRK requested review of D17587: [electrum] push release notification for 5.4.0.
Fri, Jan 24, 16:01

Thu, Jan 23

PiRK closed D17581: [electrum] bump version to 5.4.0 and add release notes.
Thu, Jan 23, 21:14
PiRK committed rABC25bf4ca369b9: [electrum] bump version to 5.4.0 and add release notes (authored by PiRK).
[electrum] bump version to 5.4.0 and add release notes
Thu, Jan 23, 21:14
PiRK committed rABC491b7cda88c1: [electrum] fix lib versions for windows release scripts (authored by PiRK).
[electrum] fix lib versions for windows release scripts
Thu, Jan 23, 21:06
PiRK closed D17580: [electrum] fix lib versions for windows release scripts.
Thu, Jan 23, 21:06
PiRK updated the diff for D17581: [electrum] bump version to 5.4.0 and add release notes.

use 5.4.0 because of the new features

Thu, Jan 23, 20:21
PiRK requested review of D17581: [electrum] bump version to 5.4.0 and add release notes.
Thu, Jan 23, 16:36
PiRK updated the test plan for D17580: [electrum] fix lib versions for windows release scripts.
Thu, Jan 23, 15:51
PiRK committed rABCfb94895b4483: [electrum] Implement SLIP-0039 wallet recovery. (authored by Andrew Kozlik <andrew.kozlik@gmail.com>).
[electrum] Implement SLIP-0039 wallet recovery.
Thu, Jan 23, 15:51
PiRK closed D17577: [electrum] Implement SLIP-0039 wallet recovery..
Thu, Jan 23, 15:51
PiRK updated the summary of D17577: [electrum] Implement SLIP-0039 wallet recovery..
Thu, Jan 23, 15:50
PiRK requested review of D17580: [electrum] fix lib versions for windows release scripts.
Thu, Jan 23, 15:48
PiRK accepted D17579: [electrum][trezor] 1-click install of the eCash logo as a homescreen.
Thu, Jan 23, 15:43
PiRK retitled D17577: [electrum] Implement SLIP-0039 wallet recovery. from Implement SLIP-0039 wallet recovery. to [electrum] Implement SLIP-0039 wallet recovery..
Thu, Jan 23, 14:01
PiRK closed D17576: [electrum] pass the bip32 rootseed to the derivation path scanner.
Thu, Jan 23, 14:00
PiRK committed rABC92e7592a5448: [electrum] pass the bip32 rootseed to the derivation path scanner (authored by PiRK).
[electrum] pass the bip32 rootseed to the derivation path scanner
Thu, Jan 23, 14:00
PiRK added a comment to D17579: [electrum][trezor] 1-click install of the eCash logo as a homescreen.

will test a dummy release later to make sure the image files are properly packaged and relative paths work as expected

Thu, Jan 23, 13:59
PiRK accepted D17578: [electrum][trezor] Fix homescreen reset.

probably broken in some major trezor API change (looks like they passed images as strings before, or maybe it was a python2 thing) https://github.com/spesmilo/electrum/commit/dda9d4b746700bfc095c80d84f1ac5de46c5f2ca

Thu, Jan 23, 13:54
PiRK updated the diff for D17577: [electrum] Implement SLIP-0039 wallet recovery..

minor improvements

Thu, Jan 23, 13:09
PiRK planned changes to D17577: [electrum] Implement SLIP-0039 wallet recovery..

found a couple of minor fixups to backport

Thu, Jan 23, 13:00
PiRK published D17577: [electrum] Implement SLIP-0039 wallet recovery. for review.
Thu, Jan 23, 12:58
PiRK requested review of D17576: [electrum] pass the bip32 rootseed to the derivation path scanner.
Thu, Jan 23, 10:20

Tue, Jan 21

PiRK closed D17572: [electrum] refactor: introduce a Wordlist class for seed phrases.
Tue, Jan 21, 16:32
PiRK committed rABCb7a52c79e63d: [electrum] refactor: introduce a Wordlist class for seed phrases (authored by PiRK).
[electrum] refactor: introduce a Wordlist class for seed phrases
Tue, Jan 21, 16:32
PiRK closed D17570: [electrum] seed completer: colour words yellow if only in old electrum list.
Tue, Jan 21, 16:32
PiRK closed D17569: [electrum] implement autocompletion when restoring from seed.
Tue, Jan 21, 16:32
PiRK committed rABC47615a805bc7: [electrum] seed completer: colour words yellow if only in old electrum list (authored by SomberNight <somber.night@protonmail.com>).
[electrum] seed completer: colour words yellow if only in old electrum list
Tue, Jan 21, 16:32
PiRK committed rABCd999f60ac80f: [electrum] implement autocompletion when restoring from seed (authored by PiRK).
[electrum] implement autocompletion when restoring from seed
Tue, Jan 21, 16:32
PiRK closed D17568: [electrum] refactor text completion.
Tue, Jan 21, 16:32
PiRK committed rABC415850772402: [electrum] refactor text completion (authored by Lastrellik <lastrellik@gmail.com>).
[electrum] refactor text completion
Tue, Jan 21, 16:32
PiRK added inline comments to D17572: [electrum] refactor: introduce a Wordlist class for seed phrases.
Tue, Jan 21, 14:22
PiRK updated the diff for D17572: [electrum] refactor: introduce a Wordlist class for seed phrases.

no need for the list conversion. In our codebase bip39_list is already a list because we use Trezor's mnemonic library (so we can support multiple languages for restoring seeds) https://github.com/trezor/python-mnemonic/blob/master/src/mnemonic/mnemonic.py#L56

Tue, Jan 21, 14:15
PiRK requested review of D17572: [electrum] refactor: introduce a Wordlist class for seed phrases.
Tue, Jan 21, 14:04
PiRK updated the diff for D17568: [electrum] refactor text completion.

restore https://github.com/Bitcoin-ABC/ElectrumABC/commit/e2d0f7f804a0b805644957f423e04120cff921b3 and https://github.com/Bitcoin-ABC/ElectrumABC/commit/ac0da1446ed153c291b065cd9ef8a20ef561081d

Tue, Jan 21, 12:38
PiRK planned changes to D17568: [electrum] refactor text completion.

I may have lost a few Electron Cash improvements in keyPressEvent in the process

Tue, Jan 21, 12:22
PiRK updated the test plan for D17568: [electrum] refactor text completion.
Tue, Jan 21, 12:12
PiRK requested review of D17570: [electrum] seed completer: colour words yellow if only in old electrum list.
Tue, Jan 21, 09:30
PiRK updated the summary of D17569: [electrum] implement autocompletion when restoring from seed.
Tue, Jan 21, 09:17
PiRK requested review of D17569: [electrum] implement autocompletion when restoring from seed.
Tue, Jan 21, 09:15
PiRK requested review of D17568: [electrum] refactor text completion.
Tue, Jan 21, 08:44

Mon, Jan 20

PiRK accepted D17567: [explorer] Update the address.js hash.
Mon, Jan 20, 10:15
PiRK committed rABCdf23154ef489: [electrum] trezor: allow PIN of length 50 for T1 firmware >=1.10.0 and other… (authored by Sander van Grieken <sander@outrightsolutions.nl>).
[electrum] trezor: allow PIN of length 50 for T1 firmware >=1.10.0 and other…
Mon, Jan 20, 07:38
PiRK closed D17561: [electrum] trezor: allow PIN of length 50 for T1 firmware >=1.10.0 and other devices firmware >=2.4.0.
Mon, Jan 20, 07:38

Sun, Jan 19

PiRK accepted D17563: [electrum] Fix Trezor 1 unlocking.
Sun, Jan 19, 21:17

Sat, Jan 18

PiRK added inline comments to D17561: [electrum] trezor: allow PIN of length 50 for T1 firmware >=1.10.0 and other devices firmware >=2.4.0.
Sat, Jan 18, 09:21
PiRK added a comment to D17561: [electrum] trezor: allow PIN of length 50 for T1 firmware >=1.10.0 and other devices firmware >=2.4.0.

Note that I had to first revert D17457 to test this, because D17457 introduces a new bug preventing pairing with a Trezor 1

Sat, Jan 18, 09:18
PiRK requested review of D17561: [electrum] trezor: allow PIN of length 50 for T1 firmware >=1.10.0 and other devices firmware >=2.4.0.
Sat, Jan 18, 09:17
PiRK closed D17555: [electrum] trezor: implement support for Shamir recovery.
Sat, Jan 18, 08:30
PiRK committed rABC1381c9376fa7: [electrum] trezor: implement support for Shamir recovery (authored by matejcik <ja@matejcik.cz>).
[electrum] trezor: implement support for Shamir recovery
Sat, Jan 18, 08:30

Fri, Jan 17

PiRK requested review of D17555: [electrum] trezor: implement support for Shamir recovery.
Fri, Jan 17, 14:44
PiRK closed D17553: [electrum] trezor: implement "seedless" mode (option during initialization).
Fri, Jan 17, 11:39
PiRK committed rABC0377d768572f: [electrum] trezor: implement "seedless" mode (option during initialization) (authored by PiRK).
[electrum] trezor: implement "seedless" mode (option during initialization)
Fri, Jan 17, 11:39
PiRK accepted D17554: [electrum] Better trezor homescreen support.
Fri, Jan 17, 10:52
PiRK retitled D17553: [electrum] trezor: implement "seedless" mode (option during initialization) from trezor: implement "seedless" mode (option during initialization) to [electrum] trezor: implement "seedless" mode (option during initialization).
Fri, Jan 17, 10:34
PiRK requested review of D17553: [electrum] trezor: implement "seedless" mode (option during initialization).
Fri, Jan 17, 10:32
PiRK accepted D17547: [electrum] Bugfix: close the "Check your trezor" popup after entering a passphrase.

tested with a Trezor T

Fri, Jan 17, 08:10
PiRK closed D17541: Cache block index entry corresponding to assumeutxo snapshot base blockhash.
Fri, Jan 17, 08:08
PiRK committed rABCaf7dbeb97b63: Cache block index entry corresponding to assumeutxo snapshot base blockhash (authored by Suhas Daftuar <sdaftuar@chaincode.com>).
Cache block index entry corresponding to assumeutxo snapshot base blockhash
Fri, Jan 17, 08:08
PiRK closed D17537: Move CheckBlockIndex() from Chainstate to ChainstateManager.
Fri, Jan 17, 08:08
PiRK closed D17536: Documentation improvements for assumeutxo.
Fri, Jan 17, 08:08
PiRK closed D17535: Fix initialization of setBlockIndexCandidates when working with multiple chainstates.
Fri, Jan 17, 08:08
PiRK committed rABCa5d25d3b48f3: Move CheckBlockIndex() from Chainstate to ChainstateManager (authored by Suhas Daftuar <sdaftuar@chaincode.com>).
Move CheckBlockIndex() from Chainstate to ChainstateManager
Fri, Jan 17, 08:08
PiRK committed rABC781f67df62a8: Documentation improvements for assumeutxo (authored by Ryan Ofsky <ryan@ofsky.org>).
Documentation improvements for assumeutxo
Fri, Jan 17, 08:08
PiRK committed rABCce02141a9db8: Fix initialization of setBlockIndexCandidates when working with multiple… (authored by Suhas Daftuar <sdaftuar@chaincode.com>).
Fix initialization of setBlockIndexCandidates when working with multiple…
Fri, Jan 17, 08:07
PiRK closed D17534: Tighten requirements for adding elements to setBlockIndexCandidates.
Fri, Jan 17, 08:07
PiRK committed rABCc3eb66ed6134: Tighten requirements for adding elements to setBlockIndexCandidates (authored by Suhas Daftuar <sdaftuar@chaincode.com>).
Tighten requirements for adding elements to setBlockIndexCandidates
Fri, Jan 17, 08:07
PiRK closed D17533: Move block-storage-related logic to ChainstateManager.
Fri, Jan 17, 08:07
PiRK committed rABC2edc904cea06: Move block-storage-related logic to ChainstateManager (authored by Suhas Daftuar <sdaftuar@chaincode.com>).
Move block-storage-related logic to ChainstateManager
Fri, Jan 17, 08:07
PiRK committed rABCe476633f2c51: Add wrapper for adding entries to a chainstate's block index candidates (authored by Suhas Daftuar <sdaftuar@chaincode.com>).
Add wrapper for adding entries to a chainstate's block index candidates
Fri, Jan 17, 08:07
PiRK closed D17532: Add wrapper for adding entries to a chainstate's block index candidates.
Fri, Jan 17, 08:07
PiRK closed D17440: Update CheckBlockIndex invariants for chains based on an assumeutxo snapshot.
Fri, Jan 17, 08:07
PiRK committed rABCca86cbd58f3e: Update CheckBlockIndex invariants for chains based on an assumeutxo snapshot (authored by Suhas Daftuar <sdaftuar@chaincode.com>).
Update CheckBlockIndex invariants for chains based on an assumeutxo snapshot
Fri, Jan 17, 08:07
PiRK closed D17433: Move block-arrival information / preciousblock counters to ChainstateManager.
Fri, Jan 17, 08:07
PiRK committed rABC5ad8a704fdcb: Move block-arrival information / preciousblock counters to ChainstateManager (authored by Suhas Daftuar <sdaftuar@chaincode.com>).
Move block-arrival information / preciousblock counters to ChainstateManager
Fri, Jan 17, 08:07
PiRK closed D17432: Explicitly track maximum block height stored in undo files.
Fri, Jan 17, 08:07
PiRK committed rABCcfc92ee56946: Explicitly track maximum block height stored in undo files (authored by Suhas Daftuar <sdaftuar@chaincode.com>).
Explicitly track maximum block height stored in undo files
Fri, Jan 17, 08:07

Thu, Jan 16

PiRK accepted D17546: [electrum] Fix the homescreen change with all devices.
Thu, Jan 16, 17:08
PiRK updated the diff for D17533: Move block-storage-related logic to ChainstateManager.

feedback

Thu, Jan 16, 08:55
PiRK accepted D17543: [mock-chronik-client] Clean up test mocks file.
Thu, Jan 16, 07:37
PiRK accepted D17542: [mock-chronik-client] Improve path defs for typescript build.
Thu, Jan 16, 07:36

Wed, Jan 15

PiRK requested review of D17541: Cache block index entry corresponding to assumeutxo snapshot base blockhash.
Wed, Jan 15, 20:55
PiRK updated the diff for D17537: Move CheckBlockIndex() from Chainstate to ChainstateManager.

rebase

Wed, Jan 15, 20:42
PiRK updated the diff for D17536: Documentation improvements for assumeutxo.

rebase

Wed, Jan 15, 20:30
PiRK updated the diff for D17535: Fix initialization of setBlockIndexCandidates when working with multiple chainstates.

rebase

Wed, Jan 15, 20:29