User Details
User Details
- User Since
- Aug 5 2020, 16:14 (238 w, 4 d)
Today
Today
tests: use noban_tx_relay in more tests
Fri, Feb 28
Fri, Feb 28
PiRK requested review of D17730: tests: use noban_tx_relay in more tests.
PiRK committed rABC3f303c2e897e: indexes, refactor: Remove CBlockIndex* uses in index Init methods (authored by Ryan Ofsky <ryan@ofsky.org>).
indexes, refactor: Remove CBlockIndex* uses in index Init methods
PiRK committed rABCef4a1052f5f0: indexes, refactor: Remove CBlockIndex* uses in coinstatsindex LookUpOne function (authored by Ryan Ofsky <ryan@ofsky.org>).
indexes, refactor: Remove CBlockIndex* uses in coinstatsindex LookUpOne function
PiRK updated the diff for D17723: [kernel 2c/n] Introduce kernel::Context, encapsulate global init/teardown.
rm Makefile.am
PiRK requested review of D17723: [kernel 2c/n] Introduce kernel::Context, encapsulate global init/teardown.
PiRK requested review of D17722: indexes, refactor: Remove CBlockIndex* uses in index Init methods.
PiRK committed rABC1583f9118eba: index: fix reindex-chainstate with active indexes (authored by Martin Zumsande <mzumsande@gmail.com>).
index: fix reindex-chainstate with active indexes
PiRK updated the diff for D17714: index: fix reindex-chainstate with active indexes.
use -noparkdeepreorg and mine 5 blocks
Thu, Feb 27
Thu, Feb 27
PiRK added inline comments to D17714: index: fix reindex-chainstate with active indexes.
PiRK updated the diff for D17714: index: fix reindex-chainstate with active indexes.
fix clang-tidy style error, fix test flakiness (mine enough new block to trigger automatic unparking on the other node, 5 was not enough)
PiRK planned changes to D17714: index: fix reindex-chainstate with active indexes.
PiRK requested review of D17714: index: fix reindex-chainstate with active indexes.
PiRK committed rABC2d464809a97d: refactor: use std::string for thread names (authored by stickies-v <stickies-v@protonmail.com>).
refactor: use std::string for thread names
PiRK committed rABC3926deb8fa05: refactor: use std::string for index names (authored by stickies-v <stickies-v@protonmail.com>).
refactor: use std::string for index names
PiRK committed rABC94e4f949ce51: indexes, refactor: Pass Chain interface instead of CChainState class to indexes (authored by Ryan Ofsky <ryan@ofsky.org>).
indexes, refactor: Pass Chain interface instead of CChainState class to indexes
PiRK committed rABC1e96a8544247: [chronik] add Electrum RPC server.donation_address (authored by PiRK).
[chronik] add Electrum RPC server.donation_address
PiRK updated the diff for D17706: refactor: use std::string for thread names.
remove unused include
PiRK updated the diff for D17705: indexes, refactor: Pass Chain interface instead of CChainState class to indexes.
remove unnecessary forward declaration
Wed, Feb 26
Wed, Feb 26
PiRK added a comment to D17705: indexes, refactor: Pass Chain interface instead of CChainState class to indexes.
I'll keep looking what's wrong with feature_assumevalid, but it is not related to this diff.
PiRK committed rABCa23a2ae0eda8: index: Move last_locator_write_time and logging to end of threadsync loop (authored by Fabian Jahr <fjahr@protonmail.com>).
index: Move last_locator_write_time and logging to end of threadsync loop
PiRK committed rABC8e4b9a1ff950: doc: BaseIndex sync behavior with empty datadir (authored by James O'Beirne <james.obeirne@pm.me>).
doc: BaseIndex sync behavior with empty datadir
PiRK committed rABCef3b321b2815: index: Don't commit a best block before indexing it during sync (authored by Martin Zumsande <mzumsande@gmail.com>).
index: Don't commit a best block before indexing it during sync
PiRK updated the diff for D17686: [chronik] add Electrum RPC server.donation_address.
use the constant in strings
PiRK requested review of D17707: refactor: use std::string for index names.
PiRK requested review of D17706: refactor: use std::string for thread names.
PiRK requested review of D17704: index: Move last_locator_write_time and logging to end of threadsync loop.
PiRK updated the summary of D17703: doc: BaseIndex sync behavior with empty datadir.
PiRK requested review of D17703: doc: BaseIndex sync behavior with empty datadir.
PiRK requested review of D17702: index: Don't commit a best block before indexing it during sync.
PiRK updated the diff for D17686: [chronik] add Electrum RPC server.donation_address.
make max length a constexpr
PiRK updated the summary of D17686: [chronik] add Electrum RPC server.donation_address.
PiRK updated the diff for D17686: [chronik] add Electrum RPC server.donation_address.
chech the donation address length
Tue, Feb 25
Tue, Feb 25
PiRK committed rABC40402b2ac954: wallet: Ignore chainStateFlushed notifications while attaching chain (authored by Martin Zumsande <mzumsande@gmail.com>).
wallet: Ignore chainStateFlushed notifications while attaching chain
PiRK updated the diff for D17689: wallet: Ignore chainStateFlushed notifications while attaching chain.
remove first comment which would mess with formatting if left inline and is already explained by the previous block of comments
add a comment as suggested to first call m_attaching_chain = false
PiRK updated the diff for D17689: wallet: Ignore chainStateFlushed notifications while attaching chain.
rebase
PiRK committed rABCc52393d22e61: doc: Improve ZMQ documentation (authored by node01 <mbildwic@protonmail.com>).
doc: Improve ZMQ documentation
PiRK committed rABCf4d4a586a65b: test: refactor: use `create_block` parameters (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
test: refactor: use `create_block` parameters
Mon, Feb 24
Mon, Feb 24
PiRK committed rABC33c0dc6359a1: test: remove unnecessary block rehashing prior to solving (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
test: remove unnecessary block rehashing prior to solving
PiRK added inline comments to D17691: test: refactor: use `create_block` parameters.
PiRK updated the diff for D17691: test: refactor: use `create_block` parameters.
don't shadow j either
PiRK requested review of D17691: test: refactor: use `create_block` parameters.
PiRK requested review of D17690: test: remove unnecessary block rehashing prior to solving.
Sun, Feb 23
Sun, Feb 23
PiRK planned changes to D17689: wallet: Ignore chainStateFlushed notifications while attaching chain.
CI failure most likely unrelated, but will have to investigate anyway (tomorrow)
PiRK requested review of D17689: wallet: Ignore chainStateFlushed notifications while attaching chain.
Sat, Feb 22
Sat, Feb 22
PiRK added a comment to D17688: doc: Improve ZMQ documentation.
Backported as a dependency of https://github.com/bitcoin/bitcoin/pull/27596/commits/f073917a9e7ba423643dcae0339776470b628f65
PiRK requested review of D17688: doc: Improve ZMQ documentation.
PiRK updated the diff for D17686: [chronik] add Electrum RPC server.donation_address.
fix comment layout
Fri, Feb 21
Fri, Feb 21
PiRK requested review of D17686: [chronik] add Electrum RPC server.donation_address.
PiRK accepted D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Still lgtm
PiRK committed rABCb760220009df: [chronik] make the maximum history length for electrum RPCs an init param (authored by PiRK).
[chronik] make the maximum history length for electrum RPCs an init param
Thu, Feb 20
Thu, Feb 20
PiRK retitled D17681: [chronik] make the maximum history length for electrum RPCs an init param from [chronik] make the maximum history length an init param to [chronik] make the maximum history length for electrum RPCs an init param.
PiRK requested review of D17681: [chronik] make the maximum history length for electrum RPCs an init param.
PiRK committed rABC91ef9971ad45: [chronik] implement server.version electrum method (authored by PiRK).
[chronik] implement server.version electrum method
Wed, Feb 19
Wed, Feb 19
PiRK updated the diff for D17676: [chronik] implement server.version electrum method.
remove done TODO
PiRK added inline comments to D17676: [chronik] implement server.version electrum method.
PiRK updated the summary of D17676: [chronik] implement server.version electrum method.
PiRK requested review of D17676: [chronik] implement server.version electrum method.
Tue, Feb 18
Tue, Feb 18
PiRK committed rABC9205e1004401: test: Add explicit onion bind to p2p_permissions (authored by Ava Chow <github@achow101.com>).
test: Add explicit onion bind to p2p_permissions
PiRK requested review of D17673: test: Add explicit onion bind to p2p_permissions.
PiRK committed rABCe09df7e9e3ab: [chronik] Implement blockchain.scripthash.listunspent electrum method (authored by PiRK).
[chronik] Implement blockchain.scripthash.listunspent electrum method
PiRK committed rABC36570956a320: [electrum] support newer protobuf library versions (authored by PiRK).
[electrum] support newer protobuf library versions
let's see if it pops up on CI again