Page MenuHomePhabricator
People jjz

jjz (姜家志)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 9 2017, 23:10 (386 w, 3 d)

Recent Activity
View All

Dec 11 2017

jjz closed T110: Change BCC to BCH in the wallet as Resolved.
Dec 11 2017, 06:31 · Restricted Project
jjz reopened T110: Change BCC to BCH in the wallet as "Open".
Dec 11 2017, 06:24 · Restricted Project
jjz closed T110: Change BCC to BCH in the wallet as Resolved.
Dec 11 2017, 06:24 · Restricted Project

Nov 15 2017

jjz committed rABCc3f3212e16aa: BCC -> BCH (authored by jjz).
BCC -> BCH
Nov 15 2017, 00:47
jjz closed D657: BCC -> BCH.
Nov 15 2017, 00:47

Nov 13 2017

jjz added a comment to D657: BCC -> BCH.
In D657#12022, @deadalnix wrote:

Except for the help file, this looks good. Please regenerate them to be non dirty and I'll accept.

Nov 13 2017, 07:15
jjz updated the diff for D657: BCC -> BCH.

regenerate to be non dirty

Nov 13 2017, 07:11
jjz added a revision to T110: Change BCC to BCH in the wallet: D657: BCC -> BCH.
Nov 13 2017, 01:22 · Restricted Project
jjz added a task to D657: BCC -> BCH: T110: Change BCC to BCH in the wallet.
Nov 13 2017, 01:22
jjz added a comment to T110: Change BCC to BCH in the wallet.
In T110#1656, @jasonbcox wrote:

Hey @jjz, thanks for taking this. In the future, please assign this ticket to yourself so that I know you're working on it. We don't want to be doing double work on the same ticket. ;)

Nov 13 2017, 01:14 · Restricted Project

Nov 10 2017

jjz added a comment to D657: BCC -> BCH.
In D657#12009, @schancel wrote:

Thanks @jjz. This looks good. I know you didn't originally add them, but can I ask you to please remove the autogenerated files and add them to the .gitignore?

Nov 10 2017, 08:50
jjz added a comment to D657: BCC -> BCH.
In D657#11990, @freetrader wrote:

See previous comments for list of BCC occurrences that I think should be added.

Nov 10 2017, 07:51
jjz updated the diff for D657: BCC -> BCH.

update all files

Nov 10 2017, 07:38
jjz added a comment to D657: BCC -> BCH.
In D657#11990, @freetrader wrote:

See previous comments for list of BCC occurrences that I think should be added.

Nov 10 2017, 06:04
jjz added a comment to T110: Change BCC to BCH in the wallet.

I've made a diff https://reviews.bitcoinabc.org/D657

Nov 10 2017, 03:12 · Restricted Project
Herald added a reviewer for D657: BCC -> BCH: Restricted Project.
Nov 10 2017, 02:48

Nov 9 2017

jjz added a comment to T110: Change BCC to BCH in the wallet.

A lot of Chinese companies do this ,too https://github.com/Bitcoin-ABC/bitcoin-abc/issues/104

Nov 9 2017, 21:58 · Restricted Project

Nov 8 2017

jjz committed rABC966c0a3652bd: run ./gen-manpages.sh to automatically create help infomation (authored by jjz).
run ./gen-manpages.sh to automatically create help infomation
Nov 8 2017, 21:06
jjz committed rABC94ac26507cc7: Delete the language resources of RBF in BCC because BCC does not support RBF (authored by jjz).
Delete the language resources of RBF in BCC because BCC does not support RBF
Nov 8 2017, 21:06
jjz closed D639: run ./gen-manpages.sh to automatically create help infomation by committing rABC966c0a3652bd: run ./gen-manpages.sh to automatically create help infomation.
Nov 8 2017, 21:06
jjz closed D638: Delete the language resources of RBF in BCC because BCC does not support RBF by committing rABC94ac26507cc7: Delete the language resources of RBF in BCC because BCC does not support RBF.
Nov 8 2017, 21:06

Nov 7 2017

Herald added 1 blocking reviewer(s) for D639: run ./gen-manpages.sh to automatically create help infomation: Restricted Project.
Nov 7 2017, 02:47
Herald added 1 blocking reviewer(s) for D638: Delete the language resources of RBF in BCC because BCC does not support RBF: Restricted Project.
Nov 7 2017, 02:42

Nov 6 2017

jjz added a comment to D637: remove "Send transactions with full-RBF opt-in enabled (default: %u)" from .ts and run "./gen-manpages.sh".
In D637#11666, @deadalnix wrote:

It seems like there are 2 changes backed in one here. The translation and the documentation. It would deserve 2 diffs.

Nov 6 2017, 22:08
Herald added 1 blocking reviewer(s) for D637: remove "Send transactions with full-RBF opt-in enabled (default: %u)" from .ts and run "./gen-manpages.sh": Restricted Project.
Nov 6 2017, 19:06

Nov 4 2017

jjz accepted rABC31b68eb0b59b: Switch to GCC 7 on Travis, disable currently non-functional ARM + Windows builds.

I tested it ,it all passed .link

Nov 4 2017, 22:18

Oct 31 2017

jjz committed rABC6abbaa607fd0: The color display is added to the test results of pyzmq ,Green is passed, Red… (authored by jjz).
The color display is added to the test results of pyzmq ,Green is passed, Red…
Oct 31 2017, 03:01
jjz closed D627: The color display is added to the test results of pyzmq ,Green is passed, Red is not passed by committing rABC6abbaa607fd0: The color display is added to the test results of pyzmq ,Green is passed, Red….
Oct 31 2017, 03:00

Oct 30 2017

jjz added a comment to D625: The color display is added to the test results of pyzmq ,Green is passed, Red is not passed.
In D625#11434, @schancel wrote:

Hi jjz,

I don't see the other commit in the Phabricator UI. I believe every diff in phabricator is intended to be a single commit. Are you using arcanist to generate patches? If so you need to amend your commit before running arc diff

Oct 30 2017, 04:09
Herald added 1 blocking reviewer(s) for D627: The color display is added to the test results of pyzmq ,Green is passed, Red is not passed: Restricted Project.
Oct 30 2017, 04:07
jjz added a comment to D625: The color display is added to the test results of pyzmq ,Green is passed, Red is not passed.
In D625#11434, @schancel wrote:

Hi jjz,

I don't see the other commit in the Phabricator UI. I believe every diff in phabricator is intended to be a single commit. Are you using arcanist to generate patches? If so you need to amend your commit before running arc diff

Oct 30 2017, 03:14

Oct 28 2017

jjz added a comment to D625: The color display is added to the test results of pyzmq ,Green is passed, Red is not passed.
In D625#11398, @schancel wrote:

Hi jjz,

Thanks for the patch! Is this just autopep8 changes? I don't see anything related to adding colors to the test results.

Oct 28 2017, 01:33

Oct 27 2017

jjz updated the diff for D625: The color display is added to the test results of pyzmq ,Green is passed, Red is not passed.

use autopep8 to format python code

Oct 27 2017, 08:01
Herald added 1 blocking reviewer(s) for D625: The color display is added to the test results of pyzmq ,Green is passed, Red is not passed: Restricted Project.
Oct 27 2017, 07:22

Sep 6 2017

jjz committed rABC0f54387192d7: The declared variable type is consistent with the enum type defined (authored by jjz).
The declared variable type is consistent with the enum type defined
Sep 6 2017, 12:34
jjz closed D528: The declared variable type is consistent with the enum type defined by committing rABC0f54387192d7: The declared variable type is consistent with the enum type defined.
Sep 6 2017, 12:34
Herald added 1 blocking reviewer(s) for D528: The declared variable type is consistent with the enum type defined: Restricted Project.
Sep 6 2017, 01:00

Jun 13 2017

jjz accepted rABCd6a7c7ccaac5: Various formating nits in net.cpp.

Add {} is a good way , otherwise it is not by reading the code

Jun 13 2017, 22:43