Scale disconnected transaction pool size based on maximum block size
ClosedPublic
Actions

Authored by jasonbcox on Jan 22 2018, 04:50.

Details

Reviewers

deadalnix
schancel

Group Reviewers

Restricted Project

Commits

rSTAGING2c81a03ad212: Scale disconnected transaction pool size based on maximum block size
rABC2c81a03ad212: Scale disconnected transaction pool size based on maximum block size

Summary

T168: MAX_DISCONNECTED_TX_POOL_SIZE was added by a Core PR, but doesn't consider block size when defining this value. I've added a scaling factor and changed it from kilobytes to bytes to be consistent with blocksize.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

dpool

Lint

Lint Passed

Severity	Location	Code	Message
Auto-Fix	src/validation.cpp:1	CFMT	Code style violation

Unit

No Test Coverage

Build Status

Buildable 1720
Build 1720: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jan 22 2018, 04:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 22 2018, 04:50

Harbormaster completed remote builds in B1720: Diff 2671.Jan 22 2018, 04:50

jasonbcox edited the summary of this revision. (Show Details)Jan 22 2018, 04:51

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

deadalnix accepted this revision.Jan 22 2018, 14:14

This revision is now accepted and ready to land.Jan 22 2018, 14:14

Closed by commit rABC2c81a03ad212: Scale disconnected transaction pool size based on maximum block size (authored by jasonbcox). · Explain WhyJan 23 2018, 04:58

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

validation.h

6 lines

validation.cpp

2 lines

Diff 2671

View Options

src/validation.h