[avalanche] Clarify the proof accessor API
ClosedPublic
Actions

Authored by Fabien on Oct 21 2021, 13:42.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABCf03a3e0c3b3c: [avalanche] Clarify the proof accessor API

Summary

The getProof() and exists() methods only target valid proof and not the orphans. This diff changes this API so it is easier to retrieve any known proof from its ID.

Ref T1854.

Test Plan

ninja check-extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 21 2021, 13:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 21 2021, 13:42

Fabien requested review of this revision.Oct 21 2021, 13:42

Harbormaster completed remote builds in B17080: Diff 30620.Oct 21 2021, 13:56

Fabien added a child revision: D10377: [avalanche] Orphan the conflicting proofs rather than ignoring them.Oct 21 2021, 15:48

Overall, lgtm. This is indeed much better.

I don't think the use a forPeer is very judicious, though. It obfuscate the code more than anything else.

src/avalanche/peermanager.cpp
228 ↗	(On Diff #30620)	That seems to be a very convoluted way to do auto &pview = peers.get<proof_index>(); return pview.find(proofid) != pview.end();