Paths

Table of Contentst

Differential D10466

[validation] Remove absurdfee from accepttomempool
ClosedPublic
Actions

Authored by PiRK on Nov 11 2021, 09:35.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC497282c479d2: [validation] Remove absurdfee from accepttomempool

Summary

Mempool behavior should not be user-specific.
Checking that txfee is acceptable should be
the responsibility of the wallet or client, not
the mempool.

This is a backport of core#19339 [3/3]
https://github.com/bitcoin/bitcoin/pull/19339/commits/b048b275d9711f70847afaea5450f17a0f7e673a

Depends on D10465

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr19339

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17255
Build 34341: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang · build-bench
Build 34340: arc lint + arc unit

Event Timeline

PiRK created this revision.Nov 11 2021, 09:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 11 2021, 09:35

PiRK requested review of this revision.Nov 11 2021, 09:35

teamcity edited the summary of this revision. (Show Details)Nov 11 2021, 09:37

rebase after touching the previous 2 commits (no change to this commit)

Harbormaster completed remote builds in B17234: Diff 30840.Nov 11 2021, 10:07

Harbormaster completed remote builds in B17237: Diff 30843.Nov 11 2021, 10:32

rebase

Harbormaster completed remote builds in B17255: Diff 30868.Nov 15 2021, 09:04

Fabien accepted this revision.Nov 16 2021, 14:36

This revision is now accepted and ready to land.Nov 16 2021, 14:36

Closed by commit rABC497282c479d2: [validation] Remove absurdfee from accepttomempool (authored by John Newbery <john@johnnewbery.com>, committed by PiRK). · Explain WhyNov 16 2021, 15:56

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC497282c479d2: [validation] Remove absurdfee from accepttomempool.

Revision Contents
Changeset List

Path

Size

src/

bench/

block_assemble.cpp

3 lines

net_processing.cpp

6 lines

node/

transaction.cpp

10 lines

rpc/

rawtransaction.cpp

3 lines

test/

txvalidation_tests.cpp

3 lines

txvalidationcache_tests.cpp

6 lines

validation_block_tests.cpp

3 lines

3 lines

4 lines

33 lines

Diff 30868

src/bench/block_assemble.cpp

Loading...

src/net_processing.cpp

Loading...

src/node/transaction.cpp

Loading...

src/rpc/rawtransaction.cpp

Loading...

src/test/txvalidation_tests.cpp

Loading...

src/test/txvalidationcache_tests.cpp

Loading...

src/test/validation_block_tests.cpp

Loading...

src/txmempool.cpp

Loading...

src/validation.h

Loading...

src/validation.cpp

Loading...