Differential D10727

[avalanche] Poll for the new proofs
ClosedPublic
Actions

Authored by Fabien on Dec 22 2021, 16:43.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC966d6fd7b9ff: [avalanche] Poll for the new proofs

Summary

As per title. We poll for all proofs that have a chance to immediately become a peer. This is disabled if proof replacement is disabled, as this prevents from updating the proof status according to the reponses.

Ref T1854.

Depends on D10525 and D10711.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_vote_on_conflicting_proofs

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17838
Build 35502: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 35501: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 22 2021, 16:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 22 2021, 16:43

Fabien requested review of this revision.Dec 22 2021, 16:43

Harbormaster completed remote builds in B17734: Diff 31546.Dec 22 2021, 16:54

needs rebase

Fabien edited the summary of this revision. (Show Details)Jan 7 2022, 16:13

Fabien added a parent revision: D10711: [avalanche] Add a method to reject a proof.

Rebase

Fabien added a child revision: D10788: [avalanche] Update our position according to the vote.Jan 7 2022, 16:19

Harbormaster completed remote builds in B17838: Diff 31699.Jan 7 2022, 16:29

Rebase

Harbormaster completed remote builds in B17879: Diff 31750.Jan 11 2022, 09:34

Activating the polling looks correct and the test looks correct and comprehensive.

This revision is now accepted and ready to land.Jan 26 2022, 09:43

Closed by commit rABC966d6fd7b9ff: [avalanche] Poll for the new proofs (authored by Fabien). · Explain WhyFeb 9 2022, 09:08

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC966d6fd7b9ff: [avalanche] Poll for the new proofs.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

18 lines

test/

functional/

abc_p2p_avalanche_proof_voting.py

171 lines

test_framework/

7 lines

Diff 31699

src/net_processing.cpp

Loading...

test/functional/abc_p2p_avalanche_proof_voting.py

Loading...

test/functional/test_framework/avatools.py

Loading...