Page MenuHomePhabricator
Differential D10884

net: Remove g_relay_txes
ClosedPublic
Actions

Authored by Fabien on Jan 25 2022, 10:15.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC042e6fa41ef0: net: Remove g_relay_txes
Summary
g_relay_txes is only required inside net_processing and is set only once at startup. Instead of having a global, move it to be a const member of PeerManager.

This requires moving PushNodeVersion() into PeerManager, which also allows us to remove the connman argument.

Backport of core#20217.

Ref T1696.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 25 2022, 10:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 25 2022, 10:15
Fabien requested review of this revision.Jan 25 2022, 10:15
teamcity edited the summary of this revision. (Show Details)Jan 25 2022, 10:15
Harbormaster completed remote builds in B17994: Diff 31936.Jan 25 2022, 10:33
Fabien added inline comments.Jan 25 2022, 10:45
src/init.cpp
2362 ↗(On Diff #31936)

Note to reviewers: we don't need the intermediate arg due to code divergence with core (no fee policy estimator)

Fabien added a child revision: D10885: refactor: Remove nMyStartingHeight from CNode/Connman.Jan 25 2022, 11:05
PiRK accepted this revision.Jan 25 2022, 11:59
This revision is now accepted and ready to land.Jan 25 2022, 11:59
Closed by commit rABC042e6fa41ef0: net: Remove g_relay_txes (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJan 25 2022, 13:01
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC042e6fa41ef0: net: Remove g_relay_txes.

Revision Contents
Changeset List

PathSize
src/
avalanche/
test/
2 lines
10 lines
1 line
1 line
12 lines
100 lines
rpc/
4 lines
test/
8 lines
util/
2 lines

Diff 31945

View Options

src/avalanche/test/processor_tests.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/net_processing.h

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

src/test/denialofservice_tests.cpp

Loading...
View Options

src/test/util/setup_common.cpp

Loading...