net: implement the necessary parts of the I2P SAM protocol
ClosedPublic
Actions

Authored by PiRK on Feb 9 2022, 09:16.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC8a84a1c2cfff: net: implement the necessary parts of the I2P SAM protocol

Summary

Implement the following commands from the I2P SAM protocol:

HELLO: needed for all of the remaining ones
DEST GENERATE: to generate our private key and destination
NAMING LOOKUP: to convert .i2p addresses to destinations
SESSION CREATE: needed for STREAM CONNECT and STREAM ACCEPT
STREAM CONNECT: to make outgoing connections
STREAM ACCEPT: to accept incoming connections

This is a backport of core#20685 [14/20]
https://github.com/bitcoin/bitcoin/pull/20685/commits/c22daa2ecff1acd25426cd46f98f2587d1d324c3

Notes:

because of out of sequence backports, I had to apply a change from core#22937 to i2p.cpp (line 323) to explicitely convert a fs::path to a string.
This includes a change from https://github.com/bitcoin/bitcoin/pull/21407/commits/80a5a8ea2b7ad512c74c29df5b504e9be6cf23a0 i2p: limit the size of incoming messages. The rest of that commit was included in D11023

Test Plan

ninja all check-all

ninja && src/bitcoind -debug=i2p

For now only the compilation of the new code and the fact that the two additional lines of code in logging.{h|cpp} don't break anything are tested.
The next commit will make this code reachable, add functional tests, and provide a manual testing plan by actually using bitcoind with I2P.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 9 2022, 09:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 9 2022, 09:16

PiRK requested review of this revision.Feb 9 2022, 09:16

teamcity edited the summary of this revision. (Show Details)Feb 9 2022, 09:16

PiRK edited the summary of this revision. (Show Details)Feb 9 2022, 09:17

PiRK added a parent revision: D11024: net: extend Sock with a method to check whether connected.

Harbormaster completed remote builds in B18217: Diff 32301.Feb 9 2022, 10:07

I need to include the missing change from core#21407 not backported in previous diff

Include the missing change from core#21407: i2p: limit the size of incoming messages
This is needed because the rest of that commit was backported in D11023 to provide a way to test Sock::RecvUntilTerminator and SendComplete, and it provide a protection against spam attacks.

Harbormaster completed remote builds in B18222: Diff 32308.Feb 9 2022, 16:38

PiRK added a child revision: D11027: init: introduce I2P connectivity options.Feb 10 2022, 09:12

rebase

Harbormaster completed remote builds in B18231: Diff 32324.Feb 10 2022, 11:02

needs more manual testing

There is still no test in this commit, but the added code in i2p.cpp is not reachable by users, so there is no risk of introducing a bug through the new code. The changes in logging.{h|cpp} are tested with ninja && src/bitcoind -debug=i2p (at the moment this does not print anything, but it demonstrates that the i2p debug category is recognized.

I managed to test all of this after the next commit (D11027).

PiRK edited the test plan for this revision. (Show Details)Feb 11 2022, 10:07

Fabien accepted this revision.Feb 14 2022, 09:43

This revision is now accepted and ready to land.Feb 14 2022, 09:43

Closed by commit rABC8a84a1c2cfff: net: implement the necessary parts of the I2P SAM protocol (authored by Vasil Dimov <vd@FreeBSD.org>, committed by PiRK). · Explain WhyFeb 14 2022, 20:58

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC8a84a1c2cfff: net: implement the necessary parts of the I2P SAM protocol.