Page MenuHomePhabricator
Differential D11886

[Cashtab] [p4 match wif to address] Refactor burnEtoken()s utxo input collation and signing approach
AbandonedPublic
Actions

Authored by emack on Aug 26 2022, 11:38.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Summary

Depends on D11872

As per T2599, this is part of a stacked diff to sign utxos for non-eToken txs by matching wit to address.

This diff refactors the XEC utxo collation approach for the burnToken() function and aligns the signing approach for both XEC and eToken UTXOs.

Test Plan

npm test
burn a portion of an existing token and verify the correct XEC and eToken change and eToken balance update
burn the entirty of an existing token and verify the correct XEC change and nil remainder balance for the eToken

Diff Detail

Event Timeline

emack created this revision.Aug 26 2022, 11:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 26 2022, 11:38
emack requested review of this revision.Aug 26 2022, 11:38
Harbormaster completed remote builds in B19878: Diff 34740.Aug 26 2022, 11:41
emack added a child revision: D11887: [Cashtab] [p5 match wif to address] Update private messaging decryption wif extraction approach.Aug 27 2022, 08:14
bytesofman requested changes to this revision.Aug 29 2022, 17:48

Looks good but some issues to address.

  1. Changing the name of the function from burnEToken to burnToken is for the best, but this should be handled in its own diff or its own part of this stack
  2. Function should not accept both wallet and slpBalancesAndUtxos as parameters, as the wallet object should be the only reference for slpBalancesAndUtxos (in its state field)

These changes should be distinct from this diff

web/cashtab/src/hooks/useBCH.js
1158 ↗(On Diff #34740)

Same issue as part 3 -- we should not be accepting both wallet and slpBalancesAndUtxos as parameters. Accept wallet only and extract slpBalancesAndUtxos from there.

This revision now requires changes to proceed.Aug 29 2022, 17:48
emack updated this revision to Diff 34760.Aug 30 2022, 05:09
  1. Reverted burnToken back to burnEtoken
  2. slpBalancesAndUtxos input param will be deprecated as part 8
  3. burnEtoken rename to burnToken will be part 9
Harbormaster completed remote builds in B19892: Diff 34760.Aug 30 2022, 05:12
bytesofman accepted this revision.Aug 30 2022, 17:01
This revision is now accepted and ready to land.Aug 30 2022, 17:01
bytesofman requested changes to this revision.Sep 20 2022, 21:26

Due to mixed arcanist version issues, this stack landed in full when p1 landed

Please abandon

This revision now requires changes to proceed.Sep 20 2022, 21:26
emack abandoned this revision.Sep 21 2022, 00:29

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
hooks/
120 lines

Diff 34760

View Options

web/cashtab/src/hooks/useBCH.js

Loading...