Page MenuHomePhabricator
Differential D11887

[Cashtab] [p5 match wif to address] Update private messaging decryption wif extraction approach
AbandonedPublic
Actions

Authored by emack on Aug 27 2022, 08:14.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Summary

Depends on D11886

As per T2599, this is part of a stacked diff to sign utxos for non-eToken txs by matching wit to address.

This diff:

  • adds a getUtxoWif helper function to extract the WIF for a given UTXO
  • changes the cashtab messaging decryption logic to use getUtxosWif to obtain the funding wif rather than relying on the soon to be deprecated .wif attribute of an XEC utxo object
Test Plan

npm test
send and receive encrypted messages

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sendXecMatchWifToAddr
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19882
Build 39476: Build Diffcashtab-tests
Build 39475: arc lint + arc unit

Event Timeline

emack created this revision.Aug 27 2022, 08:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 27 2022, 08:14
emack requested review of this revision.Aug 27 2022, 08:14
Harbormaster completed remote builds in B19881: Diff 34746.Aug 27 2022, 08:17
emack updated this revision to Diff 34747.Aug 27 2022, 08:55

Updated error handling

Harbormaster completed remote builds in B19882: Diff 34747.Aug 27 2022, 08:58
emack added a child revision: D11888: [Cashtab] [p6 match wif to address] Update signAndBuildTx wif extraction approach.Aug 28 2022, 04:39
bytesofman requested changes to this revision.Aug 30 2022, 17:04

Diff looks good. However, I am not able to arc patch this. I think needs a rebase given the changes to part 4.

This revision now requires changes to proceed.Aug 30 2022, 17:04
bytesofman accepted this revision.Aug 31 2022, 16:30
This revision is now accepted and ready to land.Aug 31 2022, 16:30
bytesofman requested changes to this revision.Sep 20 2022, 21:26

Due to mixed arcanist version issues, this stack landed in full when p1 landed

Please abandon

This revision now requires changes to proceed.Sep 20 2022, 21:26
emack abandoned this revision.Sep 21 2022, 00:29

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
hooks/
8 lines
utils/
11 lines

Diff 34747

View Options

web/cashtab/src/hooks/useBCH.js

Loading...
View Options

web/cashtab/src/utils/cashMethods.js

Loading...