Page MenuHomePhabricator
Differential D11888

[Cashtab] [p6 match wif to address] Update signAndBuildTx wif extraction approach
AbandonedPublic
Actions

Authored by emack on Aug 28 2022, 04:39.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Summary

Depends on D11887

As per T2599, this is part of a stacked diff to sign utxos for non-eToken txs by matching wif to address.

This diff changes the signAndBuildTx() function to use getUtxosWif to obtain the funding wif rather than relying on the soon to be deprecated .wif attribute of an XEC utxo object

Includes updates to corresponding unit tests and mocks.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sendXecMatchWifToAddr
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19887
Build 39482: Build Diffcashtab-tests
Build 39481: arc lint + arc unit

Event Timeline

emack created this revision.Aug 28 2022, 04:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 28 2022, 04:39
emack requested review of this revision.Aug 28 2022, 04:39
Harbormaster completed remote builds in B19887: Diff 34752.Aug 28 2022, 04:42
emack added a child revision: D11889: [Cashtab] [p7 match wif to address] Deprecate normalizeSlpBalancesAndUtxos.Aug 28 2022, 07:16
bytesofman accepted this revision.Aug 31 2022, 16:37
This revision is now accepted and ready to land.Aug 31 2022, 16:37
bytesofman requested changes to this revision.Sep 20 2022, 21:26

Due to mixed arcanist version issues, this stack landed in full when p1 landed

Please abandon

This revision now requires changes to proceed.Sep 20 2022, 21:26
emack abandoned this revision.Sep 21 2022, 00:29

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
utils/
__mocks__/
6 lines
__tests__/
54 lines
6 lines

Diff 34752

View Options

web/cashtab/src/utils/__mocks__/mockTxBuilderData.js

Loading...
View Options

web/cashtab/src/utils/__tests__/cashMethods.test.js

Loading...
View Options

web/cashtab/src/utils/cashMethods.js

Loading...