Page MenuHomePhabricator
Differential D11892

[Cashtab] [p8 match wif to address] Deprecate slpBalancesAndUtxos input param
AbandonedPublic
Actions

Authored by emack on Aug 30 2022, 07:42.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Summary

Depends on D11889

As per T2599, this is part of a stacked diff to sign utxos for non-eToken txs by matching wif to address.

This diff deprecates the use of slpBalancesAndUtxos as a standalone input parameter for sendToken and burnEtoken functions, since this is an artifact from when the wallet object did not include utxo state information.

Test Plan

npm test
send a token tx
burn some tokens

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sendXecMatchWifToAddr
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19893
Build 39493: Build Diffcashtab-tests
Build 39492: arc lint + arc unit

Event Timeline

emack created this revision.Aug 30 2022, 07:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 30 2022, 07:42
emack requested review of this revision.Aug 30 2022, 07:42
emack added a child revision: D11893: [Cashtab] [p9 match wif to address] Rename burnEtoken to burnToken.Aug 30 2022, 07:53
Harbormaster completed remote builds in B19893: Diff 34762.Aug 30 2022, 08:06
bytesofman accepted this revision.Aug 31 2022, 19:03
This revision is now accepted and ready to land.Aug 31 2022, 19:03
bytesofman requested changes to this revision.Sep 20 2022, 21:26

Due to mixed arcanist version issues, this stack landed in full when p1 landed

Please abandon

This revision now requires changes to proceed.Sep 20 2022, 21:26
emack abandoned this revision.Sep 21 2022, 00:28

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Send/
7 lines
hooks/
__tests__/
5 lines
24 lines

Diff 34762

View Options

web/cashtab/src/components/Send/SendToken.js

Loading...
View Options

web/cashtab/src/hooks/__tests__/useBCH.test.js

Loading...
View Options

web/cashtab/src/hooks/useBCH.js

Loading...