Page MenuHomePhabricator

[Cashtab] [p7 match wif to address] Deprecate normalizeSlpBalancesAndUtxos
AbandonedPublic

Authored by emack on Aug 28 2022, 07:16.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Summary

Depends on D11888

As per T2599, this is part of a stacked diff to sign utxos for non-eToken txs by matching wif to address.

This diff deprecates the normalizeSlpBalancesAndUtxos function that adds the wif attribute to each UTXO object and updates update() in useWallet.js to simply set newState.slpBalancesAndUtxos to the slpBalancesAndUtxos object directly.

Cashtab is also canvassed end to end to ensure no lingering usages of utxo.wif.

Test Plan

npm test
grep -r '.wif' src/ and verify no output relating to the '.wif' attribute in XEC UTXOs. (ignore unrelated keyword matches in mocks)
send and receive XEC txs
send and receive token txs
send and receive encrypted messages
send and receive unencrypted messages
send and receive one to many XEC txs
send and receive one to many XEC txs with a message
burn token
retest above with a freshly created wallet

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sendXecMatchWifToAddr
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19888
Build 39484: Build Diffcashtab-tests
Build 39483: arc lint + arc unit

Event Timeline

emack requested review of this revision.Aug 28 2022, 07:16
This revision is now accepted and ready to land.Aug 31 2022, 18:58

Due to mixed arcanist version issues, this stack landed in full when p1 landed

Please abandon

This revision now requires changes to proceed.Sep 20 2022, 21:26